Change in ovirt-engine-cli[master]: cli: Support show by alias
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Support show by alias
......................................................................
cli: Support show by alias
Some collections, in particular the disks collection, don't support
retrieving elements by name, but by alias. This patch adds support for
this type of collections to the "show" command.
Change-Id: Ibf922ecf4d3f34a2c200ec7c145f18c15a8efd71
Bug-Url: https://bugzilla.redhat.com/1091725
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 41 insertions(+), 21 deletions(-)
Approvals:
Ravi Nori: Verified
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf922ecf4d3f34a2c200ec7c145f18c15a8efd71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: Revert "restapi : Create user API fails in SDK & CLI fails"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Revert "restapi : Create user API fails in SDK & CLI fails"
......................................................................
Revert "restapi : Create user API fails in SDK & CLI fails"
This reverts commit 072cd7f069539649e22ad6d47853dd9055d74d02.
The reason for reverting it is that it introduces a NPE in the
generation of the links for "job" entities.
A better way to solve the original issue is to fix it in the Python SDK:
http://gerrit.ovirt.org/32044
Change-Id: Id11acede0350989a2921f32f955e17404bd595c1
Bug-Url: https://bugzilla.redhat.com/1134233
Related-To: https://bugzilla.redhat.com/1122589
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
2 files changed, 3 insertions(+), 10 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id11acede0350989a2921f32f955e17404bd595c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine-sdk[sdk_3.5]: sdk: Fix find root tag
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Fix find root tag
......................................................................
sdk: Fix find root tag
Currently when the SDK needs to generate the XML document for an entity
it selects the root tag doing a reverse lookup inside the _rootClassMap
dictionary. This isn't correct, because that dictionary contains
duplicates. For example, for the "User" class there are more than one
corresponding tags:
"user": User,
"owner": User,
...
The root cause of this problem is that the _rootClassMap dictionary
contains entries for all the element definitions contained in the XML
schema, not only for the top level element definitions. The non top
level element definitions shouldn't be used to determine root tags, as
they can't be used as the root tag of valid XML documents.
This _rootClassMap dictionary was introduced to overcome a limitation of
generateDS.py, but that limitation was fixed in version 2.12a. It can't
be removed now because users may be calling the "findRootClass" function
that uses this dictionary.
To address these issues this patch modifies the code generator so that
it won't use the _rootClassMap dictionary, but the dictionary generated
by generateDS.py. In addition the patch also introduces a new
_tag_for_type dictionary to be used instead of the reverse lookup in
_rootClassMap. This new dictionary only contains the types corresponding
to top level elements.
The _rootClassMap dictionary and the related functions are preserved for
backwards compatibility.
Change-Id: I67b22c07ff4b91a7bf9b2ff8883ee51bef8c8f58
Related-To: https://bugzilla.redhat.com/1122589
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 26e1191239229f4b49337571a95995587a68207e)
---
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/RsdlCodegen.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdData.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/FindRootClassTemplate
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/GetRootTagTemplate
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/GetRootTagTemplate.java
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/ParseStringTemplate
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/ParseStringTemplate.java
M src/ovirtsdk/infrastructure/errors.py
M src/ovirtsdk/infrastructure/proxy.py
M src/ovirtsdk/utils/parsehelper.py
11 files changed, 99 insertions(+), 129 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67b22c07ff4b91a7bf9b2ff8883ee51bef8c8f58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine-sdk[master]: sdk: Fix find root tag
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Fix find root tag
......................................................................
sdk: Fix find root tag
Currently when the SDK needs to generate the XML document for an entity
it selects the root tag doing a reverse lookup inside the _rootClassMap
dictionary. This isn't correct, because that dictionary contains
duplicates. For example, for the "User" class there are more than one
corresponding tags:
"user": User,
"owner": User,
...
The root cause of this problem is that the _rootClassMap dictionary
contains entries for all the element definitions contained in the XML
schema, not only for the top level element definitions. The non top
level element definitions shouldn't be used to determine root tags, as
they can't be used as the root tag of valid XML documents.
This _rootClassMap dictionary was introduced to overcome a limitation of
generateDS.py, but that limitation was fixed in version 2.12a. It can't
be removed now because users may be calling the "findRootClass" function
that uses this dictionary.
To address these issues this patch modifies the code generator so that
it won't use the _rootClassMap dictionary, but the dictionary generated
by generateDS.py. In addition the patch also introduces a new
_tag_for_type dictionary to be used instead of the reverse lookup in
_rootClassMap. This new dictionary only contains the types corresponding
to top level elements.
The _rootClassMap dictionary and the related functions are preserved for
backwards compatibility.
Change-Id: I67b22c07ff4b91a7bf9b2ff8883ee51bef8c8f58
Related-To: https://bugzilla.redhat.com/1122589
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/RsdlCodegen.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdData.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/FindRootClassTemplate
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/GetRootTagTemplate
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/GetRootTagTemplate.java
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/ParseStringTemplate
D generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/ParseStringTemplate.java
M src/ovirtsdk/infrastructure/errors.py
M src/ovirtsdk/infrastructure/proxy.py
M src/ovirtsdk/utils/parsehelper.py
11 files changed, 99 insertions(+), 129 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32044
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67b22c07ff4b91a7bf9b2ff8883ee51bef8c8f58
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: restapi: Enable eject of cdrom via REST
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: restapi: Enable eject of cdrom via REST
......................................................................
restapi: Enable eject of cdrom via REST
Modified parameter validation to allow for files witout set id.
Also needed to normalize representation of "EJECT" as empty string on
backend in case `null` is received from REST api.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135970
Change-Id: Ia11068f319bcb5cf0ff1facedd9cb99ce4c9e5d0
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResourceTest.java
3 files changed, 18 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia11068f319bcb5cf0ff1facedd9cb99ce4c9e5d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: Stop ha services if they are running uncon...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Stop ha services if they are running unconfigured
......................................................................
packaging: setup: Stop ha services if they are running unconfigured
Change-Id: Iec96ab34cca90a19a813f1939ed235804d19b98a
Bug-Url: https://bugzilla.redhat.com/1134873
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit f3767c864334132442682b6a8ef5eb163b89b141)
---
M src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py
1 file changed, 21 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec96ab34cca90a19a813f1939ed235804d19b98a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: Stop ha services if they are running uncon...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Stop ha services if they are running unconfigured
......................................................................
packaging: setup: Stop ha services if they are running unconfigured
Change-Id: Iec96ab34cca90a19a813f1939ed235804d19b98a
Bug-Url: https://bugzilla.redhat.com/1134873
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py
1 file changed, 21 insertions(+), 6 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec96ab34cca90a19a813f1939ed235804d19b98a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: auto select dialog tab
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: auto select dialog tab
......................................................................
webadmin: auto select dialog tab
- Automatically select the first dialog tab with
an error in it when clicking ok on the dialog.
- Centralized logic that marks invalid tabs as invalid.
- Fixed some of the high light logic in the following popups:
- VMs
- Hosts
- Clusters
Change-Id: I2e9c5ad0cd3ee7f54606958b1fc8abd2bbd972ed
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057386
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabbedModelBoundPopupPresenterWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ValidationTabSwitchHelper.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/TabbedView.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractTabbedModelBoundPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/popup/AbstractVmBasedPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/HasValidatedTabs.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ValidationCompleteEvent.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/ConfigureLocalStoragePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
36 files changed, 838 insertions(+), 644 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e9c5ad0cd3ee7f54606958b1fc8abd2bbd972ed
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: handle hot-set and update running vm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: handle hot-set and update running vm
......................................................................
core: handle hot-set and update running vm
since the numOfSockets field was updateable, the infrastructure of
update-running-vm didn't take it into account,
when this was the only changed field, we had couple of issue:
1. the UI dialog didn't show, user cant choose if to apply now or later
2. next_run snapshot wasn't created
this fix is changine the field to updateableOnStatus, to handle above
issues, but since the user can choose if to use hot plug or not, a new
field introduced to the annotation, to mark fields that can be hot-set.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128443
Change-Id: I1c7f9b26ac4ddda6b446244b1fd85e2023809630
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnVmStatusField.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectIdentityCheckerTest.java
6 files changed, 71 insertions(+), 9 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c7f9b26ac4ddda6b446244b1fd85e2023809630
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: simplify ImportVmCommand#computeMinAllocatedMem
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: simplify ImportVmCommand#computeMinAllocatedMem
......................................................................
core: simplify ImportVmCommand#computeMinAllocatedMem
Change-Id: I5e0c315f9a6ce90c1efab40e4bd72233231a6b5e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 8 insertions(+), 10 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Gilad Chaplik: Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/32384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e0c315f9a6ce90c1efab40e4bd72233231a6b5e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months