January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add snapshot permission for live migration
by mlipchuk＠redhat.com 20 Jan '15

20 Jan '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add snapshot permission for live migration ...................................................................... core: Add snapshot permission for live migration Add permission check for VM snapshot on live storage migration. Change-Id: I6c0de2b0a7736ece173530f3c6f204bff503ab52 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c0de2b0a7736ece173530f3c6f204bff503ab52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: always allow to resume hibernated vm
by ahadas＠redhat.com 20 Jan '15

20 Jan '15

Arik Hadas has submitted this change and it was merged. Change subject: core: always allow to resume hibernated vm ...................................................................... core: always allow to resume hibernated vm Recent changes prevent us from resuming hibernated VM on cluster architecture that does not support snapshots with memory or with compatibility level that does not support snapshots with memory. This patch fix it. Change-Id: I8a1c449e52e74e0d567a7d2bfe7c6c22d328fae4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a1c449e52e74e0d567a7d2bfe7c6c22d328fae4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Moving allocation policy list box after storage do...
by tnisan＠redhat.com 19 Jan '15

19 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Moving allocation policy list box after storage domain in new disk widget. ...................................................................... webadmin: Moving allocation policy list box after storage domain in new disk widget. While changing storage domain in the new disk widget- the 'Allocation Policy' list box is changing accordingly. This patch moves the 'Allocation Policy' list box to be after the 'Storage Domain' list box to prevent a situation where the user selects options by order, and after choosing the policy, it will change when the user selects a domain without him noticing. Change-Id: Ia392bb8a6f0d2ebba65fe6ccc1ae5bf7a3e4df7e Bug-Url: https://bugzilla.redhat.com/1130116 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/37060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia392bb8a6f0d2ebba65fe6ccc1ae5bf7a3e4df7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: increase the release
by dougsland＠redhat.com 19 Jan '15

19 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: increase the release ...................................................................... spec: increase the release Increase the release for new changes. Change-Id: I4e016baee75163b9e611e38163656976aa51e92e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M configure.ac M ovirt-node-plugin-vdsm.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e016baee75163b9e611e38163656976aa51e92e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: Add vdsm-hook-ethtool-options as req
by dougsland＠redhat.com 19 Jan '15

19 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: Add vdsm-hook-ethtool-options as req ...................................................................... spec: Add vdsm-hook-ethtool-options as req vdsm-hook-ethtool is required for Network Custom Properties feature. Change-Id: I584a7ecec3ea23aa5572b784ba3e3bc2ef6307e4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1183626 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I584a7ecec3ea23aa5572b784ba3e3bc2ef6307e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: Add vdsm-hook-ethtool-options as req
by dougsland＠redhat.com 19 Jan '15

19 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: Add vdsm-hook-ethtool-options as req ...................................................................... spec: Add vdsm-hook-ethtool-options as req vdsm-hook-ethtool is required for Network Custom Properties feature. Change-Id: I584a7ecec3ea23aa5572b784ba3e3bc2ef6307e4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1183626 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I584a7ecec3ea23aa5572b784ba3e3bc2ef6307e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: edit cluster -> hwrng bottom part cut
by tjelinek＠redhat.com 19 Jan '15

19 Jan '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: edit cluster -> hwrng bottom part cut ...................................................................... webadmin: edit cluster -> hwrng bottom part cut The bottom part of the hwrng checkbox on the cluster popup has been cut. Fixed the same way as done in edit VM dialog - adding a padding-bottom to the section. Change-Id: Ie63fba37b9b788e700ce7c295a53762992d29390 Bug-Url: https://bugzilla.redhat.com/1166049 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie63fba37b9b788e700ce7c295a53762992d29390 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fonts inconsistent
by tjelinek＠redhat.com 19 Jan '15

19 Jan '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: fonts inconsistent ...................................................................... webadmin: fonts inconsistent Some fields have explicitely set the font to "Verdana,sans-serif" while the rest of the application is using "Arial, sans-serif" making the fonts inconsistent. Fixed by removing this declarations and left the font family to be inherited like all the other widgets. Change-Id: Ib5dec40e90b0bd72953427a5534268a7e7825905 Bug-Url: https://bugzilla.redhat.com/1166058 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 3 files changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5dec40e90b0bd72953427a5534268a7e7825905 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Adds mail notifications on build failures
by dcaroest＠redhat.com 19 Jan '15

19 Jan '15

David Caro has submitted this change and it was merged. Change subject: Adds mail notifications on build failures ...................................................................... Adds mail notifications on build failures Change-Id: I84a6031cccee6442b16444e52189845ac8927a87 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M .gitignore M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84a6031cccee6442b16444e52189845ac8927a87 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal: Removed "os type" from list of basic user fields
by tnisan＠redhat.com 19 Jan '15

19 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Removed "os type" from list of basic user fields ...................................................................... userportal: Removed "os type" from list of basic user fields Originally we expected the os type to come from the image so it was not changable / viewable for the basic user. Since the images did not make it to 3.5, this field has to be re-enabled for basic user. Change-Id: Id009ef6828e439a465e19f43bbd48cad4f965013 Bug-Url: https://bugzilla.redhat.com/1180105 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id009ef6828e439a465e19f43bbd48cad4f965013 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0