October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: instance images - correct size for Cinder disks
by tnisan＠redhat.com 25 Oct '15

25 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: instance images - correct size for Cinder disks ...................................................................... webadmin: instance images - correct size for Cinder disks New/Edit VM dialog: Cinder disks size should be formatted similarly to Images (using 'getSizeInGigabytes' method). Change-Id: Iaadee356fabd7f2121e2422746ab3cb2d111670a Bug-Url: https://bugzilla.redhat.com/1273950 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/47640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaadee356fabd7f2121e2422746ab3cb2d111670a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix proxy validation for import using v2v
by ahadas＠redhat.com 25 Oct '15

25 Oct '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix proxy validation for import using v2v ...................................................................... core: fix proxy validation for import using v2v AuditLogableBase#getVdsId returns Guid.Empty if the host was no set. However, in ImportVmFromExternalProviderCommand we check whether it is null. Therefore, this patch fixes this check. Change-Id: I40d8929bf6a07649dadb95961d5eb23f0f7eb9b9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/47697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40d8929bf6a07649dadb95961d5eb23f0f7eb9b9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: extend Permission tab with list of 'My groups'
by oourfali＠redhat.com 25 Oct '15

25 Oct '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: extend Permission tab with list of 'My groups' ...................................................................... webadmin: extend Permission tab with list of 'My groups' Offer a way to add permissions on object for users groups in Add Permissions dialog. Change-Id: I9e61a34036fdcc65b970cecf18e8ce2d9780ca19 Bug-Url: https://bugzilla.redhat.com/1273041 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/permissions/AbstractPermissionsPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 7 files changed, 169 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e61a34036fdcc65b970cecf18e8ce2d9780ca19 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Running passthrough vnic- api change
by alkaplan＠redhat.com 25 Oct '15

25 Oct '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Running passthrough vnic- api change ...................................................................... engine: Running passthrough vnic- api change This requires vdsm change-id I689629380996e5615f41e5705fa1f8fb322e0214 Bug-Url: https://bugzilla.redhat.com/1274316 Change-Id: I9d26df0f850d395c6ef359d9e4c404856e2f649d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Ido Barkan: Verified Alona Kaplan: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d26df0f850d395c6ef359d9e4c404856e2f649d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: tools: Fix issue with adding permission for manage-domains user
by oourfali＠redhat.com 25 Oct '15

25 Oct '15

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Fix issue with adding permission for manage-domains user ...................................................................... tools: Fix issue with adding permission for manage-domains user Fixes parameters of attach_user_to_role, which were broken due to refactoring made in I04e9c6fdb6723cd369908d40bb8a4a19f74d10f3. Change-Id: Ief31a99408706ee7a4974c93b63043c64f020d2b Bug-Url: https://bugzilla.redhat.com/1275043 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsDAOImpl.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief31a99408706ee7a4974c93b63043c64f020d2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Remove old PersistentSetupNetworksCommand
by tnisan＠redhat.com 25 Oct '15

25 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Remove old PersistentSetupNetworksCommand ...................................................................... engine: Remove old PersistentSetupNetworksCommand Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: I0f42287f127f8bf6540d0e9bf1591ce64a52383c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentSetupNetworksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 1 insertion(+), 292 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f42287f127f8bf6540d0e9bf1591ce64a52383c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Adjust Attach/Detach network to use HostSetupNetwork...
by tnisan＠redhat.com 25 Oct '15

25 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Adjust Attach/Detach network to use HostSetupNetworksCommand ...................................................................... engine: Adjust Attach/Detach network to use HostSetupNetworksCommand Instead of the old SetupNetworkCommand. Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: I263264d436a20aa065c6c4432dc0887eaf71f04b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 13 files changed, 160 insertions(+), 229 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I263264d436a20aa065c6c4432dc0887eaf71f04b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: PersistentSetupNetworks audit log fix
by tnisan＠redhat.com 25 Oct '15

25 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: PersistentSetupNetworks audit log fix ...................................................................... engine: PersistentSetupNetworks audit log fix The audit log should display the networks names only if they were passed to it as parameters. It shouldn't try to calculate the names of the changed networks. It causes bugs and doesn't have a big added value. Change-Id: Ib6fee08f46f5b79e78f94fda1b3f4440898f5a2e Bug-Url: https://bugzilla.redhat.com/1242236 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunction.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunctionTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 11 insertions(+), 102 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6fee08f46f5b79e78f94fda1b3f4440898f5a2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Remove/UpdateNetwork should invoke new setup network...
by tnisan＠redhat.com 25 Oct '15

25 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Remove/UpdateNetwork should invoke new setup networks command ...................................................................... engine: Remove/UpdateNetwork should invoke new setup networks command Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: I6fcaae1ea21372a3a521603b365dcd45c6f64803 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 8 files changed, 179 insertions(+), 228 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fcaae1ea21372a3a521603b365dcd45c6f64803 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: adjust ChangeVDSClusterCommand to use new HostSetupN...
by tnisan＠redhat.com 25 Oct '15

25 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: adjust ChangeVDSClusterCommand to use new HostSetupNetworks ...................................................................... engine: adjust ChangeVDSClusterCommand to use new HostSetupNetworks Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: Ice16351176e5547f11f7368cf3bc190da957597c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java 5 files changed, 339 insertions(+), 73 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice16351176e5547f11f7368cf3bc190da957597c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0