November 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: AddVmFromScratchCommand redundant condition

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmFromScratchCommand redundant condition ...................................................................... core: AddVmFromScratchCommand redundant condition Removed a redundant condition - if a domain's status is StorageDoaminStatus.ACTIVE, by definition it cannot be null. Change-Id: Idf22b49dcd3329be269f1e77c903913d4eb1b95b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf22b49dcd3329be269f1e77c903913d4eb1b95b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateVmCommand ObjectUtils

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmCommand ObjectUtils ...................................................................... core: UpdateVmCommand ObjectUtils Replace the usage of Apache Commons Lang's ObjectUtils.equals with Java 7's Objects.equals, as part of the effort to reuse as much of the JDK as possible and bring the usage of unneeded third parties down to a minimum. Change-Id: Ifd8874b6f83047f5223c429b26a4821a5f794076 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd8874b6f83047f5223c429b26a4821a5f794076 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: provider dialog - filter out unsupported DCs for C...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: provider dialog - filter out unsupported DCs for Cinder ...................................................................... webadmin: provider dialog - filter out unsupported DCs for Cinder New Provider dialog: filter out unsupported data-centers for Cinder. Change-Id: I0068dce61569cab5523e814b9ddde1eecf8d9324 Bug-Url: https://bugzilla.redhat.com/1285228 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0068dce61569cab5523e814b9ddde1eecf8d9324 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in jenkins[master]: mock_runner:Testing one of the repo urls for proxy

by dcaro＠redhat.com

David Caro has submitted this change and it was merged. Change subject: mock_runner:Testing one of the repo urls for proxy ...................................................................... mock_runner:Testing one of the repo urls for proxy Instead of using ovirt.org, using one of the repo urls, that ensures that not only squid is up, but repoproxy too Might introdure false failures if that specific repo is not up, but right now repoproxy is less stable under high load Change-Id: Ie0007c57a933d02f3512825f4d9ea61d129a0f5c Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Looks good to me David Caro: Verified; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/49225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0007c57a933d02f3512825f4d9ea61d129a0f5c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: provider dialog - filter out unsupported DCs for C...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: provider dialog - filter out unsupported DCs for Cinder ...................................................................... webadmin: provider dialog - filter out unsupported DCs for Cinder New Provider dialog: filter out unsupported data-centers for Cinder. Change-Id: I0068dce61569cab5523e814b9ddde1eecf8d9324 Bug-Url: https://bugzilla.redhat.com/1285228 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0068dce61569cab5523e814b9ddde1eecf8d9324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: VmPools can use <use_latest_template_version>

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: VmPools can use <use_latest_template_version> ...................................................................... restapi: VmPools can use <use_latest_template_version> VmPools updates and adds can now use <use_latest_template_version> as optional argument. Change-Id: Ia86f423728dfca0dab7c4321ba32eb17ca04a789 Bug-Url: https://bugzilla.redhat.com/1284596 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java M backend/manager/modules/restapi/model/src/main/java/types/VmPool.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java 4 files changed, 10 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86f423728dfca0dab7c4321ba32eb17ca04a789 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: disable hotplug for PPC

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: disable hotplug for PPC ...................................................................... core: disable hotplug for PPC disable hotplug memory for PPC Change-Id: I86270cfcb28eebd37afecb4bc53fd0e0a18d77db Bug-Url: https://bugzilla.redhat.com/1284775 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86270cfcb28eebd37afecb4bc53fd0e0a18d77db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-guest-agent[ovirt-3.5]: win32: Update version information reporting for Win8+ and si...

by vfeenstr＠redhat.com

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Update version information reporting for Win8+ and simplify ...................................................................... win32: Update version information reporting for Win8+ and simplify With Windows 8.1 the API for retrieving the OS version on Windows has changed that it won't report a higher version than 6.2 even though it might be Windows 8.1 or Windows 10 etc This code change introduces a new way to retrieve the current version by using RtlGetVersion which still does behave the old way. Additionally this patch already introduces the Windows 2016 Server detection as the version for this is known. Also this patch now removes obsolete and unsupported versions. Change-Id: I8047842b080140e072b04c2af46ec0e6b8287c51 Bug-Url: https://bugzilla.redhat.com/1279980 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 54 insertions(+), 44 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8047842b080140e072b04c2af46ec0e6b8287c51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-guest-agent[ovirt-3.6]: win32: Update version information reporting for Win8+ and si...

by vfeenstr＠redhat.com

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Update version information reporting for Win8+ and simplify ...................................................................... win32: Update version information reporting for Win8+ and simplify With Windows 8.1 the API for retrieving the OS version on Windows has changed that it won't report a higher version than 6.2 even though it might be Windows 8.1 or Windows 10 etc This code change introduces a new way to retrieve the current version by using RtlGetVersion which still does behave the old way. Additionally this patch already introduces the Windows 2016 Server detection as the version for this is known. Also this patch now removes obsolete and unsupported versions. Change-Id: I8047842b080140e072b04c2af46ec0e6b8287c51 Bug-Url: https://bugzilla.redhat.com/1279980 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 51 insertions(+), 43 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8047842b080140e072b04c2af46ec0e6b8287c51 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix equals method in AutoStartVmsRunner

by mperina＠redhat.com

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix equals method in AutoStartVmsRunner ...................................................................... core: Fix equals method in AutoStartVmsRunner Fixes equals method in AutoStartVmsRunner. Change-Id: I67b54a7e53f6947d6db5a114cf5d5b8249629cef Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67b54a7e53f6947d6db5a114cf5d5b8249629cef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2015