Change in ovirt-engine[ovirt-engine-3.6]: engine: remove ie8 GWT permutation
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: remove ie8 GWT permutation
......................................................................
engine: remove ie8 GWT permutation
Change-Id: Ie69b5b546ed418994809617a67baedb136a9d645
Bug-Url: https://bugzilla.redhat.com/1276510
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M frontend/webadmin/modules/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Alexander Wels: Looks good to me, approved
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/47909
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie69b5b546ed418994809617a67baedb136a9d645
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: engine: Refactor Create Volume with initial size
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Refactor Create Volume with initial size
......................................................................
engine: Refactor Create Volume with initial size
Refactor the Create Volume interface with initial size to one
method instead of two.
Change-Id: If7db8ad8a95fec0eb980daa5e986b5e627717f8e
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
5 files changed, 26 insertions(+), 73 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/47730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7db8ad8a95fec0eb980daa5e986b5e627717f8e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: invoke connectStorageServers for Cinder domains
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: invoke connectStorageServers for Cinder domains
......................................................................
core: invoke connectStorageServers for Cinder domains
On e07565966a75801fdb250ceeb4a686c1c004ccb8, secrets registration logic
was removed from ConnectHostToStoragePoolServersCommand based on the
assumption that a storage_server_connection should exist for all
storage domains. However, no connection is created for Cinder domains,
hence, 'connectStorageServersByType' should be invoked directly.
Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8
Bug-Url: https://bugzilla.redhat.com/1276915
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6.0]: core: fixing NPE when importing nic with null valued mac
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fixing NPE when importing nic with null valued mac
......................................................................
core: fixing NPE when importing nic with null valued mac
Error fix of bug introduced by:
779d378e2b51510b54950e8f1f384382bfc956a5
In former code (prior to mentioned erroneous patch) was null valued
mac used to gather nics from db, which indeed return no nics, thus no
match was found and true returned. With removal of this call error
was made; when mac of passed in nic is null, true must be returned.
Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Bug-Url: https://bugzilla.redhat.com/1270003
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47933
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.0
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: fixing NPE when importing nic with null valued mac
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fixing NPE when importing nic with null valued mac
......................................................................
core: fixing NPE when importing nic with null valued mac
Error fix of bug introduced by:
779d378e2b51510b54950e8f1f384382bfc956a5
In former code (prior to mentioned erroneous patch) was null valued
mac used to gather nics from db, which indeed return no nics, thus no
match was found and true returned. With removal of this call error
was made; when mac of passed in nic is null, true must be returned.
Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Bug-Url: https://bugzilla.redhat.com/1270003
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: fixing NPE when importing nic with null valued mac
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: fixing NPE when importing nic with null valued mac
......................................................................
core: fixing NPE when importing nic with null valued mac
Error fix of bug introduced by:
779d378e2b51510b54950e8f1f384382bfc956a5
In former code (prior to mentioned erroneous patch) was null valued
mac used to gather nics from db, which indeed return no nics, thus no
match was found and true returned. With removal of this call error
was made; when mac of passed in nic is null, true must be returned.
Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Bug-Url: https://bugzilla.redhat.com/1270003
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 10 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified; Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If372e00c35954c4f52b9b7f097a837a70022bf7b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: invoke connectStorageServers for Cinder domains
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: invoke connectStorageServers for Cinder domains
......................................................................
core: invoke connectStorageServers for Cinder domains
On e07565966a75801fdb250ceeb4a686c1c004ccb8, secrets registration logic
was removed from ConnectHostToStoragePoolServersCommand based on the
assumption that a storage_server_connection should exist for all
storage domains. However, no connection is created for Cinder domains,
hence, 'connectStorageServersByType' should be invoked directly.
Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8
Bug-Url: https://bugzilla.redhat.com/1276915
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2f0c10fd1cb243631036087d9f5169f38d42ad8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: userportal: Enable contextual alerts in UserPortal
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: Enable contextual alerts in UserPortal
......................................................................
userportal: Enable contextual alerts in UserPortal
Following patch [1], this enables global (contextual)
alert messages in UserPortal web application, including
the common 'Uncaught exception' alert message triggered
by global uncaught exception handler.
[1] https://gerrit.ovirt.org/#/c/47074/
Change-Id: If1b3f923e32c1ccefc56ce6b80f48f1e193cb797
Bug-Url: https://bugzilla.redhat.com/1275760
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/MainSectionPresenter.java
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/47907
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1b3f923e32c1ccefc56ce6b80f48f1e193cb797
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Enable force remove for host
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Enable force remove for host
......................................................................
webadmin: Enable force remove for host
Enable force remove of host if gluster service
is enabled, even when virt service is also enabled
Change-Id: I14b5aa4ce6349d2d3dbddf4a6e8c068c4c8301ce
Bug-Url: https://bugzilla.redhat.com/1244935
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14b5aa4ce6349d2d3dbddf4a6e8c068c4c8301ce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months