November 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: Frontend: ConsoleUserName & ClientIP update regression fix

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: Frontend: ConsoleUserName & ClientIP update regression fix ...................................................................... Frontend: ConsoleUserName & ClientIP update regression fix Due to comparison of the same variable which never can be false, the values for the ConsoleUserName and ClientIP fields for console users was not updated. This patch fixes this regression which was introduced in the refactoring of the sessions tab into the guest info tab. Change-Id: Ibb13bd4e9e8a77ee606520133c681464ac119ba5 Bug-Url: https://bugzilla.redhat.com/1272978 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/49132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb13bd4e9e8a77ee606520133c681464ac119ba5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 ...................................................................... core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 patch 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 was entirelly wrong. One must not consult macPool there, since interface here already has MAC address obtained from pool, so check here always failed. It probably cannot be reverted nicely, since there were other patches fixing some of problems this patch introduced. note: bug https://bugzilla.redhat.com/show_bug.cgi?id=1212461 related to patch being reverted, was reverified as well and I did not reproduce it. Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf Bug-Url: https://bugzilla.redhat.com/1270583 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 6 insertions(+), 31 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: provider dialog - filter out unsupported DCs for C...

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: provider dialog - filter out unsupported DCs for Cinder ...................................................................... webadmin: provider dialog - filter out unsupported DCs for Cinder New Provider dialog: filter out unsupported data-centers for Cinder. Change-Id: I0068dce61569cab5523e814b9ddde1eecf8d9324 Bug-Url: https://bugzilla.redhat.com/1285228 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/49167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0068dce61569cab5523e814b9ddde1eecf8d9324 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 ...................................................................... core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 patch 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 was entirelly wrong. One must not consult macPool there, since interface here already has MAC address obtained from pool, so check here always failed. It probably cannot be reverted nicely, since there were other patches fixing some of problems this patch introduced. note: bug https://bugzilla.redhat.com/show_bug.cgi?id=1212461 related to patch being reverted, was reverified as well and I did not reproduce it. Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf Bug-Url: https://bugzilla.redhat.com/1270583 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 6 insertions(+), 31 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.1]: engine: Use pagination when querying errata

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: Use pagination when querying errata ...................................................................... engine: Use pagination when querying errata Satellite 6.1 limits page size for 20 errata per page. This limit is too small to retrieve therefore specifying a larger amount of errata to get. Katello 2.1 doesn't support pagination, therefore using pagination in request is ignored. Change-Id: Icde94303cb7177ce2f09a784a5f8c105e1bd0885 Bug-Url: https://bugzilla.redhat.com/1284060 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icde94303cb7177ce2f09a784a5f8c105e1bd0885 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: resolve Coverity issue 1306186

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: resolve Coverity issue 1306186 ...................................................................... core: resolve Coverity issue 1306186 Adding null check if getStatusImage returns null Change-Id: Iaaff7e8cdcb0b90c2f9a32d7d2ffd8d96131540d Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaff7e8cdcb0b90c2f9a32d7d2ffd8d96131540d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix unintentional integer overflow

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix unintentional integer overflow ...................................................................... core: Fix unintentional integer overflow Fixes possible integer overflow before saving value into long field. This was caused by type change int -> long in ThreadUtils.sleep() in patch I870c2b37ba7c818fca113dfafdf12bd5083db92b. Issues were detected in Coverity CIDs 1338744 and 1338745. Change-Id: Id7f1386efec4267c78914e36bf7e0e773669959f Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsKdumpDetectionCommand.java 4 files changed, 11 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f1386efec4267c78914e36bf7e0e773669959f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: SearchQuery LinqUtils

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQuery LinqUtils ...................................................................... core: SearchQuery LinqUtils Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. Change-Id: I67e568a392116d6fd37c6d249949c27ee3f7d5bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e568a392116d6fd37c6d249949c27ee3f7d5bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VdsEventListener LinqUtils

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: VdsEventListener LinqUtils ...................................................................... core: VdsEventListener LinqUtils Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. Change-Id: Ieec10e60dbdc7d255d9b92649b2815a9d9c2a31f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 10 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec10e60dbdc7d255d9b92649b2815a9d9c2a31f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: IsSystemSuperUserPredicate

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: IsSystemSuperUserPredicate ...................................................................... core: IsSystemSuperUserPredicate Changed IsSystemSuperUserPredicate (and all the places that use it) to implement Java 8's standard java.util.function.Predicate instead of the out-dated org.ovirt.engine.core.utils.linq.Predicate, as part of the attempt to remove the latter from the codebase completely. Change-Id: I244fdc829750ad9fc3a84c5c36749bf50319dba8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsSystemSuperUserPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244fdc829750ad9fc3a84c5c36749bf50319dba8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2015