November 2015 - Engine-commits - Ovirt List Archives

Change in jenkins[master]: Drop virtio-win-drivers and spice-qxl from master

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: Drop virtio-win-drivers and spice-qxl from master ...................................................................... Drop virtio-win-drivers and spice-qxl from master Do not build or publish them. Keep for 3.5. See also [1]. [1] https://gerrit.ovirt.org/48425 Change-Id: Ie9db7cb89503bfd5e42749bf9bd1675bb340ee33 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml M jobs/confs/projects/spice-qxl/spice-qxl.yaml M jobs/confs/projects/virtio-win-drivers/virtio-win-drivers.yaml 4 files changed, 0 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9db7cb89503bfd5e42749bf9bd1675bb340ee33 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: check if pci slot is used by managed device during v...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: engine: check if pci slot is used by managed device during vm nic hotplug ...................................................................... engine: check if pci slot is used by managed device during vm nic hotplug Change-Id: Ic4143197d5c30fc28e58d1203a8490a614a3ca88 Bug-Url: https://bugzilla.redhat.com/1199782 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 32 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4143197d5c30fc28e58d1203a8490a614a3ca88 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: KeyValueFormatValidationTest modifiers

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: KeyValueFormatValidationTest modifiers ...................................................................... core: KeyValueFormatValidationTest modifiers Fixed the "constants" modifiers to be private static final, as per Java's recommended coding conventions. This patch solves CID 1340067. Change-Id: I983361035b1e6e798705af1f41555a941de08ddc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidationTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I983361035b1e6e798705af1f41555a941de08ddc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: consider Everyone->diskProfileUser as basic user p...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: frontend: consider Everyone->diskProfileUser as basic user permission ...................................................................... frontend: consider Everyone->diskProfileUser as basic user permission Similar to vnicProfileUser, an upgrade will make Everyone a profileEditor or a diskProfileUser, but that should not make them viewthe Extended User Portal. Change-Id: I81bf88b7d4d0e16142dfad83b2e0d03039243a18 Bug-Url: https://bugzilla.redhat.com/1284233 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 2 files changed, 20 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/48979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81bf88b7d4d0e16142dfad83b2e0d03039243a18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: set Firefox 38 as the supported browser.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: set Firefox 38 as the supported browser. ...................................................................... webadmin: set Firefox 38 as the supported browser. Change-Id: Ifea9d5b055a7a012672725cd6134ece85afe4fe5 Bug-Url: https://bugzilla.redhat.com/1223194 Bug-Url: https://bugzilla.redhat.com/1273034 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/48698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea9d5b055a7a012672725cd6134ece85afe4fe5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: db: Add console_disconnect_action on VM Templates

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: db: Add console_disconnect_action on VM Templates ...................................................................... db: Add console_disconnect_action on VM Templates Handling the console_disconnect_action was missing for VM Templates. This patch adds this missing part. Change-Id: I2f9a17308196e83e50ad976b6204bad60082975b Bug-Url: https://bugzilla.redhat.com/1280251 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M packaging/dbscripts/vm_templates_sp.sql 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/49084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f9a17308196e83e50ad976b6204bad60082975b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Unpin numa nodes when preferred host changes

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Unpin numa nodes when preferred host changes ...................................................................... webadmin: Unpin numa nodes when preferred host changes * Pin VM numa nodes to new preferred host when possible. * Unpin all VM numa nodes when new preferred host does not have the corrseponding host numa node. * Only show VM numa nodes of VMs which are pinned to the selected host in the numa node configuration panel. Bug-Url: https://bugzilla.redhat.com/1177259 Change-Id: Iabb16f1b3dbcb7f821046dddaa3b719314598d06 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 39 insertions(+), 30 deletions(-) Approvals: Tal Nisan: Passed CI tests Roman Mohr: Verified Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabb16f1b3dbcb7f821046dddaa3b719314598d06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Return empty list if no VM numa nodes are present

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Return empty list if no VM numa nodes are present ...................................................................... core: Return empty list if no VM numa nodes are present Let AddVmNumaNodesCommand and VM always return an empty list instead of null if no numa configuration is present to avoid confusing null checks. Bug-Url: https://bugzilla.redhat.com/1279178 Bug-Url: https://bugzilla.redhat.com/1177259 Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNumaNodeOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 3 files changed, 12 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Passed CI tests Roman Mohr: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095e245227aed5e5c8f6d342d2a8af17b936eb00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: packaging: vnconsole: fix pep8 issues

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: vnconsole: fix pep8 issues ...................................................................... packaging: vnconsole: fix pep8 issues Fix pep8 issues detected by pep8 1.6.2 Change-Id: Ic3c4e1028b3b87a3e29b21927fcd05c62df36c72 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c4e1028b3b87a3e29b21927fcd05c62df36c72 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: GUI refactor NumaNode guid to NumaNode id

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: GUI refactor NumaNode guid to NumaNode id ...................................................................... webadmin: GUI refactor NumaNode guid to NumaNode id Fix GUI, display pinned NUMA nodes by their index (not Guid) --------------------------------------------------------------- In NumaSupportModel class. Refactor p2vNumaNodesMap map. To store pNodes and their pinned vNodes. Change the key from Guid to Integer. Refactor all members using this map. In order to prevent guid consistency maintenance whenever a host is re-added/removed. Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Bug-Url: https://bugzilla.redhat.com/1177259 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1261c81ddbc2e18fd273c25945e9cc24032bdd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2015