Change in ovirt-engine[master]: aaa: Pass authRecord for login on behalf
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: Pass authRecord for login on behalf
......................................................................
aaa: Pass authRecord for login on behalf
Pass authRecord to sso from restapi for
loginOnBehalf while using exteranl auth.
Change-Id: I443093cfaeaf10813e0598ff5e020849116aa76c
Bug-Url: https://bugzilla.redhat.com/1092744
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOOAuthServiceUtils.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiNegotiationFilter.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/JsonExtDeserializer.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/JsonExtMapMixIn.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOConstants.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonExtKeySerializer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonExtMapMixIn.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java
9 files changed, 92 insertions(+), 15 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Ravi Nori: Verified
Moti Asayag: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47781
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I443093cfaeaf10813e0598ff5e020849116aa76c
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: aaa: Modify welcome screen to show user name and options as ...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: Modify welcome screen to show user name and options as menu
......................................................................
aaa: Modify welcome screen to show user name and options as menu
Adds user menu to welcome screen and error page.
Lets the user logout/switch user.
Change-Id: I0227778d53f4c63867aa2887580539efab8fa7c8
Bug-Url: https://bugzilla.redhat.com/1092744
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/branding/src/main/resources/META-INF/obrand.tld
A backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/header.tag
M backend/manager/modules/welcome/pom.xml
A backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java
A backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LogoutServlet.java
A backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java
A backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/SwitchUserServlet.java
A backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeContextListener.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
A backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java
M backend/manager/modules/welcome/src/main/resources/messages.properties
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
M ovirt-engine.spec.in
M packaging/services/ovirt-engine/ovirt-engine.conf.in
17 files changed, 608 insertions(+), 52 deletions(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
Moti Asayag: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/40672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0227778d53f4c63867aa2887580539efab8fa7c8
Gerrit-PatchSet: 154
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: aaa: Modify webadmin and userportal to use enginesso for aut...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: Modify webadmin and userportal to use enginesso for authentication
......................................................................
aaa: Modify webadmin and userportal to use enginesso for authentication
Add webadmin side code to support authentication using
engine sso. Modify webadmin and user portal to use the
new SSO filters for authorization.
Session validation on engine side is done using
sso
Modify the welcome page to show the current
user logged in and provide a link to switch
user by invalidating the current session and
turning off external auth
Basic auth and negotiate filters on engine side
are not required
SSO token and JSESSION from rest api should be
obtained using Engine Session Id and SSO Session Id.
The setup is sso aware and registers the engine with the
sso as a client.
Remove code that performs login in UI.
Login user and admin commands and the parameter
can be deleted from the backend as the login sequence
is handled by SSO
Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08
Bug-Url: https://bugzilla.redhat.com/1092744
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/exclude-filters.xml
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AcctUtils.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOOAuthServiceUtils.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SSOUtils.java
D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EngineSessionTokenAuthenticationFilter.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java
D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSOLoginFilter.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiAuthFilter.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SSORestApiNegotiationFilter.java
D backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionMgmtFilter.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOLoginServlet.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOLogoutServlet.java
A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java
M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/auth-plugin/src/main/java/org/ovirt/engine/core/jboss_auth_plugin/OvirtAuthPlugIn.java
M backend/manager/modules/auth-plugin/src/main/modules/org/ovirt/engine/core/auth-plugin/main/module.xml
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEngineSessionIdForSSOTokenQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetEngineSessionIdTokenQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionsForTokenCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateUserSessionParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TerminateSessionsForTokenParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/SessionConstants.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEngineSessionIdForSSOTokenQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java
A backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/SSOCallbackServlet.java
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonExtDeserializer.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonExtMapMixIn.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
M backend/manager/modules/welcome/src/main/resources/messages.properties
A backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/CommunicationProvider.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/OperationProcessor.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FrontendUrlUtils.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManagerTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/RestApiSessionManager.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/section/DefaultLoginSectionPlace.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractHeaderView.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/UserPortalApplicationPlaces.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginFormPresenterWidget.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginSectionPresenter.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginSectionView.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginSectionView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginFormPresenterWidget.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginSectionView.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginSectionView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py
107 files changed, 2,247 insertions(+), 3,067 deletions(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
Moti Asayag: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08
Gerrit-PatchSet: 173
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: aaa : Add engine sso
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa : Add engine sso
......................................................................
aaa : Add engine sso
Add sso module that is OAuth2 compliant.
Supports authentication using basic auth,
external auth using headers and falls back
to form based authentication.
Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa
Bug-Url: https://bugzilla.redhat.com/1092744
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
A backend/manager/modules/enginesso/exclude-filters.xml
A backend/manager/modules/enginesso/pom.xml
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/context/SSOContextListener.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/context/SSOSessionListener.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveBasicAuthServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveBasicEnforceServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNegotiateAuthServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveNextAuthServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveRedirectToModuleServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthRevokeServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/StatusServlet.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthResult.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationException.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationProfile.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthnMessageMapper.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/ClientInfo.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/Credentials.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/DBUtils.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/InteractiveAuth.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/JsonExtKeySerializer.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/JsonExtMapMixIn.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NegotiateAuthUtils.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NonInteractiveAuth.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/OAuthException.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOConstants.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOContext.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOExtensionsManager.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOLocalConfig.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOSession.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java
A backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java
A backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
A backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/pom.xml
M ear/pom.xml
M ovirt-engine.spec.in
A packaging/dbscripts/sso_clients_sp.sql
A packaging/dbscripts/upgrade/04_00_0020_add_sso_client_registration_and_scope_dependency.sql
M packaging/services/ovirt-engine/ovirt-engine.conf.in
44 files changed, 3,763 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Moti Asayag: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa
Gerrit-PatchSet: 171
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: fix tooltip behavior in Setup Networks
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fix tooltip behavior in Setup Networks
......................................................................
webadmin: fix tooltip behavior in Setup Networks
In Setup Host Networks, drag and drop operations were being blocked
by tooltips.
Added a mousedown handler on the relevent Panels to hide any open
tooltip before initiating a DnD operation.
Bug-Url: https://bugzilla.redhat.com/1249900
Bug-Url: https://bugzilla.redhat.com/1272857
Change-Id: I76a4dfe1d2002b57b42702257d3aad0b09ebef4a
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/48874
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76a4dfe1d2002b57b42702257d3aad0b09ebef4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: core: do not pass the context automatically on rollback
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: do not pass the context automatically on rollback
......................................................................
core: do not pass the context automatically on rollback
In change I310f5f77fff78b3232ee77fe63791425fd521516
CommandBase.attemptRollback() was changed so that instead of accepting a
callback as a parameter it automatically clones the current command
context and passes it.
That changed the previous behavior, as the using commands didn't pass
the context.
This change isn't documented in the change commit message and affects the
rollback, as now the context is passed always the compensation context
of the rollback initiating command is used opposed to before.
therefore i'm restoring the previous behavior here (null was passed as the
context for the callback).
Change-Id: I02cd0bf6ff89591f5f62741200b5620ac96fbd90
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284250
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
3 files changed, 10 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/49094
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02cd0bf6ff89591f5f62741200b5620ac96fbd90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: core: RemoveImage - fix parameters ctor
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: RemoveImage - fix parameters ctor
......................................................................
core: RemoveImage - fix parameters ctor
The parameters shoudld execute the ctor that gets the context as needed
logic is contained there.
Change-Id: If0c6eb9fc892b9ed6b7e13ab5e370d0fa753d4b3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284250
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/49093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0c6eb9fc892b9ed6b7e13ab5e370d0fa753d4b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDiskCommand - do not attempt to increment db...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveOrCopyDiskCommand - do not attempt to increment db gen
......................................................................
core: MoveOrCopyDiskCommand - do not attempt to increment db gen
When copying a floating/VM disk the disk is copied to a new floating
disk, therefore there is no need to attempt to increment the db
generation.
Change-Id: Ifa660944f8de2c93d0a595aa9ca5387ff2de6d8a
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/49092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa660944f8de2c93d0a595aa9ca5387ff2de6d8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDisk - attempt to perform rollback for vm/fl...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveOrCopyDisk - attempt to perform rollback for vm/floating disk
......................................................................
core: MoveOrCopyDisk - attempt to perform rollback for vm/floating disk
Currently when executing MoveOrCopyDisk for a non template disk no rollback is
done and the disk will remain in the engine as a legit disk, while for
template disk the mapping of the disk on the other domain will be
deleted from the db.
This patch adds an attempt to perform a rollback when copying a non
template disk, the rollback when copying a template disk requires some
other modifications and will be handled on a different patch.
Change-Id: Id6727f513efca391ff843a1665dabb7826533706
Bug-Url: https://bugzilla.redhat.com/1232396
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/49091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6727f513efca391ff843a1665dabb7826533706
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: core: MoveOrCopyDisk - the created disk should be locked
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveOrCopyDisk - the created disk should be locked
......................................................................
core: MoveOrCopyDisk - the created disk should be locked
MoveOrCopyDiskCommand creates a new disk when a disk which isn't a
template disk is being copied.
The created disk isn't LOCKED, which allows to attempt to perform
operations using the disk while the copy wasn't finished yet.
This patch makes sure that the disk is added as LOCKED.
Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282694
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/49090
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month