Change in ovirt-engine[master]: core: DeactivateStorageDomainCommand - refresh all hosts
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: DeactivateStorageDomainCommand - refresh all hosts
......................................................................
core: DeactivateStorageDomainCommand - refresh all hosts
Currently on DeactivateStorageDomain in a DC that uses the disk backend
we refresh the hosts that are used to move domains to Active status
while in dc that uses the memory backend we refresh also hosts in
statuses that we check before moving a domain to maintenance.
As currently the refresh operation always required an access to the
master domain, this patch unifies the behavior - the operation might
take long time if there's no access to the master domain, but on most
cases we'll benefit from it as domain will move to Maintenance status
faster if there is a non operational host.
Change-Id: I4c371e6188cdb93e1986996c2dc9b843889969bd
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
1 file changed, 1 insertion(+), 9 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49011
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c371e6188cdb93e1986996c2dc9b843889969bd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: errata table sorting
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: webadmin: errata table sorting
......................................................................
webadmin: errata table sorting
- Added sorting capabilities to the errata tables
Change-Id: Ia477ffa8a25df507963c2187ebfa580d0ee7be21
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283117
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ErrataTableView.java
1 file changed, 33 insertions(+), 12 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49036
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia477ffa8a25df507963c2187ebfa580d0ee7be21
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: Host->General software sub tab
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: webadmin: Host->General software sub tab
......................................................................
webadmin: Host->General software sub tab
- Fixed issue with layout of host general software sub
sub tab. This now takes the entire available width of
the panel instead of 1/4 of the available size.
Change-Id: I897512662c4df3e2b2cefcd914219794f9d0f3ac
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281297
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java
1 file changed, 16 insertions(+), 9 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I897512662c4df3e2b2cefcd914219794f9d0f3ac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin, userportal: translations update
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update
......................................................................
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, ovirt-3.6 version.
[ovirt-3.6, translation cycle 5]
Change-Id: Id62bc7bc83cd30f8ae77672985c7b3c728cb5cb4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284271
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_de_DE.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_es_ES.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_fr_FR.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ja_JP.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_pt_BR.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_zh_CN.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_de_DE.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_es_ES.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_fr_FR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_ja_JP.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_pt_BR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_zh_CN.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_de_DE.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_es_ES.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_fr_FR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ja_JP.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_pt_BR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_zh_CN.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_de_DE.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_es_ES.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_fr_FR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ja_JP.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_pt_BR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_zh_CN.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_de_DE.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es_ES.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr_FR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja_JP.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_de_DE.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_es_ES.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_fr_FR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_ja_JP.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_pt_BR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_zh_CN.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_de_DE.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_es_ES.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_fr_FR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_ja_JP.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_pt_BR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_zh_CN.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_de_DE.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es_ES.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr_FR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja_JP.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_de_DE.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_es_ES.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_fr_FR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ja_JP.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_pt_BR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_zh_CN.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_de_DE.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_es_ES.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_fr_FR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ja_JP.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_pt_BR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_zh_CN.properties
M packaging/branding/ovirt.brand/messages_zh_CN.properties
71 files changed, 848 insertions(+), 442 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49020
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id62bc7bc83cd30f8ae77672985c7b3c728cb5cb4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: webadmin: edit pool dialog was not always filled properly
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: edit pool dialog was not always filled properly
......................................................................
webadmin: edit pool dialog was not always filled properly
The HW part should be filled by InstanceTypeManager and the SW part by behavior
classes. In the current implementation the instance type manager was bypassed
in some cases and only used as a signal when to pass the control back to it.
Fixed by moving the HW related logic to Instance TypeManager where it belongs
to and let the SW part in the behavior.
Change-Id: I0866a3d23ba946c5a9f497b03a9b4537aea750ee
Bug-Url: https://bugzilla.redhat.com/1282853
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingPoolInstanceTypeManager.java
2 files changed, 33 insertions(+), 26 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0866a3d23ba946c5a9f497b03a9b4537aea750ee
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: core: when switching macPool assigned to DC, MACs has to be ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: when switching macPool assigned to DC, MACs has to be moved between pools.
......................................................................
core: when switching macPool assigned to DC, MACs has to be moved between pools.
When new mac pool is different from old mac pool, all mac addresses of
NICs belonging to this DC has to be released from old mac pool and
added to new one.
Change-Id: I1a14c49c3af8e7a4268b40f52bba9767c05120cf
Bug-Url: https://bugzilla.redhat.com/1269846
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDc.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
2 files changed, 64 insertions(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a14c49c3af8e7a4268b40f52bba9767c05120cf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: core, restapi: fixed potential NPE and removed duplicity
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core,restapi: fixed potential NPE and removed duplicity
......................................................................
core,restapi: fixed potential NPE and removed duplicity
Change-Id: Ia913e0f2069fa63b07be3f640600c1867406eda7
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, but someone else must approve
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48506
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia913e0f2069fa63b07be3f640600c1867406eda7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137
......................................................................
core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137
patch 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 was entirelly wrong.
One must not consult macPool there, since interface here already has
MAC address obtained from pool, so check here always failed.
It probably cannot be reverted nicely, since there were other patches
fixing some of problems this patch introduced.
note: bug
https://bugzilla.redhat.com/show_bug.cgi?id=1212461
related to patch being reverted, was reverified as well and I did not reproduce it.
Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf
Bug-Url: https://bugzilla.redhat.com/1270583
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 6 insertions(+), 31 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: frontend: remove HostPredicate and use IdPredicate instead
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: remove HostPredicate and use IdPredicate instead
......................................................................
frontend: remove HostPredicate and use IdPredicate instead
This patch removes duplicate code implemented in HostPredicate and uses
IdPredicate instead.
Change-Id: Ib2fce1d2744e6e7cc3a6e6bde8eb644065ffcebe
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
3 files changed, 2 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/48652
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2fce1d2744e6e7cc3a6e6bde8eb644065ffcebe
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: frontend: remove ClusterPredicate and use IdPredicate instead
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: remove ClusterPredicate and use IdPredicate instead
......................................................................
frontend: remove ClusterPredicate and use IdPredicate instead
This patch removes duplicate code implemented in ClusterPredicate and
uses IdPredicate instead.
Change-Id: Ic9c3102d644d402cf0e2136214a4eec9184b300e
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
6 files changed, 5 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/48651
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9c3102d644d402cf0e2136214a4eec9184b300e
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month