Change in ovirt-engine[ovirt-engine-3.6]: core: MoveOrCopyDisk - the created disk should be locked
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveOrCopyDisk - the created disk should be locked
......................................................................
core: MoveOrCopyDisk - the created disk should be locked
MoveOrCopyDiskCommand creates a new disk when a disk which isn't a
template disk is being copied.
The created disk isn't LOCKED, which allows to attempt to perform
operations using the disk while the copy wasn't finished yet.
This patch makes sure that the disk is added as LOCKED.
Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282694
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82774a686fb5443e0402b1894c0e5fb2c8820cec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: MoveOrCopyDiskCommand - do not pass same parameters in...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveOrCopyDiskCommand - do not pass same parameters instance
......................................................................
core: MoveOrCopyDiskCommand - do not pass same parameters instance
The parameters instance of each command contains information that is
unique to the command (for example - the command id). In
MoveOrCopyDiskCommand the parameters of the command are passed to to
child command which is problematic - the infra doesn't support that and
it causes the endAction() of the wrong command to be executed, for
entities to stay locked and so on.
This patch solves that by adding a copy constructor to the parameters
class hirerchy excluding the base parameters class that contains command
specific information. That is the taken approach to minimize the risk of
influecing one of the command usages as we'll backport this change.
Later on we can remove the copy constructor and just create the child
parameters manually without relying on the fact that they are of the
same type of the parent command.
Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1282693
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java
6 files changed, 80 insertions(+), 29 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b127231c8fb8a416d1861c2a6395fd2c0966c6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: support domains maintenance on more hosts statuses
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: support domains maintenance on more hosts statuses
......................................................................
core: support domains maintenance on more hosts statuses
When a domain is being deactivated its status is changed to
PreparingForMaintenance. When it's confirmed that no host in the DC access it
(according to the host domain monitoring report) its status is changed
to Maintenance.
The domain monitoring results of hosts in status other then Up status aren't
being analyzed, therfore when there is a host in that status deactivated
domains will remain in "Preparing for maintenance".
An example for a relevant status is NonOperational, As host can be in Non operational
due to various reasons, the domain monitoring results of such hosts should
be anazlyzed as well when inspecting if a domain can be moved to maintenance status
because if the domain isn't accessed it can move safely to
"maintenance".
As part of this change when a domain is deactivated the pool information is
refreshed on hosts in the relevant statuses in dc that uses the memory
backend (to not extend of risk on long connectStoragePool for non
operational hosts as the metadata is stored on the storage). While in DC
that stores the metadata on storage the metadata refresh will occur by
the host recovery mechanism.
The domain monitoring report of those hosts is then inspected as well to allow the
domain to move to maintenance. In this patch I've added only the NonOperational
status as one as the inspected statuses - if it'll be needed we can add
other statuses as well.
Change-Id: I767106d429f0d8b4bd24b0f539b9a91204be18e9
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java
6 files changed, 63 insertions(+), 33 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I767106d429f0d8b4bd24b0f539b9a91204be18e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: decide whether to process domain monitoring in IrsProx...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: decide whether to process domain monitoring in IrsProxyData
......................................................................
core: decide whether to process domain monitoring in IrsProxyData
Currently the decision on whether it's needed to process the recevied
monitoring data is done in IrsBrokerCommand, as this method is supposed
to be used only as a proxy to the actual processing method - it makes
more sense to have the logic on when we should consider the report that,
otherwise each caller will need to copy that logic.
Change-Id: I2c87698477d6fbb7023b3e7f39eac4af62e91f64
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
2 files changed, 20 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c87698477d6fbb7023b3e7f39eac4af62e91f64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: moving reportingVdsStatus constant from IrsBrokerCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: moving reportingVdsStatus constant from IrsBrokerCommand
......................................................................
core: moving reportingVdsStatus constant from IrsBrokerCommand
This patch moves the reportingVdsStatus constant to
StoragePoolDomainHelper and changes it to be a Set.
Change-Id: Ib369139ba0ae6953fb22d9bf35f640cff93ef858
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib369139ba0ae6953fb22d9bf35f640cff93ef858
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: VdsDao - adding getAllForStoragePoolAndStatuses()
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: VdsDao - adding getAllForStoragePoolAndStatuses()
......................................................................
core: VdsDao - adding getAllForStoragePoolAndStatuses()
This patch adds getAllForStoragePoolAndStatuses() to VdsDAO to provide
abillity to get hosts in different statuses in one db call instead of
calling getAllForStoragePoolAndStatus() multiple times and/or perform
filtering on the calling side.
Change-Id: I5984d5e683b8ae18268248cedb22c1ea66987037
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IdentifiableUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/vds_sp.sql
6 files changed, 69 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5984d5e683b8ae18268248cedb22c1ea66987037
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: core: Added ability to change AREM interval to engine-config
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Added ability to change AREM interval to engine-config
......................................................................
core: Added ability to change AREM interval to engine-config
Affinity Rules Enforcement Manager interval for checking affinity
enforcement can now be changed using engine-config.
Change-Id: Idffef8931d8c9509f313b0ad10d3d7916d3bb5cb
Bug-Url: https://bugzilla.redhat.com/1270780
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, but someone else must approve
Roman Mohr: Looks good to me, but someone else must approve
Tomer Saban: Verified
Roy Golan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idffef8931d8c9509f313b0ad10d3d7916d3bb5cb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[master]: webadmin: passthrough vnic profile qos should be removed
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: passthrough vnic profile qos should be removed
......................................................................
webadmin: passthrough vnic profile qos should be removed
Change-Id: I8c2a6e1c93193357bb8adc0a88286580661fb7cd
Bug-Url: https://bugzilla.redhat.com/1258208
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c2a6e1c93193357bb8adc0a88286580661fb7cd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: IrsProxyData.updateVdsDomainsData() - separation to me...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: IrsProxyData.updateVdsDomainsData() - separation to methods
......................................................................
core: IrsProxyData.updateVdsDomainsData() - separation to methods
This patch separates the logic contained in updateVdsDomainsData() into
different methods for simplification and easier maintenance.
Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 111 insertions(+), 82 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: more accurate audit log when domain is deactivated
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: more accurate audit log when domain is deactivated
......................................................................
core: more accurate audit log when domain is deactivated
when a Storage Domain is being deactivated it first moves to "Preparing for
maintenance" status and only when it's confirmed that its not accessed
(by monitoring) from any host it moves to Maintenance status.
However, currently when it moves to "Preparing for maintenance" the
audit log indicates that the domain was deactivated and when it actually
moves to Maintenance there's no audit log at all.
This patch fixes the current audit log and adds a new one for the time
the domain status is changed to Maintenance.
Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc
Bug-Url: https://bugzilla.redhat.com/1247957
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
4 files changed, 26 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/48920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 1 month