November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: adding key-value format validation to HostSetupNet...
by alkaplan＠redhat.com 19 Nov '15

19 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding key-value format validation to HostSetupNetwork ...................................................................... webadmin: adding key-value format validation to HostSetupNetwork adding key-value format validation to Bonding mode custom Change-Id: Iad7107e10a6bb29fd0982b330a3e061efbcae2b8 Bug-Url: https://bugzilla.redhat.com/1167812 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad7107e10a6bb29fd0982b330a3e061efbcae2b8 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Introduce KeyValueFormatValidation
by alkaplan＠redhat.com 19 Nov '15

19 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce KeyValueFormatValidation ...................................................................... engine: Introduce KeyValueFormatValidation validation for <key>=<value> spaced separated format. Please note that extra space is needed in the message ( < key >=< value >) as the message is being translating to html. The value between the <> is not being shown. The usage of &lt &gt was avoided in order to make the language translation easier. Bug-Url: https://bugzilla.redhat.com/1167812 Change-Id: I78ae0322d49356ba0ef9e0e496a232348a715eef Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidation.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 4 files changed, 201 insertions(+), 0 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78ae0322d49356ba0ef9e0e496a232348a715eef Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: sercon: pass console specParams on device copy
by ahadas＠redhat.com 19 Nov '15

19 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: sercon: pass console specParams on device copy ...................................................................... sercon: pass console specParams on device copy When we copy the devices of a VM, we forget to carry around the console device specParams. This aptch fixes that. Change-Id: I5941c45c2bed850da4c543c5ab385c33fd5e6f44 Bug-Url: https://bugzilla.redhat.com/1280370 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5941c45c2bed850da4c543c5ab385c33fd5e6f44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packagers: minidnf: do not remove leftovers
by Alon Bar-Lev 19 Nov '15

19 Nov '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: minidnf: do not remove leftovers ...................................................................... packagers: minidnf: do not remove leftovers This avoids DNF to try to remove packages not touched by its own transaction automatically when doing a rollback. Bug-Url: https://bugzilla.redhat.com/1283267 Change-Id: I379cf27404a64a7a4aec281c40339d7071ae5b19 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M ChangeLog M src/otopi/minidnf.py 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/48734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I379cf27404a64a7a4aec281c40339d7071ae5b19 Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: removing reboot_after_installation
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: removing reboot_after_installation ...................................................................... packaging: setup: removing reboot_after_installation Removing reboot_after_installation cause is not availalbe anymore on engine_api.hosts.add Change-Id: I7ac8b11045dfb9124cd0a7c62ec38a7fa12b16eb Bug-Url: https://bugzilla.redhat.com/1259266 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ac8b11045dfb9124cd0a7c62ec38a7fa12b16eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: on cleanup connecting to docker only if we...
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: on cleanup connecting to docker only if we deployed ...................................................................... packaging: setup: on cleanup connecting to docker only if we deployed on engine-cleanup, enable the docker containers remove plugin only if in the setup phase we deployed at least one container. Bug-Url: https://bugzilla.redhat.com/1282880 Change-Id: I691c5d5459b559e23e4385c72d117c257377790d Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691c5d5459b559e23e4385c72d117c257377790d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Revert "build: post ovirt-engine-3.6.1 branching"
by tnisan＠redhat.com 19 Nov '15

19 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: Revert "build: post ovirt-engine-3.6.1 branching" ...................................................................... Revert "build: post ovirt-engine-3.6.1 branching" This reverts commit 828a04cd3e9059d0304cfea1d9b3b07227f8e0dd. See: http://lists.ovirt.org/pipermail/devel/2015-November/011689.html Change-Id: I6d49fb5821c5e1dbdcf39651bd0426d9a156d3d8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 55 files changed, 55 insertions(+), 55 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d49fb5821c5e1dbdcf39651bd0426d9a156d3d8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Test loadStorageDomainIdsForOvfIds
by amureini＠redhat.com 19 Nov '15

19 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Test loadStorageDomainIdsForOvfIds ...................................................................... core: Test loadStorageDomainIdsForOvfIds Added missing verifications so that StorageDomainOvfInfoDaoTest#loadStorageDomainIdsForOvfIds actually tests StorageDomainOvfInfoDao#loadStorageDomainIdsForOvfIds that it's supposed to. Change-Id: I03d77b80db9d932eb2c1f7564c85bf2d429a52c1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoDaoTest.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/48788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d77b80db9d932eb2c1f7564c85bf2d429a52c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: add_host: SDK call update
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: add_host: SDK call update ...................................................................... add_host: SDK call update The SDK has been updated and HE plugin must be updated as well. See also: https://gerrit.ovirt.org/#/c/43470/ Change-Id: I008c7d7b87b358c55e0e85f81f9f55954246674c Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified; Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I008c7d7b87b358c55e0e85f81f9f55954246674c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: engine: Set management network in upgrade
by tnisan＠redhat.com 19 Nov '15

19 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set management network in upgrade ...................................................................... engine: Set management network in upgrade Set management network in upgrade (take 2). The patch re-dones upgrade script 03_06_0840 as the related configuration key was renamed in the pre-upgrade phase. Change-Id: I8c68c2bfe758beacb41a74912dacc2080cb621a6 Bug-Url: https://bugzilla.redhat.com/1279955 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1920_set_mgmt_network_in_network_cluster.sql 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/48778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c68c2bfe758beacb41a74912dacc2080cb621a6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0