Change in ovirt-hosted-engine-ha[master]: sharedstorageconf: avoid upgrading local conf file is not valid
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: sharedstorageconf: avoid upgrading local conf file is not valid
......................................................................
sharedstorageconf: avoid upgrading local conf file is not valid
Avoid upgrading local conf file if no data got read from
the shared storage.
Change-Id: Ia9d181b8f68f0156866074b12803db6c982b80ba
Bug-Url: https://bugzilla.redhat.com/1276740
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/env/config.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47908
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9d181b8f68f0156866074b12803db6c982b80ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: engine: [rest-api] fix indentation for KSM in Cluster mapper
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: engine: [rest-api] fix indentation for KSM in Cluster mapper
......................................................................
engine: [rest-api] fix indentation for KSM in Cluster mapper
Fix code formatting, following request from Juan Hernandez on patch set
1
Change-Id: Ie1ca6cee6d8c6cc2cc57e0dd14231560dc382be0
Bug-Url: https://bugzilla.redhat.com/840114
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Dudi Maroshi: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1ca6cee6d8c6cc2cc57e0dd14231560dc382be0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-hosted-engine-ha[master]: upgrade: reimplementing getImagesList cause vdsm one is broken
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: reimplementing getImagesList cause vdsm one is broken
......................................................................
upgrade: reimplementing getImagesList cause vdsm one is broken
VDSM getImagesList raises an 'list index out of range' exception
if called on a storage domain witch is not connected to any SP.
Change-Id: I3b014029e9a820ea6bbb038786502778e00ea679
Bug-Url: https://bugzilla.redhat.com/1276650
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/heconflib.py
M ovirt_hosted_engine_ha/lib/upgrade.py
2 files changed, 31 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b014029e9a820ea6bbb038786502778e00ea679
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: engine: Introduce NumberRangeValidation
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Introduce NumberRangeValidation
......................................................................
engine: Introduce NumberRangeValidation
A generic abstract class for validating a given
number is in range of given minimum and maximum
values
Change-Id: I10bfd8df8d65a8d3ae436f508a63b77e777941b2
Bug-Url: https://bugzilla.redhat.com/1270563
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NumberRangeValidation.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/NumberRangeValidationTestUtils.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
3 files changed, 205 insertions(+), 0 deletions(-)
Approvals:
Eliraz Levi: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10bfd8df8d65a8d3ae436f508a63b77e777941b2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine-sdk[master]: sdk: Make sure that automation fails when RPM build fails
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Make sure that automation fails when RPM build fails
......................................................................
sdk: Make sure that automation fails when RPM build fails
This patch changes the automation scripts so that they will fail when
the RPM build fails.
Change-Id: I5f42c78a11e2df722ebbf721361d52ef05f78de3
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M automation/build-artifacts.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me
Juan Hernandez: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47951
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f42c78a11e2df722ebbf721361d52ef05f78de3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: enhance log message in case of empty reason
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: enhance log message in case of empty reason
......................................................................
core: enhance log message in case of empty reason
Up to now when we got an empty reason on command failure we just append
a "Not Specified" string to the original log message.
This message was changed to a more friendly format :
"No specific reason was returned for this operation failure, please
investigate logs for details."
Change-Id: I4f7eee36df6a158e7c9ac4d2f93f06144f25bf8c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203741
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit https://gerrit.ovirt.org/47938
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f7eee36df6a158e7c9ac4d2f93f06144f25bf8c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: fixing vNIC notation inconsistency
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fixing vNIC notation inconsistency
......................................................................
webadmin: fixing vNIC notation inconsistency
Change-Id: I7bf2d731d9ce2e85cd87964567804e4ec3e0c0af
Bug-Url: https://bugzilla.redhat.com/1160133
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
3 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Eliraz Levi: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bf2d731d9ce2e85cd87964567804e4ec3e0c0af
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: Introduce isEqual and hashCode methods of Validati...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Introduce isEqual and hashCode methods of ValidationResult
......................................................................
webadmin: Introduce isEqual and hashCode methods
of ValidationResult
Adding isEqual for testing purposes. Will enable
to compare both success indicator and reasons.
Change-Id: I3d01e92813664d96a347e06bc7e3148cbe0ad2db
Bug-Url: https://bugzilla.redhat.com/1270563
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ValidationResult.java
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Eliraz Levi: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d01e92813664d96a347e06bc7e3148cbe0ad2db
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-guest-agent[master]: packaging: windows spec: Remove 'artifacts' from paths
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: packaging: windows spec: Remove 'artifacts' from paths
......................................................................
packaging: windows spec: Remove 'artifacts' from paths
Change all /usr/share/artifacts to /usr/share.
See:
https://gerrit.ovirt.org/47771 - spice-nsis aka ovirt-wgt
https://gerrit.ovirt.org/47460 - ovirt-wgt-toolchain
https://gerrit.ovirt.org/47461 - ovirt-guest-agent
Change-Id: Ia95c93d7399758fe4ae6bbf22219065b7a58c4ae
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-guest-agent-windows.spec
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/47461
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia95c93d7399758fe4ae6bbf22219065b7a58c4ae
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: Fix migration policy update for running VM
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: Fix migration policy update for running VM
......................................................................
webadmin: Fix migration policy update for running VM
Problem description:
--------------------
When a VM is running and its migration policy is pinned.
Change the migration policy to migrateable allows the running VM
to migrate to another host.
This behavior is a security threat, passing information from the pinned
host to the migration target. And migration could fail due to
incompatible target host.
Desired behavior:
-----------------
When a VM is running and changing migration policy from pinned to
Migrateable (manual or automatic).
- Provide warning and UX indicator.
- If user confirms proceed with normal update.
Implementation:
--------------
1. Replace @EditableOnVmStatusField with @EditableField to
fields {dedicatedVmForVdsList, migrationSupport} (VmBase.java). Disable
(vm restart requirement), when updating dedicated hosts field or
updating migrationSupport field.
2. Redesign VmNextRunConfiguration UI to display warnning if running VM
is unpinned. Modify VmListModel.java to append warning into
VmNextRunConfigurationModel.java . Also Modify VmNextRunConfiguration
layout and widget to display selective information (coresponding to
updated fields).
Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b
Bug-Url: https://bugzilla.redhat.com/1058384
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java
9 files changed, 165 insertions(+), 45 deletions(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47673
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months