Change in ovirt-engine[master]: core: Fix detection of preferred hosts for numa nodes
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Fix detection of preferred hosts for numa nodes
......................................................................
core: Fix detection of preferred hosts for numa nodes
This fixes two things:
When adding new numa nodes through the rest api or the numa support
dialog in the host context menu, the detection of the preferred hosts
failed in AddVmNumaNodesCommand#canDoAction.
When creating or updating VMs, the first time the admin switched
to "non migratable", the detection of the preferred hosts failed.
This led to the situation where the whole VM was created, except
for the numa nodes.
When updating a VM all numa nodes were deleted and could not be added
again. So the whole numa configuration disappeared.
Bug-Url: https://bugzilla.redhat.com/1248049
Bug-Url: https://bugzilla.redhat.com/1256725
Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java
2 files changed, 141 insertions(+), 1 deletion(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Rename "OpenStack*Resource" to "Openstack*Resource"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Rename "OpenStack*Resource" to "Openstack*Resource"
......................................................................
restapi: Rename "OpenStack*Resource" to "Openstack*Resource"
This is to stick to the name capitalization rules used in the RESTAPI.
Change-Id: I4ad1734f8878fe1eeaef87d80cd9562678219e47
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ApiResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImageProviderResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImageProvidersResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImageResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackImagesResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworkProviderResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworkProvidersResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworkResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackNetworksResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackSubnetResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackSubnetsResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeAuthenticationKeyResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeAuthenticationKeysResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeProviderResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeProvidersResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeTypeResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenstackVolumeTypesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProvidersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImagesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProviderResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProvidersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackSubnetResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackSubnetsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeAuthenticationKeyResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeAuthenticationKeysResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProvidersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypeResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypesResource.java
35 files changed, 128 insertions(+), 128 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ad1734f8878fe1eeaef87d80cd9562678219e47
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Use POST instead of DELETE to remove multiple bricks
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use POST instead of DELETE to remove multiple bricks
......................................................................
restapi: Use POST instead of DELETE to remove multiple bricks
The operation that removes multiple Gluster bricks was implemented using
the "DELETE" method and passing the list of bricks as the body of the
request:
DELETE /clusters/{cluster:id}/glustervolumes/{volume:id}/bricks
<bricks>
<bricks id="..."/>
<bricks id="..."/>
...
</bricks>
This is problematic because the "DELETE" method shouldn't have a body,
so it has been replaced with a new "remove" action that uses the "POST"
method:
POST /clusters/{cluster:id}/glustervolumes/{volume:id}/bricks/remove
<bricks>
<bricks id="..."/>
<bricks id="..."/>
...
</bricks>
Change-Id: I6743e19222142e2fb699265c8ba400e2935bae3a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java
7 files changed, 46 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6743e19222142e2fb699265c8ba400e2935bae3a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Rename "SSHPublicKeyResource" to "SshPublicKeyResou...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Rename "SSHPublicKeyResource" to "SshPublicKeyResource"
......................................................................
restapi: Rename "SSHPublicKeyResource" to "SshPublicKeyResource"
This is to stick to the name capitalization rules used in the RESTAPI.
Change-Id: I991adf1c5ff6c4ca97bfbdf6b5b004b1d2e27067
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SshPublicKeyResource.java
R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/SshPublicKeysResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/aaa/UserResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeyResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendSSHPublicKeysResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java
6 files changed, 12 insertions(+), 13 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47897
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I991adf1c5ff6c4ca97bfbdf6b5b004b1d2e27067
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Rename "cloneVm" to "clone"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Rename "cloneVm" to "clone"
......................................................................
restapi: Rename "cloneVm" to "clone"
This is to stick to the rule that says that the names of the methods of
the JAX-RS interfaces are equal to the names of the actions, except
where the result is a Java reserved word.
Change-Id: Ie4ead6cad1a8d114e0f3d3a8c24bca536cc8ab4c
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4ead6cad1a8d114e0f3d3a8c24bca536cc8ab4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Use matrix parameter to force remove virtual machine
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use matrix parameter to force remove virtual machine
......................................................................
restapi: Use matrix parameter to force remove virtual machine
The operation that removes a virtual machine supports a "force"
parameter. In order to use it the "DELETE" method used to support an
optional action parameter:
DELETE /vms/{vm:id}
<action>
<force>true</force>
</action>
This patch replaces the action parameter with an optional matrix
parameter:
DELETE /vms/{vm:id};force=true
Change-Id: I0a3c1e189d23e9171179135a3f3552380d9cfb34
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
5 files changed, 64 insertions(+), 46 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a3c1e189d23e9171179135a3f3552380d9cfb34
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Use "detach_only" matrix parameter to detach VM disk
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use "detach_only" matrix parameter to detach VM disk
......................................................................
restapi: Use "detach_only" matrix parameter to detach VM disk
The operation that removes a virtual machine disk supports a "detach"
parameter. In order to use it the "DELETE" method supports an optional
action parameter:
DELETE /vms/{vm:id}/disks/{disk:id}
<action>
<detach>true</detach>
</action>
This patch remplaces the optional action parameter with an optional
matrix parameter:
DELETE /vms/{vm:id}/disks/{disk:id};detach_only=true
Change-Id: Ie7f222bf2d4ba5be2d107d3f91eb0acbd5590288
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java
6 files changed, 41 insertions(+), 33 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47892
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7f222bf2d4ba5be2d107d3f91eb0acbd5590288
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Use matrix parameters to remove template disks
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use matrix parameters to remove template disks
......................................................................
restapi: Use matrix parameters to remove template disks
The operation that removes a template disk supports the "force" and
"storage_domain" parameters. In order to use it them the "DELETE" method
supports an optional action parameter:
DELETE /templates/{template:id}/disks/{disk:id}
<action>
<force>...</force>
<storage_domain id="..."/>
</action>
This patch remplaces this optional action parameter with the optional
matrix parameters "force" and "storage_domain", so the way to remove a
template disk is now the following:
DELETE /templates/{template:id}/disks/{disk:id};force=true
DELETE /templates/{template:id}/disks/{disk:id};storage_domain=123
Change-Id: I7d527dcec4c819e70eea28339b2eab47894e8db7
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java
5 files changed, 67 insertions(+), 44 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47891
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d527dcec4c819e70eea28339b2eab47894e8db7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Use matrix "host" parameter to remove storage serve...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use matrix "host" parameter to remove storage server connection
......................................................................
restapi: Use matrix "host" parameter to remove storage server connection
The operation that removes a storage server connection supports a "host"
parameter. In order to use it the "DELETE" method uses an optional
action parameter:
DELETE /storageconnections/{storageconnection:id}
<action>
<host id="...">
<name>...</name>
</host>
</action>
This patch remplaces the optional action parameter with an optional
matrix parameter:
DELETE /storageconnections/{storageconnection:id};host=myhost
Change-Id: I3bad9f6f34cea4222dc1e0425a602c0d1fe31631
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResourceTest.java
5 files changed, 93 insertions(+), 55 deletions(-)
Approvals:
Juan Hernandez: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bad9f6f34cea4222dc1e0425a602c0d1fe31631
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: enhance log message in case of empty reason
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: enhance log message in case of empty reason
......................................................................
core: enhance log message in case of empty reason
Up to now when we got an empty reason on command failure we just append
a "Not Specified" string to the original log message.
This message was changed to a more friendly format :
"No specific reason was returned for this operation failure, please
investigate logs for details."
Change-Id: I4f7eee36df6a158e7c9ac4d2f93f06144f25bf8c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1203741
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f7eee36df6a158e7c9ac4d2f93f06144f25bf8c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months