December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.1]: engine: check if pci slot is used by managed device during v...
by piotr.kliczewski＠gmail.com 04 Dec '15

04 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: check if pci slot is used by managed device during vm nic hotplug ...................................................................... engine: check if pci slot is used by managed device during vm nic hotplug Change-Id: Ic4143197d5c30fc28e58d1203a8490a614a3ca88 Bug-Url: https://bugzilla.redhat.com/1199782 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 32 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4143197d5c30fc28e58d1203a8490a614a3ca88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: engine: update setupNetworks heartbeat policy only for mgmt ...
by piotr.kliczewski＠gmail.com 04 Dec '15

04 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: update setupNetworks heartbeat policy only for mgmt networks ...................................................................... engine: update setupNetworks heartbeat policy only for mgmt networks Updating the heartbeat policy during the HostSetupNetworks command only makes sense when the connection between the engine and host is modified. This should only be the case when the management network is modified. This patch changes the rpc broker to only reset the heartbeat policy when the management network is changed in any way. Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1262051 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 10 files changed, 78 insertions(+), 16 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49ef2e8d520c5cfff769375a0d5f9428179e87d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: restapi: Fix labels/virtualfunctionallowedlabels href
by piotr.kliczewski＠gmail.com 04 Dec '15

04 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Fix labels/virtualfunctionallowedlabels href ...................................................................... restapi: Fix labels/virtualfunctionallowedlabels href Fix labels/virtualfunctionallowedlabels href Change-Id: Ied58a7b2867a52f8a087aee7aa5bf85c84cfb0c2 Bug-Url: https://bugzilla.redhat.com/1286427 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBaseHostNicLabelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBaseHostNicLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelResource.java 5 files changed, 41 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/49472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied58a7b2867a52f8a087aee7aa5bf85c84cfb0c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix labels/virtualfunctionallowedlabels href
by piotr.kliczewski＠gmail.com 04 Dec '15

04 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Fix labels/virtualfunctionallowedlabels href ...................................................................... restapi: Fix labels/virtualfunctionallowedlabels href Fix labels/virtualfunctionallowedlabels href Change-Id: Ied58a7b2867a52f8a087aee7aa5bf85c84cfb0c2 Bug-Url: https://bugzilla.redhat.com/1286427 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBaseHostNicLabelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBaseHostNicLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelResource.java 5 files changed, 41 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/49476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied58a7b2867a52f8a087aee7aa5bf85c84cfb0c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-3.6]: PEP8 fix introduced regression
by vfeenstr＠redhat.com 04 Dec '15

04 Dec '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: PEP8 fix introduced regression ...................................................................... PEP8 fix introduced regression Bug-Url: https://bugzilla.redhat.com/1285834 Change-Id: I9af99bce9b5c2558a1e87859edc08cce37704cd2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9af99bce9b5c2558a1e87859edc08cce37704cd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-3.6]: Fix osinfo for el5
by vfeenstr＠redhat.com 04 Dec '15

04 Dec '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix osinfo for el5 ...................................................................... Fix osinfo for el5 Python 2.4 does not come with linux_distributions, so we are putting in an explicit workaround for EL5 Change-Id: I8dc2efa00eac25c6854fb8f47b86e5da746502e1 Bug-Url: https://bugzilla.redhat.com/1286937 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M scripts/ovirt-osinfo 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc2efa00eac25c6854fb8f47b86e5da746502e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: Fix osinfo for el5
by vfeenstr＠redhat.com 04 Dec '15

04 Dec '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Fix osinfo for el5 ...................................................................... Fix osinfo for el5 Python 2.4 does not come with linux_distributions, so we are putting in an explicit workaround for EL5 Change-Id: I8dc2efa00eac25c6854fb8f47b86e5da746502e1 Bug-Url: https://bugzilla.redhat.com/1286937 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M scripts/ovirt-osinfo 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc2efa00eac25c6854fb8f47b86e5da746502e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: avoid adding HE iSCSI/FC lun as direct LUN
by sbonazzo＠redhat.com 03 Dec '15

03 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid adding HE iSCSI/FC lun as direct LUN ...................................................................... packaging: setup: avoid adding HE iSCSI/FC lun as direct LUN In the past we were adding HE iSCSI/FC LUNs as direct LUN to prevent any weird behviour trying to manually import it into the engine. After https://gerrit.ovirt.org/#/c/46515/ it's not needed anymore. Change-Id: Ic36aba660c218df723338bd552e3d269ab94d7db Depends-On: https://gerrit.ovirt.org/#/c/46515/ Bug-Url: https://bugzilla.redhat.com/1273378 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/Makefile.am M src/plugins/ovirt-hosted-engine-setup/engine/__init__.py D src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py 4 files changed, 0 insertions(+), 228 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36aba660c218df723338bd552e3d269ab94d7db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: config: increase heartbeat interval
by masayag＠redhat.com 03 Dec '15

03 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: config: increase heartbeat interval ...................................................................... config: increase heartbeat interval We see communication issues due to "heartbeat exceeded" exception. In order to mitigate those situation we increase heartbeat interval from 10 to 30 seconds. Change-Id: I68b9627ab49f607c746e841476e60aaf127d0ed1 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68b9627ab49f607c746e841476e60aaf127d0ed1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update cluster upgrade warning message
by masayag＠redhat.com 03 Dec '15

03 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: core: update cluster upgrade warning message ...................................................................... core: update cluster upgrade warning message We want to make a message, which is displayed when there are still hosts using unsupported protocol and we upgrade it to 3.6, more descriptive. Change-Id: I55f5f0882a7be2cceed7f211a270f3f6d186eee1 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1286452 --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f5f0882a7be2cceed7f211a270f3f6d186eee1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0