December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Update executionContext with Steps.
by masayag＠redhat.com 03 Dec '15

03 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Update executionContext with Steps. ...................................................................... core: Update executionContext with Steps. When executing a command through the CommandExecutor as part of an execution flow, the steps in the executionContext should be initialized as well. At this particular bug a stateless VM is being powering up and a step indicating the snapshot is being created is initialized in the context and should be passed to the child command CreateCinderSnapshotCommand. The proposed fix adds the initialization for steps and jobs to the executionContext when calling createDefaultContextForTasksImpl Change-Id: I4ee874e3da01504115e1fa2fd2e66de51d441a9d Bug-Url: https://bugzilla.redhat.com/1270725 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Maor Lipchuk: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ee874e3da01504115e1fa2fd2e66de51d441a9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: issue upgrading cluster to 3.5
by oourfali＠redhat.com 03 Dec '15

03 Dec '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: issue upgrading cluster to 3.5 ...................................................................... core: issue upgrading cluster to 3.5 When upgrading a cluster from 3.4 to 3.5 you fail on hosts that work with xmlrpc. The condition there is wrong. This is the proper condition. Change-Id: I0fa7e6ff8b4a53dcbb9e6e0957f42cd455aa7a98 Bug-Url: https://bugzilla.redhat.com/1287136 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa7e6ff8b4a53dcbb9e6e0957f42cd455aa7a98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: issue upgrading cluster to 3.5
by oourfali＠redhat.com 03 Dec '15

03 Dec '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: issue upgrading cluster to 3.5 ...................................................................... core: issue upgrading cluster to 3.5 When upgrading a cluster from 3.4 to 3.5 you fail on hosts that work with xmlrpc. The condition there is wrong. This is the proper condition. Change-Id: I0fa7e6ff8b4a53dcbb9e6e0957f42cd455aa7a98 Bug-Url: https://bugzilla.redhat.com/1287136 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa7e6ff8b4a53dcbb9e6e0957f42cd455aa7a98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: issue upgrading cluster to 3.5
by oourfali＠redhat.com 03 Dec '15

03 Dec '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: issue upgrading cluster to 3.5 ...................................................................... core: issue upgrading cluster to 3.5 When upgrading a cluster from 3.4 to 3.5 you fail on hosts that work with xmlrpc. The condition there is wrong. This is the proper condition. Change-Id: I0fa7e6ff8b4a53dcbb9e6e0957f42cd455aa7a98 Bug-Url: https://bugzilla.redhat.com/1287136 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa7e6ff8b4a53dcbb9e6e0957f42cd455aa7a98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Opteron G2 and newer allowed for Windows 10 guest OS
by tnisan＠redhat.com 03 Dec '15

03 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Opteron G2 and newer allowed for Windows 10 guest OS ...................................................................... core: Opteron G2 and newer allowed for Windows 10 guest OS KVM QE found following combinations as working: * Host OS: RHEL6.7-z * Machine type: rhel6.5.0/rhel6.6.0 * Guest OS: Win10 (both 32 and 64 bit) * CPU: Opteron G2, G3, G4, G5 Thus we decided to enable these CPUs with guest OS Windows 10 and machine type 7.2. Change-Id: I87f7db295a5a0a12870b8ce1925bc08999d09419 Bug-Url: https://bugzilla.redhat.com/1288090 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87f7db295a5a0a12870b8ce1925bc08999d09419 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "packaging: setup: Require latest otopi"
by sbonazzo＠redhat.com 03 Dec '15

03 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "packaging: setup: Require latest otopi" ...................................................................... Revert "packaging: setup: Require latest otopi" This reverts commit 1750731f84a91b29c73f64acef631d0e60579128 aka Change-Id Icf2a5c3af3845527b75c2b0a4cdd42d5bd89f4a3. otopi is best handled as a dependency of the engine-setup packages, no need to require its latest version. Change-Id: I6f650b11185cc53c33401214fadd2991a3b39fe4 Related-To: https://bugzilla.redhat.com/1286558 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- D packaging/setup/plugins/ovirt-engine-setup/base/distro-rpm/__init__.py D packaging/setup/plugins/ovirt-engine-setup/base/distro-rpm/packages.py 2 files changed, 0 insertions(+), 90 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f650b11185cc53c33401214fadd2991a3b39fe4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OvfReaders LinqUtils
by amureini＠redhat.com 03 Dec '15

03 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReaders LinqUtils ...................................................................... core: OvfReaders LinqUtils Replace usages of LinqUtils with Java 8's standard streaming API in order to standardize the code and make it easier to read. Change-Id: Ic74ea3c81e635d78ad361e8a0e096b9efa2b5414 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 4 insertions(+), 30 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic74ea3c81e635d78ad361e8a0e096b9efa2b5414 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: error message improvement for detach network
by alkaplan＠redhat.com 03 Dec '15

03 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: error message improvement for detach network ...................................................................... engine: error message improvement for detach network improving error message when detaching network being used by vms. the new error message will distinct between single to plural cases. Change-Id: I25989f6f53ac292b63ab54f75587339249c22d44 Bug-Url: https://bugzilla.redhat.com/1216896 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 8 insertions(+), 71 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25989f6f53ac292b63ab54f75587339249c22d44 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor DetachNetworkUsedByVmValidator error messages
by alkaplan＠redhat.com 03 Dec '15

03 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Refactor DetachNetworkUsedByVmValidator error messages ...................................................................... engine: Refactor DetachNetworkUsedByVmValidator error messages Creating new error messages and marking the old one as deprecated Bug-Url: https://bugzilla.redhat.com/1216896 Change-Id: I8799286e1fd01267aa0be358e49e45fb6646c4b2 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 21 insertions(+), 13 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8799286e1fd01267aa0be358e49e45fb6646c4b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: unable to remove QoS from network during update
by juan.hernandez＠redhat.com 03 Dec '15

03 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: unable to remove QoS from network during update ...................................................................... restapi: unable to remove QoS from network during update Change-Id: Iba78dc33ea3fb4daa2a5d4ab15e09f8d43c46642 Bug-Url: https://bugzilla.redhat.com/1278297 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Martin Mucha: Verified -- To view, visit https://gerrit.ovirt.org/48475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba78dc33ea3fb4daa2a5d4ab15e09f8d43c46642 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0