December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.2]: core: Disallow disk edit when it's in locked status
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Disallow disk edit when it's in locked status ...................................................................... core: Disallow disk edit when it's in locked status Change-Id: Iefa02a875abcd8e1c460b3554eece6b4d953f443 Bug-Url: https://bugzilla.redhat.com/1292509 Bug-Url: https://bugzilla.redhat.com/1289538 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 25 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa02a875abcd8e1c460b3554eece6b4d953f443 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: webadmin: Fix exception in edit storage model
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix exception in edit storage model ...................................................................... webadmin: Fix exception in edit storage model Change-Id: Ifba49c7fcc1367f78767d617a0b680fed88aab01 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294087 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifba49c7fcc1367f78767d617a0b680fed88aab01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: webadmin: Handle storage domain types version checks correctly
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Handle storage domain types version checks correctly ...................................................................... webadmin: Handle storage domain types version checks correctly The method responsible to check whether a storage type is supported in a DC version used to return boolean, in cases that there is no info on whether the type is supported (for instance when the DC is null when selecting 'none' as the DC) the unboxing of the null Boolean resulted in an NPE. This was fixed by returning Boolean from the method and comparing the result correctly. Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294089 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Handle storage domain types version checks correctly
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Handle storage domain types version checks correctly ...................................................................... webadmin: Handle storage domain types version checks correctly The method responsible to check whether a storage type is supported in a DC version used to return boolean, in cases that there is no info on whether the type is supported (for instance when the DC is null when selecting 'none' as the DC) the unboxing of the null Boolean resulted in an NPE. This was fixed by returning Boolean from the method and comparing the result correctly. Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294089 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix exception in edit storage model
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix exception in edit storage model ...................................................................... webadmin: Fix exception in edit storage model Change-Id: Ifba49c7fcc1367f78767d617a0b680fed88aab01 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294087 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifba49c7fcc1367f78767d617a0b680fed88aab01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Disallow disk edit when it's in locked status
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Disallow disk edit when it's in locked status ...................................................................... core: Disallow disk edit when it's in locked status Change-Id: Iefa02a875abcd8e1c460b3554eece6b4d953f443 Bug-Url: https://bugzilla.redhat.com/1292509 Bug-Url: https://bugzilla.redhat.com/1289538 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 25 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa02a875abcd8e1c460b3554eece6b4d953f443 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine : Importing an image from glance never finishes
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine : Importing an image from glance never finishes ...................................................................... engine : Importing an image from glance never finishes Importing an image from glance leaves the disk locked after image has been downloaded Change-Id: I43fa65de4443ad234a23ac493e9f1e49c355b71a Bug-Url: https://bugzilla.redhat.com/1293644 Bug-Url: https://bugzilla.redhat.com/1275629 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43fa65de4443ad234a23ac493e9f1e49c355b71a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine : After an command is finished tasks are not cleared ...
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine : After an command is finished tasks are not cleared and stay in executing status ...................................................................... engine : After an command is finished tasks are not cleared and stay in executing status Tasks are not being updated to FINISHED status after completion execution. Change-Id: I37bf0926432b4ea592c47ec9e61c093d7ecbd55f Bug-Url: https://bugzilla.redhat.com/1293644 Bug-Url: https://bugzilla.redhat.com/1273447 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37bf0926432b4ea592c47ec9e61c093d7ecbd55f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine : Can't remove vm template - the disks are removed an...
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine : Can't remove vm template - the disks are removed and the template stays locked ...................................................................... engine : Can't remove vm template - the disks are removed and the template stays locked The patch Ib3261800f383a6e3973acab4bd1 caused regression in commands that ran Async Tasks. This patch reverts the changes in CommandBase related to AsyncTasks and implements a simpler solution using existing shouldBeEndedByParent flag in VdcActionParametersBase. Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667 Bug-Url: https://bugzilla.redhat.com/1293644 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 2 files changed, 16 insertions(+), 81 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine : Fix scenario where CoCo child executes Async Tasks
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine : Fix scenario where CoCo child executes Async Tasks ...................................................................... engine : Fix scenario where CoCo child executes Async Tasks When CoCo command with callback executes a command that starts an async task the endSuccessfully of the CoCo command is being invoked as it is the parent of command that executes the async task. The CoCo command with callback should not be considered parent of the command executing async task. Change-Id: Ib3261800f383a6e3973acab4bd16079594fa4149 Bug-Url: https://bugzilla.redhat.com/1293644 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoImpl.java M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/03_06_1970_add_cmd_entity_parent_command_id.sql 13 files changed, 120 insertions(+), 114 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3261800f383a6e3973acab4bd16079594fa4149 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0