December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: avoid cast exception in VdsBrokerObjectsBuilder
by alkaplan＠redhat.com 23 Dec '15

23 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: backend: avoid cast exception in VdsBrokerObjectsBuilder ...................................................................... backend: avoid cast exception in VdsBrokerObjectsBuilder VdsBrokerObjectsBuilder.updateCommonInterfaceData can return a String or an Integer (depends on the vdsm version). This patch enables us to work with both return types. Change-Id: I4932f924288b15b11000e6e3b1d4cee83f7cf50b Bug-Url: https://bugzilla.redhat.com/1293881 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/50968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4932f924288b15b11000e6e3b1d4cee83f7cf50b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change description of hibernation disks
by ahadas＠redhat.com 23 Dec '15

23 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: core: change description of hibernation disks ...................................................................... core: change description of hibernation disks Change-Id: If5bcefb621d4bc5b41dd61ac3d9b55e6780f2cc0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/50979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5bcefb621d4bc5b41dd61ac3d9b55e6780f2cc0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: import glance image - fix size value
by derez＠redhat.com 23 Dec '15

23 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import glance image - fix size value ...................................................................... webadmin: import glance image - fix size value Import image from Glance dialog: fix to appropriate size units. Change-Id: Ibe5fdb079d72449cf92a47da7088676573d40e42 Bug-Url: https://bugzilla.redhat.com/1290349 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe5fdb079d72449cf92a47da7088676573d40e42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Commiting a partial preview of cinder snapshot.
by tnisan＠redhat.com 23 Dec '15

23 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Commiting a partial preview of cinder snapshot. ...................................................................... core: Commiting a partial preview of cinder snapshot. Critical snapshot list is list which reflects all the snapshot ids that are being used for all the volumes in the VM. Partial snapshot might contain a volume used for active snapshot. Once the snapshot gets commited the engine should avoid removing the snapshots which are being used by other volumes, indicated in the critical snapshot list Change-Id: I623ac84b1a0a869d25f0d8427ee5cd7631afda3e Bug-Url: https://bugzilla.redhat.com/1293226 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 2 files changed, 24 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I623ac84b1a0a869d25f0d8427ee5cd7631afda3e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix custom preview with one disk from active snapshot.
by tnisan＠redhat.com 23 Dec '15

23 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix custom preview with one disk from active snapshot. ...................................................................... core: Fix custom preview with one disk from active snapshot. Fix an issue when custom previewing a snapshot, so that one disk will be used from the previewed snapshot and the other one will be used from the active snapshot (The same disk that was being used before the preview) Change-Id: I57dd56a8d73ee7786c54022b6c5ecc7ee025cc75 Bug-Url: https://bugzilla.redhat.com/1293226 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57dd56a8d73ee7786c54022b6c5ecc7ee025cc75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: don't auto format sd when detaching from local dc
by derez＠redhat.com 23 Dec '15

23 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: frontend: don't auto format sd when detaching from local dc ...................................................................... frontend: don't auto format sd when detaching from local dc This patch adds the user the ability to choose whether or not to format the storage domain when detaching it from a local data center. This is done by presenting him a checkbox with the label "Format Domain, i.e. Storage Content will be lost!", like in the "Remove Storage(s)" window. Change-Id: I78526987f2b6df1e76423c2b74b0d0a5be26032e Bug-Url: https://bugzilla.redhat.com/1245249 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 13 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/50871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78526987f2b6df1e76423c2b74b0d0a5be26032e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: fixing the UPGRADE_YUM_GROUP_NAME string
by sbonazzo＠redhat.com 23 Dec '15

23 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fixing the UPGRADE_YUM_GROUP_NAME string ...................................................................... packaging: setup: fixing the UPGRADE_YUM_GROUP_NAME string Fixing the UPGRADE_YUM_GROUP_NAME string to the current release number. Upstream we are not using YUM_GROUP but it's still better to keep it aligned. Change-Id: Idf83d8abb812a78e42db49e20392907d90aac8e2 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf83d8abb812a78e42db49e20392907d90aac8e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Install/Update additional packages
by sbonazzo＠redhat.com 23 Dec '15

23 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Install/Update additional packages ...................................................................... packaging: setup: Install/Update additional packages Instead of relying on additional packages defined in the yum group ovirt-engine-X.Y, add them directly. We had in the past problems with the yum group, so it's currently not created in the repos. Bug-Url: https://bugzilla.redhat.com/1286558 Change-Id: I5e7b5885e2b600b49e2c0a97392bc6c640901033 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py 2 files changed, 23 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/49106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e7b5885e2b600b49e2c0a97392bc6c640901033 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: packaging: bump to 4.0.0
by sbonazzo＠redhat.com 23 Dec '15

23 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: bump to 4.0.0 ...................................................................... packaging: bump to 4.0.0 - drop requirement on all-in-one Change-Id: I6be2074987ccf220d027178d0626e6c1b58a67d7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-setup-plugin-live/configure.ac M ovirt-engine-setup-plugin-live/ovirt-engine-setup-plugin-live.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6be2074987ccf220d027178d0626e6c1b58a67d7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: build: after build reports for 3.6.2.1
by sradco＠redhat.com 23 Dec '15

23 Dec '15

Shirly Radco has submitted this change and it was merged. Change subject: build: after build reports for 3.6.2.1 ...................................................................... build: after build reports for 3.6.2.1 Change-Id: I092f9f9076eca3ea69206e0ef7afc80a80d82135 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I092f9f9076eca3ea69206e0ef7afc80a80d82135 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0