December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: check hotplugged nics for duplicated pci address als...
by alkaplan＠redhat.com 21 Dec '15

21 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: check hotplugged nics for duplicated pci address also when vm is not running ...................................................................... engine: check hotplugged nics for duplicated pci address also when vm is not running Hotplugged nics should be checked for duplicated pci addresses also when the vm is not running. Duplicated address could happen in the following scenario: 1. Run vm 2. Add a nic, an address will be assigned on the vm 3. Unplug nic, the address will be remembered in engine. 4. Plug another nic, the same address could be assigned. 5. Power off vm. 6. Plug first nic again 7. During vm power on, both nics will have the same address Change-Id: Ia4526cf628a726e579045e283df8bfc366e741ef Bug-Url: https://bugzilla.redhat.com/1199782 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4526cf628a726e579045e283df8bfc366e741ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: warning on attach Cinder disk with IDE
by tnisan＠redhat.com 21 Dec '15

21 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: warning on attach Cinder disk with IDE ...................................................................... webadmin: warning on attach Cinder disk with IDE Similarly to DiskImages and LunDisks, when attaching a disk with IDE interface to a running VM, an appropriate warning should be displayed. Change-Id: I24d9aa725285f932d63631ecd6ec0e8d00d16a19 Bug-Url: https://bugzilla.redhat.com/1287144 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/50768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24d9aa725285f932d63631ecd6ec0e8d00d16a19 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Delete copied disk delete source disk
by tnisan＠redhat.com 21 Dec '15

21 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Delete copied disk delete source disk ...................................................................... engine: Delete copied disk delete source disk Deleting a copied disk also deletes the source disk in the case the source disk is part of a VM snapshot. In order to prevent this issue, the new disk should nullify the VmSnapshotId and the ParentId and ImageTemplateId should be Guid.Empty. Change-Id: Icb2eccb1dec0c2326e47d44e2da79a3fdae399f6 Bug-Url: https://bugzilla.redhat.com/1292196 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb2eccb1dec0c2326e47d44e2da79a3fdae399f6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Fix memory based filtering
by rgolan＠redhat.com 21 Dec '15

21 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: Fix memory based filtering ...................................................................... Fix memory based filtering There are two memory based rules that have to be obeyed for a successful VM start. 1) QEMU can allocate the full VM memory when starting the VM process. sysctl option vm.overcommit_memory then controls whether the malloc call succeeds even though there is not enough free memory at the time. The allocation is not visible in free memory reporting, because the kernel memory pages are then assigned on demand. This does not happen always, but we can't really tell in advance and so we need to make sure the necessary memory is available for the malloc call to succeed (even though the memory won't be actually used). The pending mechanism is used, but only counts the guest overhead memory consumption for this case as it is unlikely the VM will eat more memory faster than VDSM reports it to the engine. 2) oVirt over-commitment rules limit the total amount of VM memory that can be assigned on a host. This amount does not correspond to the actual used physical memory, it represents the theoretical maximum of memory all VMs on a host can consume. The full memory is used in the pending counter for this case. We already had number two (sans a tiny change to the formula). Rule number one is a new one and it will not cause more memory or swap usage, because it only makes the rules more strict together. This patch also fixes a small bug in deserialization of memFree when retrieved as part of the full VDS entity. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1180071 Change-Id: I335324841b8df6561d6aa2203a394164d44ee9a9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsFreeMemoryChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingMemory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingOvercommitMemory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SlaValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 17 files changed, 321 insertions(+), 78 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I335324841b8df6561d6aa2203a394164d44ee9a9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused Job#getLastStep()
by amureini＠redhat.com 20 Dec '15

20 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused Job#getLastStep() ...................................................................... core: Remove unused Job#getLastStep() Change-Id: I9e02f9dbccf0398ff101f9b56d27c18257cddfd1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e02f9dbccf0398ff101f9b56d27c18257cddfd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AsyncTaskDao cleanup
by amureini＠redhat.com 20 Dec '15

20 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AsyncTaskDao cleanup ...................................................................... core: AsyncTaskDao cleanup Removed unused methods from AsyncTaskDao[Impl]. Change-Id: I6251a498a07d6f8f39cf711693de8b6f61d05fa8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDaoImpl.java M packaging/dbscripts/async_tasks_sp.sql 3 files changed, 0 insertions(+), 52 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6251a498a07d6f8f39cf711693de8b6f61d05fa8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused Tag methods and classes
by amureini＠redhat.com 20 Dec '15

20 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused Tag methods and classes ...................................................................... core: Remove unused Tag methods and classes Removed the unused methods getAllUserGroupTagsWithIds(String), getAllForVdsWithIds(String) and getVmPoolTagsByVmPoolIdAndAdElementId(Guid, Guid) from TagDao and its implementation, as well as the backing stored procedures that serve these methods. getVmPoolTagsByVmPoolIdAndAdElementId was the only place in the codebase to use TagsVmPoolMap, so it was also removed. Once that was removed, TagsVmPoolMapId also became redundant, and was removed as well. Change-Id: I120f3c6f4f89e85887593d5ff87c7f529551e257 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMap.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMapId.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDaoImpl.java M packaging/dbscripts/tags_sp.sql 5 files changed, 0 insertions(+), 165 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I120f3c6f4f89e85887593d5ff87c7f529551e257 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix potential NPE
by derez＠redhat.com 20 Dec '15

20 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE ...................................................................... webadmin: Fix potential NPE Fix potential NPE in AbstractFindStoragePopupView. Issue found by Coverity #1201886 Change-Id: I98366d79dbc90cc398b6334c5f2fbddea0ca09ca Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/AbstractFindStoragePopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98366d79dbc90cc398b6334c5f2fbddea0ca09ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Encapsulate images field
by tnisan＠redhat.com 20 Dec '15

20 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Encapsulate images field ...................................................................... engine: Encapsulate images field In RemoveAllVmImagesParameters, the field 'images' was not encapsulated Change-Id: I60463cf51dccb9561978a1a1df2b20030abae12b Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveAllVmImagesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60463cf51dccb9561978a1a1df2b20030abae12b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin - warning on attach Cinder disk with IDE
by derez＠redhat.com 20 Dec '15

20 Dec '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin - warning on attach Cinder disk with IDE ...................................................................... webadmin - warning on attach Cinder disk with IDE Similarly to DiskImages and LunDisks, when attaching a disk with IDE interface to a running VM, an appropriate warning should be displayed. Change-Id: I24d9aa725285f932d63631ecd6ec0e8d00d16a19 Bug-Url: https://bugzilla.redhat.com/1287144 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24d9aa725285f932d63631ecd6ec0e8d00d16a19 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0