Change in ovirt-engine[ovirt-engine-3.6]: userportal: NPE if the user does not have access to manageme...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: NPE if the user does not have access to management network
......................................................................
userportal: NPE if the user does not have access to management network
The code expected this situation in all cases except one - fixed by simple null
check.
Change-Id: I65f7e5bacc59b3adf68ad92ce62d89d91acf9fad
Bug-Url: https://bugzilla.redhat.com/1286984
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50667
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65f7e5bacc59b3adf68ad92ce62d89d91acf9fad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Release ovirt-hosted-engine-ha-1.3.3.5-1
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Release ovirt-hosted-engine-ha-1.3.3.5-1
......................................................................
Release ovirt-hosted-engine-ha-1.3.3.5-1
Change-Id: Ib18848606b8efe28e0903e85c6b8ee25284c356a
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, but someone else must approve; Passed CI tests
Martin Sivák: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib18848606b8efe28e0903e85c6b8ee25284c356a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: calling getStorageDomainStats also on FC
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: storage: calling getStorageDomainStats also on FC
......................................................................
storage: calling getStorageDomainStats also on FC
getStorageDomainStats has the side effect of causing
a Storage Domain refresh including all its tree
under /rhev/data-center/...
We need it also for FC!
Change-Id: I193a63be1a9de4ef70f5947931e4b631e89fc6db
Bug-Url: https://bugzilla.redhat.com/1258465
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/storage_server.py
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I193a63be1a9de4ef70f5947931e4b631e89fc6db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: fix upgrade from partially upgraded condition
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: fix upgrade from partially upgraded condition
......................................................................
upgrade: fix upgrade from partially upgraded condition
The upgrade procedure has to move the hosted-engine
configuration to the shared storage and it has to
disconnect the hosted-engine storage domain from its
bootstrap storage pool.
The two tasks can be performed by different attempts.
_move_to_shared_conf was connecting the bootstrap
storage pool leaving it connected for further steps.
_remove_storage_pool was assuming that it was
already connected.
But if the configuration volume is OK it skips
_move_to_shared_conf and, if the system has been
rebooted in the middle, _remove_storage_pool fails
cause the storage pool is not connected.
Connecting the storage pool if needed also from
_remove_storage_pool
Change-Id: Ibc5782d2f245129b2bb2f7e70f2558d820eb4267
Bug-Url: https://bugzilla.redhat.com/1292652
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 21 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc5782d2f245129b2bb2f7e70f2558d820eb4267
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Remove Sys V support and fix the systemd unit files
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Remove Sys V support and fix the systemd unit files
......................................................................
Remove Sys V support and fix the systemd unit files
Change-Id: I9ba6ecce31a9216935f3c67d8a76a99177e525f4
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M initscripts/Makefile.am
D initscripts/ovirt-ha-agent.init.in
R initscripts/ovirt-ha-agent.service.in
D initscripts/ovirt-ha-broker.init.in
D initscripts/ovirt-ha-broker.service
A initscripts/ovirt-ha-broker.service.in
M ovirt-hosted-engine-ha.spec.in
7 files changed, 19 insertions(+), 307 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ba6ecce31a9216935f3c67d8a76a99177e525f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: storage: calling getStorageDomainStats also on FC
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: storage: calling getStorageDomainStats also on FC
......................................................................
storage: calling getStorageDomainStats also on FC
getStorageDomainStats has the side effect of causing
a Storage Domain refresh including all its tree
under /rhev/data-center/...
We need it also for FC!
Change-Id: I193a63be1a9de4ef70f5947931e4b631e89fc6db
Bug-Url: https://bugzilla.redhat.com/1258465
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/storage_server.py
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50695
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I193a63be1a9de4ef70f5947931e4b631e89fc6db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: upgrade: fix upgrade from partially upgraded condition
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: fix upgrade from partially upgraded condition
......................................................................
upgrade: fix upgrade from partially upgraded condition
The upgrade procedure has to move the hosted-engine
configuration to the shared storage and it has to
disconnect the hosted-engine storage domain from its
bootstrap storage pool.
The two tasks can be performed by different attempts.
_move_to_shared_conf was connecting the bootstrap
storage pool leaving it connected for further steps.
_remove_storage_pool was assuming that it was
already connected.
But if the configuration volume is OK it skips
_move_to_shared_conf and, if the system has been
rebooted in the middle, _remove_storage_pool fails
cause the storage pool is not connected.
Connecting the storage pool if needed also from
_remove_storage_pool
Change-Id: Ibc5782d2f245129b2bb2f7e70f2558d820eb4267
Bug-Url: https://bugzilla.redhat.com/1292652
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 21 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc5782d2f245129b2bb2f7e70f2558d820eb4267
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: Remove Sys V support and fix the systemd unit files
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Remove Sys V support and fix the systemd unit files
......................................................................
Remove Sys V support and fix the systemd unit files
Change-Id: I9ba6ecce31a9216935f3c67d8a76a99177e525f4
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M initscripts/Makefile.am
D initscripts/ovirt-ha-agent.init.in
R initscripts/ovirt-ha-agent.service.in
D initscripts/ovirt-ha-broker.init.in
D initscripts/ovirt-ha-broker.service
A initscripts/ovirt-ha-broker.service.in
M ovirt-hosted-engine-ha.spec.in
7 files changed, 19 insertions(+), 307 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50711
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ba6ecce31a9216935f3c67d8a76a99177e525f4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in jenkins[master]: Using a nicer groovy summary for the html report
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Using a nicer groovy summary for the html report
......................................................................
Using a nicer groovy summary for the html report
The plugin is uglier than expected, this embeds an iframe only if the
index.html file exists
Change-Id: I645ff65f7c41b822c5dbaff9ec4c4dbb8fefb2f2
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/yaml/publishers/html-reports.yaml
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
David Caro: Verified
--
To view, visit https://gerrit.ovirt.org/50686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I645ff65f7c41b822c5dbaff9ec4c4dbb8fefb2f2
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[ovirt-live-3.6]: post oVirt Live 3.6.1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: post oVirt Live 3.6.1
......................................................................
post oVirt Live 3.6.1
Change-Id: I001682c37e39bfb8b3bf1e2fee20447560ee26ce
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/centos-7-livecd.cfg
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
3 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50725
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I001682c37e39bfb8b3bf1e2fee20447560ee26ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years