Change in ovirt-engine[ovirt-engine-3.6]: engine: Disallow setting a non-mgmt net as the host gateway
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Disallow setting a non-mgmt net as the host gateway
......................................................................
engine: Disallow setting a non-mgmt net as the host gateway
Disallow setting a non-management network as the host gateway
in case of a cluster level that doesn't support MultipleGateways
feature.
Before the patch a non-management network on a host that serves as
the management network in another cluster could be set as the
host gateway.
Change-Id: Icc8374af5d635a0c8e70116ccb8993d433ebc35e
Bug-Url: https://bugzilla.redhat.com/1290433
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
2 files changed, 29 insertions(+), 22 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/50526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc8374af5d635a0c8e70116ccb8993d433ebc35e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Release ovirt-hosted-engine-ha-1.3.3.4-1
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Release ovirt-hosted-engine-ha-1.3.3.4-1
......................................................................
Release ovirt-hosted-engine-ha-1.3.3.4-1
Change-Id: Id06b4d5a326a337053ad74353be7407cec6ddba1
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, but someone else must approve; Passed CI tests
Martin Sivák: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id06b4d5a326a337053ad74353be7407cec6ddba1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Fix notification email header corruption
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Fix notification email header corruption
......................................................................
Fix notification email header corruption
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1292060
Change-Id: I7331e0741ac6c7525aae324f866bc479893f881a
Signed-off-by: Martin Sivak <mars(a)montik.net>
(cherry picked from commit 862c5bcbc55b6f6fcedd8fb64f0ed874097704d3)
---
M ovirt_hosted_engine_ha/broker/notifications.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7331e0741ac6c7525aae324f866bc479893f881a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: webadmin: Fix text and layout for 'pending VM changes' window
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Fix text and layout for 'pending VM changes' window
......................................................................
webadmin: Fix text and layout for 'pending VM changes' window
Follow up to patch https://gerrit.ovirt.org/#/c/47673
Fix red frame insets.
Fix wording.
Change-Id: If915e5d89768f831de2243236d9ac4126ab9a155
Bug-Url: https://bugzilla.redhat.com/1058384
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48019
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If915e5d89768f831de2243236d9ac4126ab9a155
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: Fix notification email header corruption
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Fix notification email header corruption
......................................................................
Fix notification email header corruption
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1292060
Change-Id: I7331e0741ac6c7525aae324f866bc479893f881a
Signed-off-by: Martin Sivak <mars(a)montik.net>
---
M ovirt_hosted_engine_ha/broker/notifications.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7331e0741ac6c7525aae324f866bc479893f881a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: ignoring storageDomainIsMemberOfPool exception
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: ignoring storageDomainIsMemberOfPool exception
......................................................................
upgrade: ignoring storageDomainIsMemberOfPool exception
With VDSM 4.17.13, stopMonitoringDomain raises a
storageDomainIsMemberOfPool exception (code=900) if the
storage domain is already member of a storage pool.
Ignoring it and trying to continue stopping the SPM
as well.
Change-Id: I833c40add0d8a405260f0a148601d21f873b685b
Bug-Url: https://bugzilla.redhat.com/1292178
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 698f33b58b4589a4913ef8cb546da506436880da)
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50663
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I833c40add0d8a405260f0a148601d21f873b685b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: persistence: Use pythonic persistence
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: persistence: Use pythonic persistence
......................................................................
persistence: Use pythonic persistence
Previously a process was spawned to do the persistencen on Node, this failed
because sudo did not have a persist/unpersist action defined.
Now the python API is used to do the persistence.
Change-Id: Ic1fd5d335dbea6df4f99a20182e4e2bba0993b52
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291731
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M ovirt_hosted_engine_ha/lib/util.py
2 files changed, 9 insertions(+), 27 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50669
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1fd5d335dbea6df4f99a20182e4e2bba0993b52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: persistence: Use pythonic persistence
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: persistence: Use pythonic persistence
......................................................................
persistence: Use pythonic persistence
Previously a process was spawned to do the persistencen on Node, this failed
because sudo did not have a persist/unpersist action defined.
Now the python API is used to do the persistence.
Change-Id: Ic1fd5d335dbea6df4f99a20182e4e2bba0993b52
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291731
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M ovirt_hosted_engine_ha/lib/util.py
2 files changed, 9 insertions(+), 27 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50537
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1fd5d335dbea6df4f99a20182e4e2bba0993b52
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: log: increasing the log level on shared conf errors
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: log: increasing the log level on shared conf errors
......................................................................
log: increasing the log level on shared conf errors
Increasing the log level or errors occourred fetching
the configuration from the shared domain.
Change-Id: Ic11efa89d1e4208e3d265638a7ce2359b46351d3
Bug-Url: https://bugzilla.redhat.com/1287195
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit c4a444492b5357f6d2665687049adb6f16c2207b)
---
M ovirt_hosted_engine_ha/env/config.py
M ovirt_hosted_engine_ha/lib/heconflib.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic11efa89d1e4208e3d265638a7ce2359b46351d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: service: Point systemd to the pid files
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: service: Point systemd to the pid files
......................................................................
service: Point systemd to the pid files
Change-Id: I2b4514cfbfe2a29dc63133a233fc20689b91f8a0
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
(cherry picked from commit a0e11fcd49efdd5bb6d53e6c98f9a85d66db5ae0)
---
M initscripts/ovirt-ha-agent.service
M initscripts/ovirt-ha-broker.service
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50662
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b4514cfbfe2a29dc63133a233fc20689b91f8a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years