Change in ovirt-live[ovirt-live-3.6]: build: allow 3.6.1 compose
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: allow 3.6.1 compose
......................................................................
build: allow 3.6.1 compose
- 2 steps build in order to workaround a missing dep
in ovirt-engine rpms.
Change-Id: I95b8a10df8de2d8d2f8f657fce91fd2d6507c937
Signed-off-by: root <root(a)mididell.home>
---
M centos-7/Makefile
M centos-7/kickstart/centos-7-livecd.cfg
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95b8a10df8de2d8d2f8f657fce91fd2d6507c937
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: setup: sercon: validate certs connecting to engine
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: setup: sercon: validate certs connecting to engine
......................................................................
setup: sercon: validate certs connecting to engine
When communicating with engine we need to specify CA
certificate we trust.
Moreover, the host name validation should be optionally
disabled (e.g. if the server name is localhost)
This patch extends the ovirt-vmconsole-list.py helper
script accordingly.
Bug-Url: https://bugzilla.redhat.com/1264479
Change-Id: I9ce552b84bd2c3c8c6c2dce6b8541ae9dba7abf5
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/conf/ovirt-vmconsole-proxy-helper.conf.in
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
3 files changed, 116 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Sandro Bonazzola: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/48835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ce552b84bd2c3c8c6c2dce6b8541ae9dba7abf5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: fix badly generated macs in db
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: fix badly generated macs in db
......................................................................
core: fix badly generated macs in db
There was .py script (now deleted) which was used to generate mac
ranges in some circumstances. However there was a bug in it, so some
users may end up with MAC address like 00:1a:4a:1:4f:ff generated.
This MAC got without any validation into DB and engine did not detect
this problem — since engine code just removes colons and parse value
as hex. So in that case user ended up with different mac ranges than
intended. In 3.6 code validations were added to UI, where such MAC
will fail when user just opens DC edit dialog and confirm it without
any change.
description of sql udpate:
To be sure we touch only one letter parts of mac address, the
'from_mac' and 'to_mac' string are split using colon, then regex is
used to update single letter rows, then strings are concatenated
again.
Change-Id: I4a1b37da30ce4ad6d25c1d510eb5c09e17525f1b
Bug-Url: https://bugzilla.redhat.com/1286132
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0120_fix_invalid_macs.sql
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49711
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a1b37da30ce4ad6d25c1d510eb5c09e17525f1b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: upgrade: ignoring storageDomainIsMemberOfPool exception
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: ignoring storageDomainIsMemberOfPool exception
......................................................................
upgrade: ignoring storageDomainIsMemberOfPool exception
With VDSM 4.17.13, stopMonitoringDomain raises a
storageDomainIsMemberOfPool exception (code=900) if the
storage domain is already member of a storage pool.
Ignoring it and trying to continue stopping the SPM
as well.
Change-Id: I833c40add0d8a405260f0a148601d21f873b685b
Bug-Url: https://bugzilla.redhat.com/1292178
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/50654
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I833c40add0d8a405260f0a148601d21f873b685b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: service: Point systemd to the pid files
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: service: Point systemd to the pid files
......................................................................
service: Point systemd to the pid files
Change-Id: I2b4514cfbfe2a29dc63133a233fc20689b91f8a0
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M initscripts/ovirt-ha-agent.service
M initscripts/ovirt-ha-broker.service
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50623
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b4514cfbfe2a29dc63133a233fc20689b91f8a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: webadmin, userportal: Improve GWT UI build logs
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve GWT UI build logs
......................................................................
webadmin,userportal: Improve GWT UI build logs
This patch tries to make GWT UI build logs less confusing.
All changes below apply *only* to JVM running GWT compiler,
which is spawned by gwt-maven-plugin during the Maven build.
1. Use custom AspectJ load-time-weaver message handler in
aop.xml that prints logs to std-out instead of std-err.
(mvn) logs before:
[ERROR] [..] info AspectJ Weaver Version ..
[ERROR] [..] info register classloader ..
[ERROR] [..] info using configuration ..
[ERROR] [..] info register aspect ..
(mvn) logs now:
[INFO] info AspectJ Weaver Version ..
[INFO] info register classloader ..
[INFO] info using configuration ..
[INFO] info register aspect ..
2. Use custom java.util.logging configuration that
prints logs to std-out instead of std-err.
(mvn) logs before:
[ERROR] .. java.util.prefs.FileSystemPreferences..
[ERROR] INFO: Created user preferences directory.
(mvn) logs now:
[INFO] .. java.util.prefs.FileSystemPreferences..
[INFO] INFO: Created user preferences directory.
3. Added TODO in frontend aggregator module's pom.xml
about aop.xml being applied twice (not a big deal,
we can address this in future)
Change-Id: I1fed599a1190ceff6c5dc8bf6fab6f6e499bec1f
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/gwtextension/AspectJLogHandler.java
A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/gwtextension/JavaLoggingConfig.java
M frontend/webadmin/modules/gwt-extension/src/main/resources/META-INF/aop.xml
M frontend/webadmin/modules/pom.xml
6 files changed, 71 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Daniel Erez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/50545
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fed599a1190ceff6c5dc8bf6fab6f6e499bec1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: restapi: Add "--version-prefix" option to metamodel tools
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add "--version-prefix" option to metamodel tools
......................................................................
restapi: Add "--version-prefix" option to metamodel tools
This patch adds support for the "--version-prefix" option to the
metamodel tool. This option will be used in later patches to geneate
Java classes from the model with a prefix in the name. For example the
name of the class generated for the "Vm" type will be "V4Vm" in version
4 of the API and "V5Vm" in version 3 of the API. This way both classes
can be used in the server, without having to use long fully qualified
names.
Change-Id: Id1fd275cdac58c60652e0f62115a320e8cc1f2df
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JavaNames.java
A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/PlainJavaNames.java
A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/Style.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/Tool.java
A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/VersionedJavaNames.java
6 files changed, 239 insertions(+), 28 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1fd275cdac58c60652e0f62115a320e8cc1f2df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: restapi: Make "JavaClassBuffer" a member instead of component
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Make "JavaClassBuffer" a member instead of component
......................................................................
restapi: Make "JavaClassBuffer" a member instead of component
The class "JavaClassBuffer" used to generate Java code used to be a CDI
component, because it was created in one place and them used in other
places (to add "import" statements). That isn't required now because the
"JavaClassName" class contains all the required information, and can be
passed between components. This patch changes the "JavaClassBuffer" so
that it is created where needed and no longer an application scoped CDI
component.
Change-Id: Ic01813f186e670d5bc66035e1358e9614a85d618
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/EnumGenerator.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JavaClassBuffer.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JavaGenerator.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JaxrsGenerator.java
4 files changed, 11 insertions(+), 28 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic01813f186e670d5bc66035e1358e9614a85d618
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-guest-agent[master]: automation: Build for windows only if deps available
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: automation: Build for windows only if deps available
......................................................................
automation: Build for windows only if deps available
We build the depdendencies for windows only on latest fedora.
Do not check %dist but just try to get them. Exit cleanly if missing.
Change-Id: I93275a2714ae012db1725b47d6646f7e43bd8bdc
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M automation/build-artifacts.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/49146
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93275a2714ae012db1725b47d6646f7e43bd8bdc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: core: Fix of repetitive setting same custom icon
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix of repetitive setting same custom icon
......................................................................
core: Fix of repetitive setting same custom icon
Following scenario was previously failing:
- use new custom icon (e.g. edit vm)
- remove usage of custom icon (e.g. use default icon for vm)
- upload the same custom icon again (e.g. edit vm)
The cause was that icon ids in parameters were sent from frontend
(because the icon was stored in frontend cache) but the ids were not
valid (icon was removed from db in second step).
This patch fixes it by ignoring icon ids in parameters by canDoAction
validation if actual icon is uploaded.
Change-Id: I72014b20cbe85b2a792cd9e8a53b4b65c641cf59
Bug-Url: https://bugzilla.redhat.com/1267711
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
4 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Passed CI tests
Jakub Niedermertl: Verified
--
To view, visit https://gerrit.ovirt.org/50463
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72014b20cbe85b2a792cd9e8a53b4b65c641cf59
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years