Change in ovirt-engine[master]: core: preview snapshot with Cinder disks - failure flow
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: preview snapshot with Cinder disks - failure flow
......................................................................
core: preview snapshot with Cinder disks - failure flow
TryBackToAllSnapshotsOfVmCommand:
Use ConcurrentChildCommandsExecutionCallback instead of invoking
parent's endAction on TryBackToAllCinderSnapshotsCommand/
TryBackToCinderSnapshotCommand.
Change-Id: I66a998962fcf2c242b31e65d8b03402ddfad5810
Bug-Url: https://bugzilla.redhat.com/1287771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToAllCinderSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToCinderSnapshotCommand.java
3 files changed, 16 insertions(+), 27 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66a998962fcf2c242b31e65d8b03402ddfad5810
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: engine: Removed unused methods
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Removed unused methods
......................................................................
engine: Removed unused methods
Removed unused private methods.
Issues found by coverity : 1303154, 1303152, 1303153
Change-Id: I77a3fd12fd6243967647a8dee8a027b5074b07d1
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendBookmarksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClustersResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
3 files changed, 1 insertion(+), 26 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Allon Mureinik: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/50522
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77a3fd12fd6243967647a8dee8a027b5074b07d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: packaging: added shadow-utils req.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: added shadow-utils req.
......................................................................
packaging: added shadow-utils req.
Requirement for shadow-utils was added to ovirt-engine-setup-base
package, as it requires it to be installed in order to run the
post installation scripts.
Change-Id: Ie6d53bca0ae1a0dfe1af5ecfb242cb7767a2cd57
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1292009
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50574
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6d53bca0ae1a0dfe1af5ecfb242cb7767a2cd57
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Move Entities.hostInterfacesByNetworkName() to Network...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Move Entities.hostInterfacesByNetworkName() to NetworkUtils
......................................................................
core: Move Entities.hostInterfacesByNetworkName() to NetworkUtils
Moves Entities.hostInterfacesByNetworkName() to NetworkUtils and
reimplements it using streams API.
Change-Id: I79fe0ae7557fc6e65f19befc804cca2f866d99a4
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
12 files changed, 23 insertions(+), 29 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50528
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79fe0ae7557fc6e65f19befc804cca2f866d99a4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: oVirt Live 3.6.1
......................................................................
oVirt Live 3.6.1
Change-Id: I4330a58b3c68c62f44a33f80447ddd0d9ed511da
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50581
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4330a58b3c68c62f44a33f80447ddd0d9ed511da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: VM's Guest Info tab displays OS
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: VM's Guest Info tab displays OS
......................................................................
webadmin: VM's Guest Info tab displays OS
Bugfix - Guest Info tab shows Operating System info.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1285848
Change-Id: I6949929becb3007adaff9ed270fba914aed06864
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java
1 file changed, 18 insertions(+), 13 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, but someone else must approve
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/50578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6949929becb3007adaff9ed270fba914aed06864
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: detect connection details only for ISCSI
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: hosted-engine: detect connection details only for ISCSI
......................................................................
core: hosted-engine: detect connection details only for ISCSI
When importing the hosted engine storage domain there is no need to
detect the connection details for FCP, otherwise it fails with NPE. The
command to add FCP domain already detects the VG details from vdsm, we
just need the VG id.
Change-Id: Ibfb9c831cb45175b1043d254d6ecbaff4de5ff13
Bug-Url: https://bugzilla.redhat.com/1291634
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50572
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfb9c831cb45175b1043d254d6ecbaff4de5ff13
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: webadmin: VM's Guest Info tab displays OS
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: VM's Guest Info tab displays OS
......................................................................
webadmin: VM's Guest Info tab displays OS
Bugfix - Guest Info tab shows Operating System info.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1285848
Change-Id: I6949929becb3007adaff9ed270fba914aed06864
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java
1 file changed, 18 insertions(+), 13 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, but someone else must approve
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/50416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6949929becb3007adaff9ed270fba914aed06864
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Templates retrieved by name are sorted
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Templates retrieved by name are sorted
......................................................................
core: Templates retrieved by name are sorted
The GetVmTemplateByVmtName database query returns
templates in descending order by template's version number.
Change-Id: I0f4242154e2d90137e2c87ce093dcf2d2e57ab47
Bug-Url: https://bugzilla.redhat.com/1285446
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0110_add_index_on_vm_static.sql
M packaging/dbscripts/vm_templates_sp.sql
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/50464
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f4242154e2d90137e2c87ce093dcf2d2e57ab47
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: webadmin: Fix Optimize-For-Virt-Store in volume creation
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Fix Optimize-For-Virt-Store in volume creation
......................................................................
webadmin: Fix Optimize-For-Virt-Store in volume creation
Optimize-For-Virt-Store in gluster volume create is failing because
of volume ID being null in the parameter. Setting the volume ID from
return value of CreateVolume action.
Change-Id: I5a20ef51e3cc792daa2b013d0dcae8e4873c198d
Bug-Url: https://bugzilla.redhat.com/1286887
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
anmolbabu: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/50571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a20ef51e3cc792daa2b013d0dcae8e4873c198d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years