Change in ovirt-engine[master]: core: Add new parameter class for createCinderSnapshot.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add new parameter class for createCinderSnapshot.
......................................................................
core: Add new parameter class for createCinderSnapshot.
Add a paraemter class so the snapshot type can be passed as a parameter,
so it can be used for stateless snapshot
Change-Id: I03afe8bab4c5547bac4246bf5077bc91486f8d84
Bug-Url: https://bugzilla.redhat.com/1288157
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToAllCinderSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToCinderSnapshotCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCinderSnapshotParameters.java
6 files changed, 37 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/50384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03afe8bab4c5547bac4246bf5077bc91486f8d84
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Support restore of stateless snapshot
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support restore of stateless snapshot
......................................................................
core: Support restore of stateless snapshot
Longer description using lines' length under 72 chars.
With multiple paragraphs if necessary.
Change-Id: I83a31d240f454592ef534d264c0aeee356f720f3
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java
1 file changed, 17 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/50404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83a31d240f454592ef534d264c0aeee356f720f3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: remove VM with Cinder disks - failure flow
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: remove VM with Cinder disks - failure flow
......................................................................
core: remove VM with Cinder disks - failure flow
RemoveVmCommand:
Use ConcurrentChildCommandsExecutionCallback instead of invoking
parent's endAction on RemoveAllVmCinderDisksCommand.
Change-Id: I490e4fa8b08d6f7ca03329ef945d3534f7f017f7
Bug-Url: https://bugzilla.redhat.com/1287771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java
2 files changed, 16 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49995
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I490e4fa8b08d6f7ca03329ef945d3534f7f017f7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: restapi: Constraint parser
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Constraint parser
......................................................................
restapi: Constraint parser
This patch improves adds a parser for constraint expressions, so that
constraints can be added to the model using Java code in default
methods. For example the constraint that says that when adding a virtual
machine the name is mandatory can be now expressed adding a method like
this to the "Add" method of the "VmService":
interface Add {
/**
* Creates a new VM ...
*/
@In @Out Vm vm();
/**
* This defines a new constraint that says that the input
* of the `Add` operation should contain a name.
*/
@Required @In
default void nameIsMandatory() {
assert vm().name() != null;
}
}
Later patches will move the specification of constraints from the
"rsdl_metadata.yaml" file to the metamodel.
Change-Id: Iea6d2e535f89a7c166eb17e0f951bf06699ccd8e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/metamodel/analyzer/exclude-filters.xml
M backend/manager/modules/restapi/metamodel/analyzer/pom.xml
A backend/manager/modules/restapi/metamodel/analyzer/src/main/antlr4/org/ovirt/api/metamodel/analyzer/Expression.g4
A backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ConstraintAnalyzer.java
A backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ExpressionAnalyzer.java
A backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/FieldExpression.java
A backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/MethodExpression.java
M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnalyzer.java
M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnnotations.java
A backend/manager/modules/restapi/metamodel/analyzer/src/test/java/org/ovirt/api/metamodel/analyzer/ExpressionAnalyzerTest.java
A backend/manager/modules/restapi/metamodel/annotations/src/main/java/org/ovirt/api/metamodel/annotations/Allowed.java
A backend/manager/modules/restapi/metamodel/annotations/src/main/java/org/ovirt/api/metamodel/annotations/Required.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/ArrayExpression.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/AttributeExpression.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/BinaryExpression.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Constraint.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/ConstraintKind.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Expression.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/LinkExpression.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/LiteralExpression.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Method.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Operator.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/ParameterExpression.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/StructType.java
A backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/UnaryExpression.java
25 files changed, 2,292 insertions(+), 20 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49169
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea6d2e535f89a7c166eb17e0f951bf06699ccd8e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[master]: kickstart: drop all-in-one
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: kickstart: drop all-in-one
......................................................................
kickstart: drop all-in-one
all-in-one is not available anymore on master.
Dropping it.
Change-Id: Id6c5d9309e2feba172d3cb633ed14a956a5459fe
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50543
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6c5d9309e2feba172d3cb633ed14a956a5459fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[ovirt-live-3.6]: centos: drop packages not available on 7.2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: drop packages not available on 7.2
......................................................................
centos: drop packages not available on 7.2
Change-Id: Ia55172a5440b4338ee6ae9b246c42b42805dd258
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia55172a5440b4338ee6ae9b246c42b42805dd258
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[ovirt-live-3.6]: centos: rebase kickstart on 7.2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: rebase kickstart on 7.2
......................................................................
centos: rebase kickstart on 7.2
Change-Id: Ie573a4249895e201db33fd45995b69c3d8c26208
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie573a4249895e201db33fd45995b69c3d8c26208
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[ovirt-live-3.6]: centos: Rebase toolchain on 7.2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: Rebase toolchain on 7.2
......................................................................
centos: Rebase toolchain on 7.2
Change-Id: I6d2ee922c13dfdf9332d681aaebe5e5026e1c46b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d2ee922c13dfdf9332d681aaebe5e5026e1c46b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[master]: centos: drop packages not available on 7.2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: drop packages not available on 7.2
......................................................................
centos: drop packages not available on 7.2
Change-Id: Ia55172a5440b4338ee6ae9b246c42b42805dd258
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50541
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia55172a5440b4338ee6ae9b246c42b42805dd258
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[master]: centos: rebase kickstart on 7.2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: rebase kickstart on 7.2
......................................................................
centos: rebase kickstart on 7.2
Change-Id: Ie573a4249895e201db33fd45995b69c3d8c26208
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50536
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie573a4249895e201db33fd45995b69c3d8c26208
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years