December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fix potential NPE in SD CommandBase
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Fix potential NPE in SD CommandBase ...................................................................... engine: Fix potential NPE in SD CommandBase Fix potential NPE in StorageDomainCommandBase. Adding a test with null status. Issue found by Coverity #1201892 Change-Id: I2f6a32c9df40cfc5a724b4bd2583ecdad805a892 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/50390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f6a32c9df40cfc5a724b4bd2583ecdad805a892 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Improve the handling of empty NUMA distances
by tnisan＠redhat.com 14 Dec '15

14 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: Improve the handling of empty NUMA distances ...................................................................... Improve the handling of empty NUMA distances There was still a chance for NPE when an empty dictionary was received. Change-Id: I7da52a07f2da747f238b04f378b5e3fdd2eb5272 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1284245 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7da52a07f2da747f238b04f378b5e3fdd2eb5272 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: exttool: aaa: add change-credentials action
by masayag＠redhat.com 14 Dec '15

14 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: aaa: add change-credentials action ...................................................................... exttool: aaa: add change-credentials action Change-Id: Ibf9167b964c11ca22b0a02fced46df93f5c4b270 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1290737 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties 2 files changed, 188 insertions(+), 49 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondra Machacek: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9167b964c11ca22b0a02fced46df93f5c4b270 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Removed org.ovirt.engine.core.utils.linq
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed org.ovirt.engine.core.utils.linq ...................................................................... core: Removed org.ovirt.engine.core.utils.linq Removed the org.ovirt.engine.core.utils.linq package that is now unused within the codebase. Future code that needs to manipulate collections can use the streaming API introduced in Java 8. Change-Id: Ic18e95462876fb9e9ba2d7638bddc605c838bbc7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Aggregator.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/All.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/DefaultMapper.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Function.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Mapper.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/NotPredicate.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/Predicate.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/NotPredicateTest.java 10 files changed, 0 insertions(+), 368 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/50402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic18e95462876fb9e9ba2d7638bddc605c838bbc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Added blank line
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: packaging: Added blank line ...................................................................... packaging: Added blank line Fixed broken build. New line was missing according to PEP E301. Change-Id: I2c1d943d17468ce79676080a099ce6d0b9cc4fc5 Bug-Url: https://bugzilla.redhat.com/1143869 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomer Saban: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1d943d17468ce79676080a099ce6d0b9cc4fc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HaReservationBalancePolicyUnit streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: HaReservationBalancePolicyUnit streaming API usage ...................................................................... core: HaReservationBalancePolicyUnit streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: I6af9398c590642b5b1875fb1da6950563bd0742e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationBalancePolicyUnit.java 1 file changed, 3 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af9398c590642b5b1875fb1da6950563bd0742e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: PowerSavingBalancePolicyUnit streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: PowerSavingBalancePolicyUnit streaming API usage ...................................................................... core: PowerSavingBalancePolicyUnit streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch does not only replace an outdated syntax with a more modern one, it also offers a (theoretical) performance improvement by using findFirst's short-circuiting termination logic and stopping the iteration once a host that fulfils the conditions is found. This patch is part of the effort to remove LinqUtils completely. Change-Id: I11ee8d61155c7e15b2a7a27ffe59872ad4d7fd4a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java 1 file changed, 9 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11ee8d61155c7e15b2a7a27ffe59872ad4d7fd4a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: EvenGuestDistributionBalancePolicyUnit streaming API u...
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: EvenGuestDistributionBalancePolicyUnit streaming API usage ...................................................................... core: EvenGuestDistributionBalancePolicyUnit streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: I0e239869192ffc318011ae18053601b65e18d03e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenGuestDistributionBalancePolicyUnit.java 1 file changed, 8 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e239869192ffc318011ae18053601b65e18d03e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CpuAndMemoryBalancingPolicyUnit streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: CpuAndMemoryBalancingPolicyUnit streaming API usage ...................................................................... core: CpuAndMemoryBalancingPolicyUnit streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: I71e48e493047279f811b5663bf0214672e703bc5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java 1 file changed, 15 insertions(+), 22 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71e48e493047279f811b5663bf0214672e703bc5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FindVmAndDestinations streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: FindVmAndDestinations streaming API usage ...................................................................... core: FindVmAndDestinations streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: If02edfd391bcd204ca79e498b8cd0edf52b33074 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java 1 file changed, 6 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If02edfd391bcd204ca79e498b8cd0edf52b33074 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0