December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SearchQueryTest#testGetAllVMTemplatesSearch
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQueryTest#testGetAllVMTemplatesSearch ...................................................................... core: SearchQueryTest#testGetAllVMTemplatesSearch Enhance the test to not only test that the correct result is passed back by the DAO, but also test the filtering the code performs. Change-Id: I5f71dbf33dda0478f00c2ab50b59f8beb8bb9d41 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f71dbf33dda0478f00c2ab50b59f8beb8bb9d41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove ListUtils from SearchQuery
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove ListUtils from SearchQuery ...................................................................... core: Remove ListUtils from SearchQuery Removed the overly generic use of ListUtils in SearchQuery, in an attempt to remove this class completely. One instance (template searching) which actually needed a filter was replaced with Java 8's new streaming API. The second instance (VDS searching), which used the filter method but had nothing to do with filtering was replaced by a good old for loop. Change-Id: I7380a227d35d797387a17e850dadd4d2c842d465 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 10 insertions(+), 33 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7380a227d35d797387a17e850dadd4d2c842d465 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SearchQueryTest test templates search
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQueryTest test templates search ...................................................................... core: SearchQueryTest test templates search Added a basic test for searching templates with a comparable functionality to the other tests in the class (e.g., the VM tests). Change-Id: Id84a1770fc4e65597cb3d1b8259b32f34709fdd2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id84a1770fc4e65597cb3d1b8259b32f34709fdd2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SearchQueryTest members
by amureini＠redhat.com 11 Dec '15

11 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQueryTest members ...................................................................... core: SearchQueryTest members Reduce unneeded members' scope and convert them to local variables to make the code easier to read. Change-Id: I68ec8a62adfc3e0325e61cacb4d5b873c5560ae1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ec8a62adfc3e0325e61cacb4d5b873c5560ae1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SearchQueryTest asserts
by amureini＠redhat.com 11 Dec '15

11 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQueryTest asserts ...................................................................... core: SearchQueryTest asserts Replaced the assertTrue calls with == with the proper assertEquals calls. Change-Id: Ia9fab39f8b8f63ea82cc525e1bd5d3849f416fa6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9fab39f8b8f63ea82cc525e1bd5d3849f416fa6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SearchQueryTest static imports
by amureini＠redhat.com 11 Dec '15

11 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQueryTest static imports ...................................................................... core: SearchQueryTest static imports Standardize the usage of Mockito's static methods. Change-Id: I6831701b5e32fa56b156277e50dbf61ecb98a4ee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 25 insertions(+), 26 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6831701b5e32fa56b156277e50dbf61ecb98a4ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SearchQueryTest typo
by amureini＠redhat.com 11 Dec '15

11 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SearchQueryTest typo ...................................................................... core: SearchQueryTest typo Fixed mockDiskSao to the intended mockDiskDao. Change-Id: I0f8e5545e82a1402ec4b2f626840ffc54fce414e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f8e5545e82a1402ec4b2f626840ffc54fce414e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Implement "Comparable" in "Concept"
by juan.hernandez＠redhat.com 11 Dec '15

11 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Implement "Comparable" in "Concept" ...................................................................... restapi: Implement "Comparable" in "Concept" This patch changes the base class of the model concepts hierarchy so that it implementes the "Comparable" interface. Comparation is implemented using only the names. This will simplify the many places where concepts need to be sorted by name. Change-Id: I8f9a27cd67400d6416263645aa7d7985a174b1dd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Concept.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f9a27cd67400d6416263645aa7d7985a174b1dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Simplify the XML schema generator adding writer field
by juan.hernandez＠redhat.com 11 Dec '15

11 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Simplify the XML schema generator adding writer field ...................................................................... restapi: Simplify the XML schema generator adding writer field Currently the generator of the XML schema creates an XML writer and passes it as parameter to the methods that need it. This patch changes it so that this is a field, so there is no need to pass it around. Change-Id: I11798b33e5931804967ff739d77513635706a463 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java 1 file changed, 53 insertions(+), 44 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11798b33e5931804967ff739d77513635706a463 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Simplify XML writing
by juan.hernandez＠redhat.com 11 Dec '15

11 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Simplify XML writing ...................................................................... restapi: Simplify XML writing This patch changes the generators of the XML schema and the XML description of the model using the "XmlWriter" class instead of the "XMLStreamWriter" class. Change-Id: Ie65221be7099a487cb4ef0d715d2a70681b8fa85 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/XmlDescriptionGenerator.java 2 files changed, 62 insertions(+), 155 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65221be7099a487cb4ef0d715d2a70681b8fa85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0