December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add simplified XML writer
by juan.hernandez＠redhat.com 11 Dec '15

11 Dec '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add simplified XML writer ...................................................................... restapi: Add simplified XML writer This patch adds a new "XmlWriter" class that will be used by the metamodel tools to simplify the generation of XML documents. The only practical advantage of this class is that its methods don't throw checked exceptions, thus they are simpler to use together with streams and lambdas. Change-Id: If56882bc5ae794d5af34cb8594decbbbfed88873 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/XmlWriter.java A backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/XmlWriterException.java 2 files changed, 283 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If56882bc5ae794d5af34cb8594decbbbfed88873 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: recovery action if failed because not in maintenance
by msivak＠redhat.com 11 Dec '15

11 Dec '15

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: recovery action if failed because not in maintenance ...................................................................... upgrade: recovery action if failed because not in maintenance Suggest recovery action (restart the service when in maintenance) if the upgrade failed cause the host was not in maintenance mode. Text only. Change-Id: Iac48cbf2031b69c4c1f0cffeff73e91c1c88ac3b Bug-Url: https://bugzilla.redhat.com/1277646 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac48cbf2031b69c4c1f0cffeff73e91c1c88ac3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: upgrade: recovery action if failed because not in maintenance
by msivak＠redhat.com 11 Dec '15

11 Dec '15

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: recovery action if failed because not in maintenance ...................................................................... upgrade: recovery action if failed because not in maintenance Suggest recovery action (restart the service when in maintenance) if the upgrade failed cause the host was not in maintenance mode. Text only. Change-Id: Iac48cbf2031b69c4c1f0cffeff73e91c1c88ac3b Bug-Url: https://bugzilla.redhat.com/1277646 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac48cbf2031b69c4c1f0cffeff73e91c1c88ac3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: use DNF, if available.
by sbonazzo＠redhat.com 11 Dec '15

11 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: use DNF, if available. ...................................................................... packaging: setup: use DNF, if available. Bug-Url: https://bugzilla.redhat.com/1162508 Change-Id: I95d52022379e8422de9a3b95f9245b5e416a12be Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-upgrade-check M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 3 files changed, 76 insertions(+), 42 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/47304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95d52022379e8422de9a3b95f9245b5e416a12be Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: oVirt Live 3.6.1_rc4
by sbonazzo＠redhat.com 11 Dec '15

11 Dec '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.6.1_rc4 ...................................................................... build: oVirt Live 3.6.1_rc4 Change-Id: I988e5777264ade23d9055838cfefa8f2daebf287 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I988e5777264ade23d9055838cfefa8f2daebf287 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: error message improvement for detach network
by piotr.kliczewski＠gmail.com 11 Dec '15

11 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: error message improvement for detach network ...................................................................... engine: error message improvement for detach network improving error message when detaching network being used by vms. the new error message will distinct between single to plural cases. Change-Id: I25989f6f53ac292b63ab54f75587339249c22d44 Bug-Url: https://bugzilla.redhat.com/1216896 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 8 insertions(+), 71 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25989f6f53ac292b63ab54f75587339249c22d44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Refactor DetachNetworkUsedByVmValidator error messages
by piotr.kliczewski＠gmail.com 11 Dec '15

11 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Refactor DetachNetworkUsedByVmValidator error messages ...................................................................... engine: Refactor DetachNetworkUsedByVmValidator error messages Creating new error messages and marking the old one as deprecated Bug-Url: https://bugzilla.redhat.com/1216896 Change-Id: I8799286e1fd01267aa0be358e49e45fb6646c4b2 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 21 insertions(+), 13 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8799286e1fd01267aa0be358e49e45fb6646c4b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: fix for netmask prefix out of sync
by piotr.kliczewski＠gmail.com 11 Dec '15

11 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: fix for netmask prefix out of sync ...................................................................... engine: fix for netmask prefix out of sync Prefix and netmask represnting the same value will be reported as sync. Eg. netmask "255.255.255.255" represent the same prefix value as "32" Change-Id: Ieeda31a42341023a967dd0fb93052c7ea311bb98 Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurations.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java 2 files changed, 17 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeda31a42341023a967dd0fb93052c7ea311bb98 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce SubnetUtils
by piotr.kliczewski＠gmail.com 11 Dec '15

11 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Introduce SubnetUtils ...................................................................... engine: Introduce SubnetUtils The utils implements netmask and prefix comparison. Change-Id: I9e03b33e4d2284a919d964ecaa9922306e6792b3 Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SubnetUtils.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SubnetUtilsTest.java 2 files changed, 142 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e03b33e4d2284a919d964ecaa9922306e6792b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: CidrValidation refactor
by piotr.kliczewski＠gmail.com 11 Dec '15

11 Dec '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: CidrValidation refactor ...................................................................... webadmin: CidrValidation refactor Refactoring CidrValidation and its corresponding test. The refacor will make the test atomic. Will later be refactor again to support cidrValidator injection. Change-Id: I062320b351df6933a45b730ac4ce3b54a7881706 Bug-Url: https://bugzilla.redhat.com/1269481 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java 2 files changed, 79 insertions(+), 86 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062320b351df6933a45b730ac4ce3b54a7881706 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0