Change in ovirt-engine[ovirt-engine-3.6]: engine: add integer to IPv4 format converter
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: add integer to IPv4 format converter
......................................................................
engine: add integer to IPv4 format converter
The functionality needed to be implemented as GWT
doesn't support INetAddress
Change-Id: I57fb8105cbc5208ecac0652f0c2f7e678fe01ffa
Bug-Url: https://bugzilla.redhat.com/1269481
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPAddressConverter.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPv4AddressConverter.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IpAddressConverter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/MaskValidator.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPv4AddressConverterTest.java
D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
8 files changed, 139 insertions(+), 82 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57fb8105cbc5208ecac0652f0c2f7e678fe01ffa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: engine: Inroduce DetachNetworkUsedByVmValidator
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Inroduce DetachNetworkUsedByVmValidator
......................................................................
engine: Inroduce DetachNetworkUsedByVmValidator
The Validator is creating a validation result
according to the given numbers of vms and
networks.
Change-Id: I90fab7507525cba000f7e2af4d82c45845ebbaa7
Bug-Url: https://bugzilla.redhat.com/1216896
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/DetachNetworkUsedByVmValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 141 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90fab7507525cba000f7e2af4d82c45845ebbaa7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: adding key-value format validation to HostSetupNet...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: adding key-value format validation to HostSetupNetwork
......................................................................
webadmin: adding key-value format validation to HostSetupNetwork
adding key-value format validation to Bonding mode
custom
Change-Id: Iad7107e10a6bb29fd0982b330a3e061efbcae2b8
Bug-Url: https://bugzilla.redhat.com/1167812
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad7107e10a6bb29fd0982b330a3e061efbcae2b8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce KeyValueFormatValidation
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Introduce KeyValueFormatValidation
......................................................................
engine: Introduce KeyValueFormatValidation
validation for <key>=<value> spaced separated format.
Please note that extra space is needed in the message ( < key >=< value >) as the message is
being translating to html.
The value between the <> is not being shown.
The usage of < > was avoided in order to make the language translation easier.
Bug-Url: https://bugzilla.redhat.com/1167812
Change-Id: I78ae0322d49356ba0ef9e0e496a232348a715eef
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidation.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/KeyValueFormatValidationTest.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
4 files changed, 201 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78ae0322d49356ba0ef9e0e496a232348a715eef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: adding custom bond validation to hostSetupNetwork
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: adding custom bond validation to hostSetupNetwork
......................................................................
webadmin: adding custom bond validation to
hostSetupNetwork
adding a non empty validaiton to custom mode.
Change-Id: I1c0722d8872a700c5d843a0a4784356794725b9b
Bug-Url: https://bugzilla.redhat.com/1167812
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml
4 files changed, 39 insertions(+), 24 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife8ce7d3988da31cb2646a725781819bddf33aa7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: core: Update maxSchedulingMemory in VDS when related values ...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Update maxSchedulingMemory in VDS when related values change
......................................................................
core: Update maxSchedulingMemory in VDS when related values change
When cloning VDS instances the calculeated maxSchedulingMemory was calculated
wrong. Now VDS recalculates maxSchedulingMemory whenever a variable, which is
part of the calculation changes.
This bug had no consequences because maxSchedulingMemory is currently not read
from cloned VDS instances.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1180071
Change-Id: I903d4c039be052ce0044f2a9eebe889cdfd5cb25
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
3 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Martin Sivák: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50104
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I903d4c039be052ce0044f2a9eebe889cdfd5cb25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: Improve the handling of empty NUMA distances
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: Improve the handling of empty NUMA distances
......................................................................
Improve the handling of empty NUMA distances
There was still a chance for NPE when an empty dictionary
was received.
Change-Id: I7da52a07f2da747f238b04f378b5e3fdd2eb5272
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252055
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7da52a07f2da747f238b04f378b5e3fdd2eb5272
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: restapi: Calculate correctly the singular for "errata"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Calculate correctly the singular for "errata"
......................................................................
restapi: Calculate correctly the singular for "errata"
The rule to calculate the singular of "errata" needs to be added
explicitly to the "Words" class.
Change-Id: I4622073cb1a5cae1d1ca862ae87ce56a1be25710
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/Words.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/50264
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4622073cb1a5cae1d1ca862ae87ce56a1be25710
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in jenkins[master]: Fix issue when cleaning up some interfaces
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Fix issue when cleaning up some interfaces
......................................................................
Fix issue when cleaning up some interfaces
It turns out that it was not correctly parsing the interface name in
some cases
Change-Id: I6d1a873647e61b3bb081a6ffe4b21f7c2750effd
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/shell-scripts/cleanup_slave.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
David Caro: Verified; Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/50292
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d1a873647e61b3bb081a6ffe4b21f7c2750effd
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: restapi: Document the use of "All-Content" for VMs
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Document the use of "All-Content" for VMs
......................................................................
restapi: Document the use of "All-Content" for VMs
This patch documents the meaning of the "All-Content" header for virtual
machines.
Change-Id: I5b296dbd87e6cc956cd5aac105b30775e82169b1
Bug-Url: https://bugzilla.redhat.com/1278738
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/model/src/main/java/services/VmService.java
1 file changed, 23 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/50160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b296dbd87e6cc956cd5aac105b30775e82169b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years