Change in ovirt-engine[master]: webadmin: Edit template dialog: name field fixed
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Edit template dialog: name field fixed
......................................................................
webadmin: Edit template dialog: name field fixed
Name field of Edit template dialog was too high.
Change-Id: If88ae6a153aea2a25dfccef2493314f202b98787
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
2 files changed, 3 insertions(+), 10 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If88ae6a153aea2a25dfccef2493314f202b98787
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: gluster:replace Runnable creation with lambda exp
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: gluster:replace Runnable creation with lambda exp
......................................................................
gluster:replace Runnable creation with lambda exp
Change-Id: I2f3ab1767b3c214445620f79505c6382bdbd42b7
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
1 file changed, 10 insertions(+), 17 deletions(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f3ab1767b3c214445620f79505c6382bdbd42b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: restapi: Enable initialization via run-once
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: restapi: Enable initialization via run-once
......................................................................
restapi: Enable initialization via run-once
Run-once needs to support initialization in order to rerun cloud-init
(same as UI)
This patch enables to set users others then root via rest.
Change-Id: I70ba0d8c4308d2e91540777a2406627d3c79af22
Bug-Url: https://bugzilla.redhat.com/1287122
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
1 file changed, 5 insertions(+), 17 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50094
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70ba0d8c4308d2e91540777a2406627d3c79af22
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: external VM can be added without storage
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: external VM can be added without storage
......................................................................
core: external VM can be added without storage
External VM can be added even if storage is not configured.
Checks in AddVmCommand.canDoAction are reduced.
Change-Id: I9cbf81db6dc80663c143eab5853390c39bf4d5c1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283151
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49010
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cbf81db6dc80663c143eab5853390c39bf4d5c1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.1 RC3
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: oVirt Live 3.6.1 RC3
......................................................................
oVirt Live 3.6.1 RC3
Change-Id: Iba931c28935036e2f892802a9aef16ba00b2f280
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50229
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba931c28935036e2f892802a9aef16ba00b2f280
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: bll: rename GetServerSSHPublicKeyQuery->GetEngineSSHPublicKe...
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: bll: rename GetServerSSHPublicKeyQuery->GetEngineSSHPublicKeyQuery
......................................................................
bll: rename GetServerSSHPublicKeyQuery->GetEngineSSHPublicKeyQuery
Confusing name, it is engine only query
Change-Id: I786fd1573dee66689756c42f9deb688b4c25817f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/GetEngineSSHPublicKeyQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java
5 files changed, 13 insertions(+), 12 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50225
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I786fd1573dee66689756c42f9deb688b4c25817f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: SetVmNumaNodesCommandTest LinqUtils
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: SetVmNumaNodesCommandTest LinqUtils
......................................................................
core: SetVmNumaNodesCommandTest LinqUtils
Replace usages of LinqUtils with Java 8's standard streaming API in
order to standardize the code and make it easier to read.
Change-Id: I89835a91a36dfac60df4ef2da7525dab914f990a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49273
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89835a91a36dfac60df4ef2da7525dab914f990a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: backend: Disable Live Snapshot on VMs with PCI passthrough
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: backend: Disable Live Snapshot on VMs with PCI passthrough
......................................................................
backend: Disable Live Snapshot on VMs with PCI passthrough
Libvirt does not support taking live snapshot with memory
when VM has PCI host devices attached.
Change-Id: Ib74fd17fe62adbc60c6be2d57e5da6718613aadd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1273044
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HostDeviceFilterPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 67 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49644
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib74fd17fe62adbc60c6be2d57e5da6718613aadd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: OvfDataUpdater methods naming conventions
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: OvfDataUpdater methods naming conventions
......................................................................
core: OvfDataUpdater methods naming conventions
Fixed naming conventions of the OvfDataUpdater class' methods
as per the recommended Java naming conventions.
Change-Id: I5e12a7031e505b73b165b82a27348d78e0f8a3ad
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdaterTest.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e12a7031e505b73b165b82a27348d78e0f8a3ad
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Use Java 8 streams in AddVmFromScratchCommand
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use Java 8 streams in AddVmFromScratchCommand
......................................................................
core: Use Java 8 streams in AddVmFromScratchCommand
Change-Id: Ia1b8ec28e006eb3a0ff7feb3293b40e1aa20c134
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
1 file changed, 3 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50033
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1b8ec28e006eb3a0ff7feb3293b40e1aa20c134
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years