Change in ovirt-engine[master]: frontend: Remove ClusterPopupView.localize() method
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Remove ClusterPopupView.localize() method
......................................................................
frontend: Remove ClusterPopupView.localize() method
Moved manual setting of label/text properties to ui.xml file, since
method contained no additional logic to setting it declaratively in
the ui.xml file.
Change-Id: I3cff12da1e9d53c1b1d0f2bfc1cd50a8c4911797
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
2 files changed, 56 insertions(+), 129 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cff12da1e9d53c1b1d0f2bfc1cd50a8c4911797
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: Improve the handling of empty NUMA distances
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: Improve the handling of empty NUMA distances
......................................................................
Improve the handling of empty NUMA distances
There was still a chance for NPE when an empty dictionary
was received.
Change-Id: I7da52a07f2da747f238b04f378b5e3fdd2eb5272
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252055
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Roman Mohr: Looks good to me, but someone else must approve
Roy Golan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7da52a07f2da747f238b04f378b5e3fdd2eb5272
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-ha[master]: upgrade: Use unpersist/persist cmds for ovirt node
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: Use unpersist/persist cmds for ovirt node
......................................................................
upgrade: Use unpersist/persist cmds for ovirt node
This patch adds the unperist and persist call to make
ovirt-hosted-engine-ha upgrade compatible with ovirt-node.
Change-Id: Iddd5b27952fb1c000e20d23740a613b028e1c469
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280310
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
M ovirt_hosted_engine_ha/lib/util.py
2 files changed, 28 insertions(+), 11 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd5b27952fb1c000e20d23740a613b028e1c469
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6.1]: config: increase heartbeat interval
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: config: increase heartbeat interval
......................................................................
config: increase heartbeat interval
We see communication issues due to "heartbeat exceeded" exception. In
order to mitigate those situation we increase heartbeat interval from
10 to 30 seconds.
Change-Id: I68b9627ab49f607c746e841476e60aaf127d0ed1
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1289123
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Tal Nisan: Passed CI tests
Eli Mesika: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68b9627ab49f607c746e841476e60aaf127d0ed1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-hosted-engine-setup[master]: setup: avoid closing stderr and provide a clear exit message
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: avoid closing stderr and provide a clear exit message
......................................................................
setup: avoid closing stderr and provide a clear exit message
Avoid closing stderr cause libvirt now doesn't complain anymore.
Provide a clear exit message on failures.
Change-Id: I61889b5d1ea8bcbd8d9b41f175d4f794c75082cc
Bug-Url: https://bugzilla.redhat.com/1287159
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M po/POTFILES.in
M src/plugins/ovirt-hosted-engine-setup/core/misc.py
M src/plugins/ovirt-hosted-engine-setup/libvirt/Makefile.am
M src/plugins/ovirt-hosted-engine-setup/libvirt/__init__.py
D src/plugins/ovirt-hosted-engine-setup/libvirt/workarounds.py
5 files changed, 16 insertions(+), 79 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49565
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61889b5d1ea8bcbd8d9b41f175d4f794c75082cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: cleanup, use getDiskImageDao at isCinderHasNoImages.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: cleanup, use getDiskImageDao at isCinderHasNoImages.
......................................................................
core: cleanup, use getDiskImageDao at isCinderHasNoImages.
Change-Id: I944a48fa1598eedc502ea30cc5de398c57b96f74
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/CINDERStorageHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49685
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I944a48fa1598eedc502ea30cc5de398c57b96f74
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Add Cinder helper method for candidate volumes to delete.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add Cinder helper method for candidate volumes to delete.
......................................................................
core: Add Cinder helper method for candidate volumes to delete.
getRedundantVolumeToDeleteAfterCommitSnapshot should return all the
volumes which are candidate to be deleted after commiting a Cinder snapshot.
For example volumes of recent snapshots which no longer needed after one
of the earliest snapshots gets previewed and commited.
Change-Id: Iee0b253ecc95a8c6c4abcbd2962c5152456cf440
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/CINDERStorageHelper.java
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee0b253ecc95a8c6c4abcbd2962c5152456cf440
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Use linked list instead of list.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use linked list instead of list.
......................................................................
core: Use linked list instead of list.
Use linked list for childCommandsParameters so it will be more easy to
implement LIFO method for child command parameters.
Change-Id: I804a84a7535e2e5e1590455009bc54220354f846
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48939
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I804a84a7535e2e5e1590455009bc54220354f846
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Add updateSnapshot to CinderDiskParameters.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add updateSnapshot to CinderDiskParameters.
......................................................................
core: Add updateSnapshot to CinderDiskParameters.
Add a new parameter called updateSnapshot.
This parameter should indicate whether the snapshot should be updated or
not while removing the volume.
For example when we remove an image while restoring a volume the
snapshot should not get updated, but when we remove a disk we definitely
need to remove the volume from all the VM's snapshots.
Change-Id: I8af9e844d6c0513230ad0966d4547ac2584b3711
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48938
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8af9e844d6c0513230ad0966d4547ac2584b3711
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Rename parameter cinderDisks to cinderDisksToRestore.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Rename parameter cinderDisks to cinderDisksToRestore.
......................................................................
core: Rename parameter cinderDisks to cinderDisksToRestore.
Change-Id: I7a1cf1261f867c517c6d87e1b3ed01629d60e335
Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/49417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a1cf1261f867c517c6d87e1b3ed01629d60e335
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years