February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Cluster dialog overlapping checkboxes fixed
by piotr.kliczewski＠gmail.com 20 Feb '15

20 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Cluster dialog overlapping checkboxes fixed ...................................................................... webadmin: Cluster dialog overlapping checkboxes fixed 'Enable Virt Service' checkbox and 'Enable Gluster Service' checkbox in New/Edit Cluster dialog were overlapped in webkit based browsers due to css browser specific media queries. Change-Id: I07b3d83a0d2af26c6c722542bea7cdf402f7dd2e Bug-Url: https://bugzilla.redhat.com/1138556 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Jakub Niedermertl: Verified Alexander Wels: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07b3d83a0d2af26c6c722542bea7cdf402f7dd2e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: do not select non approved host as a proxy
by piotr.kliczewski＠gmail.com 20 Feb '15

20 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: do not select non approved host as a proxy ...................................................................... core: do not select non approved host as a proxy If the proxy host is ovirt-node / rhev-h, do not select it before it is approved. Change-Id: I5f53ce9267af4a59b16a09535fed6150a0104bd8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1184781 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f53ce9267af4a59b16a09535fed6150a0104bd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin, aaa: Sorting by 'authorization provider' in 'users...
by piotr.kliczewski＠gmail.com 20 Feb '15

20 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin, aaa: Sorting by 'authorization provider' in 'users' tab don't sort ...................................................................... webadmin, aaa: Sorting by 'authorization provider' in 'users' tab don't sort Sorting users by 'authorization provider' does not work in webadmin users tab Change-Id: Ia1597c2b31b23c4352a883ff75e4f06f06070791 Bug-Url: https://bugzilla.redhat.com/1194262 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1597c2b31b23c4352a883ff75e4f06f06070791 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Geo-rep Actions UI
by kmayilsa＠redhat.com 20 Feb '15

20 Feb '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Geo-rep Actions UI ...................................................................... webadmin : Geo-rep Actions UI This patch adds the following actions to Geo-rep sub-tab : 1. Start : It allows the user to start the selected geo-rep session. 2. Stop : It allows the user to stop the selected geo-rep session. 3. Pause : It allows the user to pause the selected geo-rep session. 4. Resume : It allows the user to resume the selected geo-rep session. Change-Id: I46fbd79f714175e3ad3ce76d858714c6fec3fdde Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepActionConfirmPopUpViewPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java 10 files changed, 285 insertions(+), 37 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46fbd79f714175e3ad3ce76d858714c6fec3fdde Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove dead code of template deletion by SD
by derez＠redhat.com 19 Feb '15

19 Feb '15

Daniel Erez has submitted this change and it was merged. Change subject: core: remove dead code of template deletion by SD ...................................................................... core: remove dead code of template deletion by SD Deleting a template by a storage domain is deprecated (and not functional) since introduction of MSD feature. Hence, removing all relevant dead code. Change-Id: Iea08a582e5887a5458efef0870f18af83046f4fc Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 13 insertions(+), 72 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea08a582e5887a5458efef0870f18af83046f4fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Updated the README
by dcaroest＠redhat.com 19 Feb '15

19 Feb '15

David Caro has submitted this change and it was merged. Change subject: Updated the README ...................................................................... Updated the README Just made it correct, this does not count as real documentation Change-Id: I9b19e55398396c699bd385fa771353572f3c12f0 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/README 1 file changed, 62 insertions(+), 28 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b19e55398396c699bd385fa771353572f3c12f0 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, aaa: Sorting by 'authorization provider' in 'user...
by oourfali＠redhat.com 19 Feb '15

19 Feb '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin, aaa: Sorting by 'authorization provider' in 'users' tab don't sort ...................................................................... webadmin, aaa: Sorting by 'authorization provider' in 'users' tab don't sort Sorting users by 'authorization provider' does not work in webadmin users tab Change-Id: Ia1597c2b31b23c4352a883ff75e4f06f06070791 Bug-Url: https://bugzilla.redhat.com/1194262 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1597c2b31b23c4352a883ff75e4f06f06070791 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add validation when Storage Domain is blocked.
by mlipchuk＠redhat.com 19 Feb '15

19 Feb '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add validation when Storage Domain is blocked. ...................................................................... core: Add validation when Storage Domain is blocked. Remove keys from canDoAction messages list to prevent those to be presented in the execute phase. Adding a CDA validation to prevent importing an iSCSI domain while there are connectivity issues. Change-Id: I9a7c12609b3780c74396dab6edf26e4deaff490f Bug-Url: https://bugzilla.redhat.com/1183537 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java 3 files changed, 16 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a7c12609b3780c74396dab6edf26e4deaff490f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.5]: packaging: use default private caching for rpms
by sbonazzo＠redhat.com 19 Feb '15

19 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: use default private caching for rpms ...................................................................... packaging: use default private caching for rpms Avoid to use /home as caching directory and use default private caching instead. Change-Id: I4dbac745b98d720d8bdfbb2ca4e0a5ddd93f3027 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M fedora/Makefile 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dbac745b98d720d8bdfbb2ca4e0a5ddd93f3027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: packaging: use default private caching for rpms
by sbonazzo＠redhat.com 19 Feb '15

19 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: use default private caching for rpms ...................................................................... packaging: use default private caching for rpms Avoid to use /home as caching directory and use default private caching instead. Change-Id: I4dbac745b98d720d8bdfbb2ca4e0a5ddd93f3027 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-6/Makefile M centos-7/Makefile M fedora/Makefile 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved David Caro: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dbac745b98d720d8bdfbb2ca4e0a5ddd93f3027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0