Change in ovirt-engine-sdk-java[master]: codegen: Use commons-io instead of custom code
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Use commons-io instead of custom code
......................................................................
codegen: Use commons-io instead of custom code
This patch replaces the custom FileUtils class with commons-io, which
provides many functionalities that will be used by future patches.
Change-Id: I310b20d54e64e814301ff19c8d1f90242bc581f6
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/pom.xml
M generator/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/templates/ExtraMethodParameterTemplate.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/templates/HeaderBuilderParameterTemplate.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/templates/MethodParameterTemplate.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/templates/UrlBuilderParameterTemplate.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/utils/ClassUtils.java
D generator/src/main/java/org/ovirt/engine/sdk/codegen/utils/FileUtils.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringTemplateWrapper.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java
M generator/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java
11 files changed, 94 insertions(+), 350 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I310b20d54e64e814301ff19c8d1f90242bc581f6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[master]: restapi: Fix XML schema for fencing agents
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix XML schema for fencing agents
......................................................................
restapi: Fix XML schema for fencing agents
The "Agents" XML complex type corresponds to a collection, not to an
entity. But it is defined as an extension of the "BaseResource" type,
which corresponds to entities, not to collections. This breaks our rules
for XML schema and induces errors in the Java SDK, as the generated type
"Agents" is not within the bounds of the type parameters used by the
generic type "CollectionDecorator". This patch fixes the "Agents" type
so that it extends "BaseResources".
Change-Id: Ia5eed94f34ce7fafd98c362356e333db117668be
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5eed94f34ce7fafd98c362356e333db117668be
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.2_rc1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-live-3.5.2_rc1
......................................................................
build: ovirt-live-3.5.2_rc1
Change-Id: I05ff7dd26da3fc5977450f70eeb21f94bafab89c
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38000
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05ff7dd26da3fc5977450f70eeb21f94bafab89c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-node-plugin-vdsm[master]: autoinstall: process params
by fabiand＠redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: autoinstall: process params
......................................................................
autoinstall: process params
Currently the autoinstall registration flags belongs to vdsm-reg
which should be deprecated. This patch adds autoinstall script
to manage the below kernel args:
- management_server
- management_server_port
- rhevm_admin_password
- ovirt_vdsm_disable
This patch will only parse the kernel arguments on the kernel
command line, it does not trigger the registration itself.
This is left to the generic registration once it lands.
Change-Id: Ibf664eb61344067427e4d88617dbbb7e8dd1d517
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M Makefile.am
A autoinstall/Makefile.am
A autoinstall/autoreg-args
A autoinstall/autoreg.py
M configure.ac
M ovirt-node-plugin-vdsm.spec.in
6 files changed, 131 insertions(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Looks good to me, approved
Douglas Schilling Landgraf: Verified
--
To view, visit https://gerrit.ovirt.org/38161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf664eb61344067427e4d88617dbbb7e8dd1d517
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add validation when Storage Domain is blocked.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add validation when Storage Domain is blocked.
......................................................................
core: Add validation when Storage Domain is blocked.
Adding a CDA validation to prevent importing an iSCSI domain
while there are connectivity issues.
Change-Id: I9a7c12609b3780c74396dab6edf26e4deaff490f
Bug-Url: https://bugzilla.redhat.com/1195032
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/37956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a7c12609b3780c74396dab6edf26e4deaff490f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: webadmin: UI fix in PosixStorageView and GlusterStorageView.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: UI fix in PosixStorageView and GlusterStorageView.
......................................................................
webadmin: UI fix in PosixStorageView and GlusterStorageView.
"Mount options" and "vfs type" options' text editors was not aligned with
its labels as described in the bug.
This patch adds a fix already made for other Views to these
StorageViews.
Change-Id: I65b28387e473682dff9db4ea7befd146016dd932
Bug-Url: https://bugzilla.redhat.com/1195334
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/38196
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65b28387e473682dff9db4ea7befd146016dd932
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core: Fix fixtures schema for vm_interface_statistics
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix fixtures schema for vm_interface_statistics
......................................................................
core: Fix fixtures schema for vm_interface_statistics
Remove redundant vm interface statistic without VM.
Changing the test accordingly.
Change-Id: I5d1e148ed6e3c8f6495aefc3cd9218a8798f4169
Bug-Url: https://bugzilla.redhat.com/1191397
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
2 files changed, 1 insertion(+), 16 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/38202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d1e148ed6e3c8f6495aefc3cd9218a8798f4169
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in jenkins[master]: Added slave cleanup
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added slave cleanup
......................................................................
Added slave cleanup
That will make all the jobs that have yaml, to cleanup as much as possible
before starting, to avoid the last disk space issues.
Change-Id: I7575d38367008f9d9e1eaeaedc7f639d95e5b723
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A jobs/confs/shell-scripts/cleanup_slave.sh
A jobs/confs/yaml/builders/cleanup.yaml
M jobs/confs/yaml/templates/create-rpms_mock.yaml
M jobs/confs/yaml/templates/engine-upgrade-db.yaml
M jobs/confs/yaml/templates/install-rpm-sanity.yaml
M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
7 files changed, 190 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7575d38367008f9d9e1eaeaedc7f639d95e5b723
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[ovirt-engine-3.5.2]: engine : NPE when adding a VM to a VM pool when there's not ...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : NPE when adding a VM to a VM pool when there's not enough storage
......................................................................
engine : NPE when adding a VM to a VM pool when there's not enough storage
NPE in the engine log while adding a vm to
an existing pool, when there is not enough
storage to perform this operation.
Change-Id: I0d53e9505054f9476910154a7677d273293f79c0
Bug-Url: https://bugzilla.redhat.com/1179558
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit 113f99d5fd26c760a992b0f160996259e8a79f47)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d53e9505054f9476910154a7677d273293f79c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[ovirt-engine-3.5]: engine : NPE when adding a VM to a VM pool when there's not ...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : NPE when adding a VM to a VM pool when there's not enough storage
......................................................................
engine : NPE when adding a VM to a VM pool when there's not enough storage
NPE in the engine log while adding a vm to
an existing pool, when there is not enough
storage to perform this operation.
Change-Id: I0d53e9505054f9476910154a7677d273293f79c0
Bug-Url: https://bugzilla.redhat.com/1179558
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d53e9505054f9476910154a7677d273293f79c0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months