Change in ovirt-engine[master]: Revert "restapi: optimize getUriBuilder"
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Revert "restapi: optimize getUriBuilder"
......................................................................
Revert "restapi: optimize getUriBuilder"
This reverts commit d83d67ff715c0707b1715e09249532ca14c7e21a.
The original patch added a static Map that cached UriBuilders. This made
the test "testGet" in "BackendHostNicLabelResourceTest" fail in
some cases.
Since JUnit test order is not deterministic some tests would wrongly use
cached UriBuilders from previous tests and thus fail.
Change-Id: I18db692bcfd0de26bb57481657b7645a01acb7d3
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
2 files changed, 13 insertions(+), 54 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/38165
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18db692bcfd0de26bb57481657b7645a01acb7d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: engine: forbid single (vm mem) > (host mem)
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: forbid single (vm mem) > (host mem)
......................................................................
engine: forbid single (vm mem) > (host mem)
Forbid running single vm with mem > host physical memory.
Yet we allow running few vms with total mem > host physical memory. (relying on balloning).
This might be unwise yet can occour after migration or/and host downsizing.
Whenever the: (vm mem) > (host mem) the host will start swaping and performance degrage.
If it possible to think of scenrios vm allocated large mem and not using it, and cannot downsize vm mem.
Fix swap and refactor reused messages.
If fail run vm due to insufficent mem. Report the available mem.
Added unit test to SlaValidatorTest
Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98
Bug-Url: https://bugzilla.redhat.com/1180071
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SlaValidatorTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 99 insertions(+), 13 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: webadmin, engine: Gluster domain edit enhancement.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin, engine: Gluster domain edit enhancement.
......................................................................
webadmin, engine: Gluster domain edit enhancement.
Gluster domain's connection and mount options editing was disabled in webadmin and engine.
This patch adds the possibility to edit it.
Change-Id: I7320520a15fe804a3a560bf1b8223bfee5b1b46a
Bug-Url: https://bugzilla.redhat.com/1168686
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/37894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7320520a15fe804a3a560bf1b8223bfee5b1b46a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: webadmin: Refactoring GlusterModel to inherit from PosixModel.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Refactoring GlusterModel to inherit from PosixModel.
......................................................................
webadmin: Refactoring GlusterModel to inherit from PosixModel.
Since GlusterStorageModel duplicates most of PosixStorageModel's
content, and Gluster domain is actually a Posix storage domain, it is
now inherits from PosixStorageModel.
Change-Id: I7a355956f0f30a79f13d0bd72ec7a4d65cc29d1a
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
3 files changed, 35 insertions(+), 273 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/37893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a355956f0f30a79f13d0bd72ec7a4d65cc29d1a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: engine: Correct user connected/disconnected messages
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: engine: Correct user connected/disconnected messages
......................................................................
engine: Correct user connected/disconnected messages
Message 'User disconnected' was added to Action Log when user had
connected to a VM and vice versa.
The bug was in VdsEventListener.processOnClientIpChange() method called
from VmsMonitoring.afterVMsRefreshTreatment() method.
processOnClientIpChange() was reading the client IP from DB, but IP
address of the currently connecting client is written to DB after
calling this method (saveVmsToDb() call at the end of
afterVMsRefreshTreatment() method).
To correct this additional parameter was added to
processOnClientIpChange() method to pass IP address of the currently
connecting client.
Change-Id: Icce32619e3cc88f12e339b4eef5717f3d279e232
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
3 files changed, 10 insertions(+), 6 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icce32619e3cc88f12e339b4eef5717f3d279e232
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in jenkins[master]: Changing ovirt-node scms to work on git protocol
by tlitovsk＠redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: Changing ovirt-node scms to work on git protocol
......................................................................
Changing ovirt-node scms to work on git protocol
Change-Id: If38b9d369a3b0c597002cd07cd0063ccd9e75188
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
M jobs/confs/yaml/scms/ovirt-node-scms.yaml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
David Caro: Looks good to me, but someone else must approve
Anatoly Litovsky: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38144
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If38b9d369a3b0c597002cd07cd0063ccd9e75188
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: host-deploy: simplify remote bootstarp command
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: host-deploy: simplify remote bootstarp command
......................................................................
host-deploy: simplify remote bootstarp command
+ add -t parameter dropped in I9c780005a4.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195672
Change-Id: I0c3260f61b0acbd914d587a59e610a9d627227b3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38125
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c3260f61b0acbd914d587a59e610a9d627227b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in jenkins[master]: Fixed a couple typos
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Fixed a couple typos
......................................................................
Fixed a couple typos
Change-Id: Iba640b28e7558ebd14d97ddee50c210b5e00e710
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/README
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Eyal Edri: Looks good to me, approved
David Caro: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba640b28e7558ebd14d97ddee50c210b5e00e710
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: engine: Quartz cron scheduler to support startAt and endBy
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Quartz cron scheduler to support startAt and endBy
......................................................................
engine: Quartz cron scheduler to support startAt and endBy
Modified the Quartz scheduler to support start at and end by dates for
cron based scheduler
Change-Id: I5c3372098177dabbbe886660c9d7a586784b99be
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java
3 files changed, 90 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c3372098177dabbbe886660c9d7a586784b99be
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5.2]: setup: checking if command_entities table exist
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: setup: checking if command_entities table exist
......................................................................
setup: checking if command_entities table exist
oVirt 3.5 has introduced command_entities table.
In addition to adding some new functions related to this
table to the task clenaer utility, some functions got changed,
but as it is run during setup and might run on top of version which
preceeds oVirt 3.5, it should be checked in the relevant SPs that
the table exists.
Bug-Url: https://bugzilla.redhat.com/1161012
Bug-Url: https://bugzilla.redhat.com/1164771
Change-Id: I3152c4d3f6e02915053ada5019abeea7cb356751
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
(cherry picked from commit 3ba84df3d9e6597e131c3c9882e6d7136a54e296)
---
M packaging/setup/dbutils/taskcleaner.sh
M packaging/setup/dbutils/taskcleaner_sp.sql
A packaging/setup/dbutils/taskcleaner_sp_3_5.sql
3 files changed, 107 insertions(+), 81 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38157
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3152c4d3f6e02915053ada5019abeea7cb356751
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month