Change in ovirt-engine[master]: core : Remove child command Placeholder mechanism
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Remove child command Placeholder mechanism
......................................................................
core : Remove child command Placeholder mechanism
Remove inserting all child command place
holder mechanism from backend
Change-Id: Iae746ec8e328740aa4c48a08df7e793e85e17093
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java
7 files changed, 36 insertions(+), 140 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae746ec8e328740aa4c48a08df7e793e85e17093
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core : Change ImageSpmCommand to not use placeholder mechanism
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Change ImageSpmCommand to not use placeholder mechanism
......................................................................
core : Change ImageSpmCommand to not use placeholder mechanism
Change ImageSpmCommand to not use the
place holder mechanism to insert async
task placeholder before the execute
method of the command
Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
Liron Aravot: Looks good to me, but someone else must approve
Objections:
oVirt Jenkins CI Server: I would prefer that you didn't submit this
--
To view, visit https://gerrit.ovirt.org/37149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I897c9c3cf9e39000f2f2a90b26e01fff7861582c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core : Change HibernateVmCommand to not use placeholders mec...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Change HibernateVmCommand to not use placeholders mechanism
......................................................................
core : Change HibernateVmCommand to not use placeholders mechanism
HibernateVmCommand has been changed not
to insert placeholders for all child commands before
execution by vdsm
Change-Id: Ifc33acd404a835a98d315bed6a0195966a44ee25
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
1 file changed, 2 insertions(+), 8 deletions(-)
Approvals:
Ravi Nori: Verified
Arik Hadas: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37148
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc33acd404a835a98d315bed6a0195966a44ee25
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core : Change AddVmTemplateCommand to not use placeholders m...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core : Change AddVmTemplateCommand to not use placeholders mechanism
......................................................................
core : Change AddVmTemplateCommand to not use placeholders mechanism
AddVmTemplateCommand has been changed not
to insert placeholders for all child commands before
execution by vdsm
Change-Id: I07a9dad13443776f88b9bcbdb108eb302d01c555
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
2 files changed, 6 insertions(+), 15 deletions(-)
Approvals:
Ravi Nori: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37147
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07a9dad13443776f88b9bcbdb108eb302d01c555
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Prepare for next development iteration
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Prepare for next development iteration
......................................................................
sdk: Prepare for next development iteration
In preparation for the next development iteration this patch increases
the version number, adds the SNAPSHOT suffix to the maven version and
sets the RPM release number to 0.1.
Change-Id: I05d8bb312e3f0246120666e3a5d2d506f8a9b410
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37959
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05d8bb312e3f0246120666e3a5d2d506f8a9b410
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Release 3.5.2.0
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Release 3.5.2.0
......................................................................
sdk: Release 3.5.2.0
Change-Id: I5c514ac7b40969061b88852b612d95ace5bbeb70
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/pom.xml
M ovirt-engine-sdk-java/spec.el6.in
M ovirt-engine-sdk-java/spec.el7.in
M ovirt-engine-sdk-java/spec.fc20.in
M ovirt-engine-sdk-java/spec.fc21.in
6 files changed, 18 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37958
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c514ac7b40969061b88852b612d95ace5bbeb70
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Regenerate against the latest API
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Regenerate against the latest API
......................................................................
sdk: Regenerate against the latest API
This patch regenerates the SDK using the latest API obtained from the
engine built from commit fdb16f4, corresponding to tag
ovirt-engine-3.5.2_rc1.
Change-Id: I6b02eda033321e90a7a00959f45cc46429e5ff66
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/resources/api.rsdl
M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Hosts.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomain.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/StorageDomain.java
5 files changed, 246 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37957
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b02eda033321e90a7a00959f45cc46429e5ff66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 10 months
Change in ovirt-engine[master]: webadmin: Sync & Async builders
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Sync & Async builders
......................................................................
webadmin: Sync & Async builders
Till now all Builders run synchronously. This patch does necessary
refactoring for VmBase->Unit builders to run asynchronously.
* VmModelBehaviorBase#buildModel and overriding methods have signature
containing callback.
* interface SyncBuilder and class CompositeSyncBuilder were introduced
to mark synchronous builders.
* static method BuilderList#build can now run only synchronous builders
Change-Id: I10a94c3c59f5641a2661781c6dc227f572447468
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BaseSyncBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/Builder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutor.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/CompositeSyncBuilder.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/SyncBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonUnitToVmBaseBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/FullUnitToVmBaseBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java
15 files changed, 311 insertions(+), 265 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38067
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10a94c3c59f5641a2661781c6dc227f572447468
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core: Add managed devices to OVF
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add managed devices to OVF
......................................................................
core: Add managed devices to OVF
Add all managed devices to the VM before generating the OVF for
OVF_STORE disk.
Change-Id: Ie0e912c9b2950f1461ae95f4704f18b818b83a3b
Bug-Url: https://bugzilla.redhat.com/1191397
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java
1 file changed, 3 insertions(+), 25 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38120
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0e912c9b2950f1461ae95f4704f18b818b83a3b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months
Change in ovirt-engine[master]: core: Add fk constraint on vm_interface_statistics
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add fk constraint on vm_interface_statistics
......................................................................
core: Add fk constraint on vm_interface_statistics
Once a network interface is being removed from the Data Base its
corresponding statistics data in _vm_interface_statistics should be
removed also.
Currently, when a Storge Domain is being detached from a Data Center, all the data related
to it is being removed from the Data Base.
Since there is no foreign key between vm_interface and
vm_interface_statistics which does cascade delete there are left overs
which are left in vm_interface_statistics although the vm_interface was
deleted.
Change-Id: I53cf2737ef91cf967c93990fcb237f6c4e12a8f8
Bug-Url: https://bugzilla.redhat.com/1196251
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0930_add_delete_contraint_vm_interface_statistics.sql
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53cf2737ef91cf967c93990fcb237f6c4e12a8f8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 10 months