Change in ovirt-engine[master]: core: Fix performance issues with GetHostsAndVmsForClusters
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix performance issues with GetHostsAndVmsForClusters
......................................................................
core: Fix performance issues with GetHostsAndVmsForClusters
GetHostsAndVmsForClusters takes >30s in performance environment.
This is caused by an uneeded join between vm_static and vds_static.
This patch uses 2 sub-selects to eliminate the join and improve the performance.
This decreased execution time in the performance environment from 30s to <1s
Change-Id: I185e157bb00596c10449b637bf0c9a2c3b9d21e5
Bug-Url: https://bugzilla.redhat.com/1186737
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M packaging/dbscripts/vds_groups_sp.sql
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/37526
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I185e157bb00596c10449b637bf0c9a2c3b9d21e5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: engine: Use java naming convention for method argument
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use java naming convention for method argument
......................................................................
engine: Use java naming convention for method argument
Change-Id: I28c29ae11c56d30d48ce9a4a741051d2f77af56a
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Moti Asayag: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28c29ae11c56d30d48ce9a4a741051d2f77af56a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: webadmin: Fix permission addition
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: webadmin: Fix permission addition
......................................................................
webadmin: Fix permission addition
Permission model used an empty CTOR which is
required for serialization, without setting a proper ID.
Change-Id: Iaed42ab3e49172854c58024841bf2c097ca626c3
Bug-Url: https://bugzilla.redhat.com/1186722
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Moti Asayag: Looks good to me, approved
Yair Zaslavsky: Verified
--
To view, visit http://gerrit.ovirt.org/37612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaed42ab3e49172854c58024841bf2c097ca626c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: engine: Add GetManagementNetwork query
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add GetManagementNetwork query
......................................................................
engine: Add GetManagementNetwork query
Add GetManagementNetwork query.
The query retrieves the management network for the given cluster id.
Change-Id: Ifa29ba4326f8a514a91d6af6649cd14cb2ef7fec
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetManagementNetworkQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 25 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/37140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa29ba4326f8a514a91d6af6649cd14cb2ef7fec
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: engine: Add GetDefaultManagementNetwork query
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add GetDefaultManagementNetwork query
......................................................................
engine: Add GetDefaultManagementNetwork query
Add GetDefaultManagementNetwork query.
Change-Id: I723c5506768c88185e1a2afba766cd23d097703d
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetDefaultManagementNetworkQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/37139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I723c5506768c88185e1a2afba766cd23d097703d
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: engine: Fix typo
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Fix typo
......................................................................
engine: Fix typo
Fix typo: remove redundant "By" in GetNetworkByByNameAndDataCenterQuery.
Change-Id: I9587fd156c1ce3d5ddfe0f5c9a5741236990a9de
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkByNameAndDataCenterQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/37618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9587fd156c1ce3d5ddfe0f5c9a5741236990a9de
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[master]: restapi: Improve performance of mapping tests
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Improve performance of mapping tests
......................................................................
restapi: Improve performance of mapping tests
Change-Id: I98f26addcfbd74d6e3ac744f5a3a9ef6e1858907
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37616
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98f26addcfbd74d6e3ac744f5a3a9ef6e1858907
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[master]: engine: add IsManagementNetworkQuery
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add IsManagementNetworkQuery
......................................................................
engine: add IsManagementNetworkQuery
Add IsManagementNetworkQuery. The query returns a boolean value that
indicates whether the given network serves as the management one in
a cluster or not.
Change-Id: I1d5aa288e1952c1440229dbfd60d8bef9f2d1afa
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/IsManagementNetworkQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5aa288e1952c1440229dbfd60d8bef9f2d1afa
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: webadmin: remove management network indication from the netw...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: remove management network indication from the network main tab
......................................................................
webadmin: remove management network indication from the network main tab
Remove management network indication from the network main tab.
Change-Id: I9f23b765ab88907a095d004f214a6fb59fee8327
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
2 files changed, 11 insertions(+), 49 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/36914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f23b765ab88907a095d004f214a6fb59fee8327
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: webadmin: minor Java 7 related changes
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: minor Java 7 related changes
......................................................................
webadmin: minor Java 7 related changes
minor Java 7 related changes
Change-Id: I9e0734d5ec0c95f10240a6fe50bcda1a169d1d4a
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/36913
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e0734d5ec0c95f10240a6fe50bcda1a169d1d4a
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months