February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add management field to network_cluster table
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add management field to network_cluster table ...................................................................... engine: Add management field to network_cluster table Add management field to network_cluster table and support it in the DAO. Change-Id: I854a824d4ecac10cfc57829c169c52424aeaa75a Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_06_0840_add_management_to_network_cluster.sql 5 files changed, 72 insertions(+), 27 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/32781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I854a824d4ecac10cfc57829c169c52424aeaa75a Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000397 Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add management member to NetworkCluster business ent...
by alkaplan＠redhat.com 09 Feb '15

09 Feb '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add management member to NetworkCluster business entity class ...................................................................... engine: Add management member to NetworkCluster business entity class Add management member to NetworkCluster business entity class. Change-Id: I9d9e4bedec143511da8ffc0034f9109908af8b96 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java 5 files changed, 50 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/32772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9e4bedec143511da8ffc0034f9109908af8b96 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Permit updating the host provider
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Permit updating the host provider ...................................................................... core: Permit updating the host provider The host provider could be enabled for hosts which weren't installed by Foreman (i.e. to enable viewing their errata content). For that purpose the hostProviderId should be marked as editable. Change-Id: I677c45b8cde351d024815b835f768555bb19c3c8 Bug-Url: https://bugzilla.redhat.com/1157377 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I677c45b8cde351d024815b835f768555bb19c3c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add validation for host provider on update host
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add validation for host provider on update host ...................................................................... engine: Add validation for host provider on update host When updating a host within a cluster, there is need to verify the added host provider exists and that its type is Foreman. Change-Id: I37cdc594c0c119aa5ebfd77e551a002c00eb2df9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpdateHostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpdateHostValidatorTest.java 2 files changed, 96 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37cdc594c0c119aa5ebfd77e551a002c00eb2df9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Report available errata for host
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Report available errata for host ...................................................................... restapi: Report available errata for host The katello errata will be reported on host level: GET /api/hosts/{host:id}/katelloerrata GET /api/hosts/{host:id}/katelloerrata/{katelloerrata:id} No other actions are supported for host errata via the api. Feature page: http://www.ovirt.org/index.php?title=Home/Features/UpgradeManager Change-Id: Iad98a8066bd0f002cd58129ce583bc932afee8bc Bug-Url: https://bugzilla.redhat.com/1157377 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/externalhostproviders/KatelloErrataResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/externalhostproviders/KatelloErratumResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendHostKatelloErrataResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendHostKatelloErratumResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendHostKatelloErrataResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendHostKatelloErratumResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/externalhostproviders/ErratumMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ApplicationMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/externalhostproviders/ErratumMapperTest.java 16 files changed, 560 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad98a8066bd0f002cd58129ce583bc932afee8bc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Expose query for reporting errata for host
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Expose query for reporting errata for host ...................................................................... engine: Expose query for reporting errata for host The GetErrataByHostIdQuery query will retrieve available errata for a host which is registered to the katello/satellite service. If the host isn't registered, an empty list will be returned. If the service is not available, an error message will be returned. Change-Id: Ic881e18a53ac43c3fc3ef454c2047ca40599969b Bug-Url: https://bugzilla.redhat.com/1157377 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForHostQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErratumByIdForHostQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HostErratumQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 87 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic881e18a53ac43c3fc3ef454c2047ca40599969b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Retrieve errata from satellite/katello
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Retrieve errata from satellite/katello ...................................................................... engine: Retrieve errata from satellite/katello oVirt engine will provide errata for hosts which are registered to katello/satellite service via the foreman provider. If a host is registered more than once to the katello service, only its latest registration will be used to report the available errata. Feature page: http://www.ovirt.org/index.php?title=Home/Features/UpgradeManager Change-Id: I0d2b79d731dcd605aa567e544d09b56090174756 Bug-Url: https://bugzilla.redhat.com/1157377 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHost.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHostsWrapper.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ErrataWrapper.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ExternalErratum.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 6 files changed, 253 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d2b79d731dcd605aa567e544d09b56090174756 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce Erratum entity
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Introduce Erratum entity ...................................................................... core: Introduce Erratum entity The entity represents an erratum as should be retrieved from redhat content. Change-Id: I34e20197629b509b93a3646ef2907dba761b3f27 Bug-Url: https://bugzilla.redhat.com/1157377 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Erratum.java 1 file changed, 216 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34e20197629b509b93a3646ef2907dba761b3f27 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Refactor UpdateVdsCommand to use UpdateHostValidator
by masayag＠redhat.com 09 Feb '15

09 Feb '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor UpdateVdsCommand to use UpdateHostValidator ...................................................................... engine: Refactor UpdateVdsCommand to use UpdateHostValidator UpdateVdsCommand is modified to use the UpdateHostValidator, and also removing a test which its functionality is better covered by the validator test class. Change-Id: I4261f0ee923f081904a9b3d35f5c42747844b7b7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsCommandTest.java 2 files changed, 31 insertions(+), 111 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4261f0ee923f081904a9b3d35f5c42747844b7b7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve PM Status check flows
by oliel＠redhat.com 09 Feb '15

09 Feb '15

Ori Liel has submitted this change and it was merged. Change subject: core: Improve PM Status check flows ...................................................................... core: Improve PM Status check flows Checking Power-Management Status currently does not differentiate between checking the status of an Agent and checking the status of the Host. This patch provides a method for each in FenceExecutor and makes sure the correct one in invoked in each particular case Change-Id: I7155789d46b6902ff8425a723ecab1c77536f0c1 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFenceAgentStatusQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceExecutorTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetFenceAgentStatusParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 13 files changed, 143 insertions(+), 78 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7155789d46b6902ff8425a723ecab1c77536f0c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0