Change in ovirt-hosted-engine-setup[master]: packaging: setup: init NODE_SETUP at init
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: init NODE_SETUP at init
......................................................................
packaging: setup: init NODE_SETUP at init
Change-Id: Ibaf7f4ab713784bfd3eec013cadb343f70a4ee69
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/core/misc.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/37600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaf7f4ab713784bfd3eec013cadb343f70a4ee69
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: frontend: fix display and graphics combo boxes behavior
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: fix display and graphics combo boxes behavior
......................................................................
frontend: fix display and graphics combo boxes behavior
Previously displayType list model contained entity models of
DisplayType enum. This is not necessary and this patch makes changes
the listmodel to contain items of DisplayType enum directly.
By eliminating unnecessary complexity, the patch fixes following
issue:
When user selected display or graphics and then altered some other
field that caused reloading of display or graphics listmodels,
selected items weren't preserved since the 'preserving logic' was
comparing entity models of display types instead of display types
themselves.
This patch also changes backing models of graphics and display
listmodels - they are now LinkedHashSet instead of inappropriate
SortedSet (we need to preserve ordering of listmodel instead of
sorting backind data).
Change-Id: If6376386a0a996c6c80406a57d4dd9a90427126d
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1189152
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/HwOnlyCoreUnitToVmBaseBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java
9 files changed, 50 insertions(+), 119 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/37561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6376386a0a996c6c80406a57d4dd9a90427126d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: Make reports heap size configurable
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: Make reports heap size configurable
......................................................................
packaging: setup: Make reports heap size configurable
Set heap min/max by default to max(1GB, 25% of RAM).
Allow configuring by env.
Existing conf - by setup on upgrades or manually by
user - is kept as-is.
Includes Id4ca7789455d022c198f01d02a46c3580cec7016 squashed.
Change-Id: I021dbb42139adb99862d26038d2ab3fba7e7fb94
Bug-Url: https://bugzilla.redhat.com/1190466
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/java.py
3 files changed, 147 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/37577
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I021dbb42139adb99862d26038d2ab3fba7e7fb94
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: better handling of dirty storage
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: better handling of dirty storage
......................................................................
packaging: setup: better handling of dirty storage
Better handling of dirty storage. Now it checks the output
of getStorageDomainInfo to understand if the storage domain is really
there, otherwise it tries to create again.
The aim is to better handle retry on dirty storage where the VG is
there but it doesn't contain a valid storageDomain.
Change-Id: I7b9c05d26db929c408943455c7c9ac15764be3d4
Bug-Url: https://bugzilla.redhat.com/1155637
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 10 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/36811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b9c05d26db929c408943455c7c9ac15764be3d4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: Introduce UpdateHostValidator
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Introduce UpdateHostValidator
......................................................................
engine: Introduce UpdateHostValidator
The UpdateHostValidator is used for validating host when it
is being updated.
Change-Id: Ia015aad730686df7954db919c4bac9bf7bd3aa21
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpdateHostValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpdateHostValidatorTest.java
3 files changed, 409 insertions(+), 0 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Moti Asayag: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia015aad730686df7954db919c4bac9bf7bd3aa21
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: Extract repetitive method call into variable
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Extract repetitive method call into variable
......................................................................
engine: Extract repetitive method call into variable
Change-Id: I26950d627e437a67c10425057668335995207229
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
1 file changed, 14 insertions(+), 15 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Moti Asayag: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26950d627e437a67c10425057668335995207229
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: Replace endless method with early quit
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Replace endless method with early quit
......................................................................
engine: Replace endless method with early quit
The next step will be extracting methods into a descent
validator so this code could be tested properly and reuse
some of the methods introduced by HostValidator.
Change-Id: I986451efeed6ca05bca5db7b1b32e24be49c4f25
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
1 file changed, 91 insertions(+), 89 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Moti Asayag: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37467
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I986451efeed6ca05bca5db7b1b32e24be49c4f25
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: core: Maintain Java style for UpdateVdsActionParameters
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Maintain Java style for UpdateVdsActionParameters
......................................................................
core: Maintain Java style for UpdateVdsActionParameters
Change-Id: Icdf57cbffac354873bb37ef92944ba1de6b0c71c
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVdsActionParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
5 files changed, 52 insertions(+), 54 deletions(-)
Approvals:
Moti Asayag: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37466
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdf57cbffac354873bb37ef92944ba1de6b0c71c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: Make the logger consumable by inherited classes
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Make the logger consumable by inherited classes
......................................................................
engine: Make the logger consumable by inherited classes
Change-Id: Ifb59dfb04b829b65b537e83f13dfb76f1d8e686b
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Roy Golan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/37542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb59dfb04b829b65b537e83f13dfb76f1d8e686b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: restapi: Calculate singulars correctly
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Calculate singulars correctly
......................................................................
restapi: Calculate singulars correctly
The RSDL generator doesn't calculate singulars correctly. For example,
for the plural form "schedulingpolicies" it calculats the singular as
"schedulingpolicie". This is incorrect and doesn't match with the
singular form specified in the RSDL metadata. As a result the parameter
metadata for some entities and collections, in particular for scheduling
policy related entities and collections, isn't generated. As a result of
that the Python SDK doesn't contain the metadata, and thus the CLI
auto-completion doesn't work. This patch fixes the RSDL generator so
that singulars will be calculated correctly.
Change-Id: Ifbd00642de18637e2620433395b3065a062a4ee9
Bug-Url: https://bugzilla.redhat.com/1189095
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbd00642de18637e2620433395b3065a062a4ee9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months