Change in ovirt-engine[master]: webadmin: Remove manual progress operations from NetworkModel
by lvernia@redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Remove manual progress operations from NetworkModel
......................................................................
webadmin: Remove manual progress operations from NetworkModel
With the addition of the automatic infrastructure that takes care of
this, the manual code can be removed.
Change-Id: I56c28548f9d58295c69f678b8dc51483d97d1c6a
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
2 files changed, 5 insertions(+), 14 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56c28548f9d58295c69f678b8dc51483d97d1c6a
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: webadmin: Add RO column in Template's Disk sub-tab
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add RO column in Template's Disk sub-tab
......................................................................
webadmin: Add RO column in Template's Disk sub-tab
In the Disks sub tab in the Templates list, an additional column for the
Read Only state of the disks has been added.
The value for RO will be R/O and for RW it will be empty as in other
views.
Change-Id: I6d898656b0b8c497701c06cd1f28252bfb0fb8f9
Bug-Url: https://bugzilla.redhat.com/1057716
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateDiskView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Freddy Rolland: Verified
--
To view, visit http://gerrit.ovirt.org/37585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d898656b0b8c497701c06cd1f28252bfb0fb8f9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: pythonlib: allow java home bypass
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: pythonlib: allow java home bypass
......................................................................
pythonlib: allow java home bypass
to allow developers to use alternate JREs such as sun's.
Change-Id: I5f6c59fea689cff7ad4e8d33dad14e398a649ea6
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/java-home
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f6c59fea689cff7ad4e8d33dad14e398a649ea6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: pep8
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: pep8
......................................................................
packaging: setup: pep8
A fix for http://gerrit.ovirt.org/37576 .
Bug-Url: https://bugzilla.redhat.com/1188971
Change-Id: I6ba2f3885a05f6e6eeed6a60b03b16b011fa7d54
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/37589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ba2f3885a05f6e6eeed6a60b03b16b011fa7d54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Make engine heap size configurable
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: Make engine heap size configurable
......................................................................
packaging: setup: Make engine heap size configurable
Set heap min/max by default to max(1GB, 25% of RAM).
Allow configuring by env.
Existing conf - by setup on upgrades or manually by
user - is kept as-is.
Change-Id: I7ad1b1401d817883d1a26270280e54f1cfa8612b
Bug-Url: https://bugzilla.redhat.com/1188971
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 6523310897bc131ddc0f34631c6a34a58c52d6c6)
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/java.py
3 files changed, 148 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/37576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ad1b1401d817883d1a26270280e54f1cfa8612b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: expose total memory in env
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: expose total memory in env
......................................................................
packaging: setup: expose total memory in env
Includes I9d07718b1852f545813ce3893cca790a3294e2ad and
Ifd3d7eaf21ae0bc389e138729620422bfe5d5bfc squashed.
Change-Id: Ia25b24fb263390c9f6ae50708e2c3791d2c7a987
Bug-Url: https://bugzilla.redhat.com/1188971
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/base/system/__init__.py
A packaging/setup/plugins/ovirt-engine-common/base/system/mem.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py
4 files changed, 83 insertions(+), 31 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/37575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia25b24fb263390c9f6ae50708e2c3791d2c7a987
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: packaging: Typo in manpage
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Typo in manpage
......................................................................
packaging: Typo in manpage
Fixed typo "cleanip" to "cleanup"
Change-Id: Ieeb0cb05ec96301ea0d47ddab26f30f7950a6e8e
Bug-Url: https://bugzilla.redhat.com/1190152
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/man/man8/engine-cleanup.8
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/37566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb0cb05ec96301ea0d47ddab26f30f7950a6e8e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Infra for injecting beans in external JARs
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Infra for injecting beans in external JARs
......................................................................
core: Infra for injecting beans in external JARs
This patch introduces a ModuleExtension that can inject beans that are not
part of the EAR file. This is a limitation of JBoss 7, which is fixed in future versions.
Once we stop supporting older jboss - this code can be safely removed
Change-Id: I3b3c2c57178b5df4f98b4191ac9a06f9129414d0
Bug-Url: https://bugzilla.redhat.com/1159621
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/dependencies/common/pom.xml
A backend/manager/dependencies/common/src/main/modules/org/deltaspike/main/module.xml
A backend/manager/dependencies/common/src/main/modules/org/reflections/main/module.xml
M backend/manager/modules/bll/pom.xml
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java
A backend/manager/modules/bll/src/main/resources/META-INF/services/javax.enterprise.inject.spi.Extension
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SimpleDependecyInjector.java
M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml
A backend/manager/modules/dal/src/test/resources/test-beans.xml
M ear/src/main/resources/META-INF/MANIFEST.MF
M pom.xml
11 files changed, 220 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/37439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b3c2c57178b5df4f98b4191ac9a06f9129414d0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: core: fix remove snapshot with memory only
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix remove snapshot with memory only
......................................................................
core: fix remove snapshot with memory only
Fix removal of snapshot with a memory volume only (and no disks).
RemoveSnapshotCommand -> executeCommand:
invoking 'endVmCommand' manually when no async tasks are
available (i.e. when the snapshot doesn't include any disk)
[current behaviour leaves a locked snapshot in DB].
Change-Id: I95cef37947fd02fb54d8bb5a2014ccbab27dc434
Bug-Url: https://bugzilla.redhat.com/1189570
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95cef37947fd02fb54d8bb5a2014ccbab27dc434
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: fix remove snapshot with memory only
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: fix remove snapshot with memory only
......................................................................
core: fix remove snapshot with memory only
Fix removal of snapshot with a memory volume only (and no disks).
RemoveSnapshotCommand -> executeCommand:
invoking 'endVmCommand' manually when no async tasks are
available (i.e. when the snapshot doesn't include any disk)
[current behaviour leaves a locked snapshot in DB].
Change-Id: I95cef37947fd02fb54d8bb5a2014ccbab27dc434
Bug-Url: https://bugzilla.redhat.com/1189570
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95cef37947fd02fb54d8bb5a2014ccbab27dc434
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months