February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: pep8
by sbonazzo＠redhat.com 04 Feb '15

04 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: pep8 ...................................................................... packaging: setup: pep8 pep8 fixes for I9d07718b1852f545813ce3893cca790a3294e2ad Change-Id: Ifd3d7eaf21ae0bc389e138729620422bfe5d5bfc Bug-Url: https://bugzilla.redhat.com/1185411 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/system/mem.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd3d7eaf21ae0bc389e138729620422bfe5d5bfc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Fix Eject CD
by shavivi＠redhat.com 04 Feb '15

04 Feb '15

Shahar Havivi has submitted this change and it was merged. Change subject: backend: Fix Eject CD ...................................................................... backend: Fix Eject CD Fixed regression in ChangeDiskCommand which prohibited CD to be ejected. Change-Id: I3beec4fc1d5000ebbf47316bc8f56b1e36813983 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/37496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3beec4fc1d5000ebbf47316bc8f56b1e36813983 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Have custom device properties include security groups
by lvernia＠redhat.com 04 Feb '15

04 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: core: Have custom device properties include security groups ...................................................................... core: Have custom device properties include security groups It was somehow left out of d0d47186cedfe448629e2215e739ee6742b17b11 updating the configuration values to 3.6, and also the changes introduced in e24d0664cf32d6564f1e357d9bdef26a3e2d03e7 caused the configuration value not to be set on fresh installations. Change-Id: Idf34c06abc2347c20f7493d5e98177dfb82927d1 Bug-Url: https://bugzilla.redhat.com/1188655 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf34c06abc2347c20f7493d5e98177dfb82927d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: total mem env in common
by sbonazzo＠redhat.com 04 Feb '15

04 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: total mem env in common ...................................................................... packaging: setup: total mem env in common Move the check for amount of memory to common. Change-Id: I9d07718b1852f545813ce3893cca790a3294e2ad Bug-Url: https://bugzilla.redhat.com/1185411 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/system/mem.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py 3 files changed, 73 insertions(+), 35 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d07718b1852f545813ce3893cca790a3294e2ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Make engine heap size configurable
by sbonazzo＠redhat.com 03 Feb '15

03 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Make engine heap size configurable ...................................................................... packaging: setup: Make engine heap size configurable Set heap min/max by default to max(1GB, 25% of RAM). Allow configuring by env. Existing conf - by setup on upgrades or manually by user - is kept as-is. Change-Id: I7ad1b1401d817883d1a26270280e54f1cfa8612b Bug-Url: https://bugzilla.redhat.com/1185411 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/java.py 3 files changed, 148 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ad1b1401d817883d1a26270280e54f1cfa8612b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: expose total memory in env
by sbonazzo＠redhat.com 03 Feb '15

03 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: expose total memory in env ...................................................................... packaging: setup: expose total memory in env Change-Id: Ia25b24fb263390c9f6ae50708e2c3791d2c7a987 Bug-Url: https://bugzilla.redhat.com/1185411 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py 2 files changed, 29 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25b24fb263390c9f6ae50708e2c3791d2c7a987 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Fix symlink to c3p0 in Fedora 21
by sbonazzo＠redhat.com 03 Feb '15

03 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Fix symlink to c3p0 in Fedora 21 ...................................................................... packaging: Fix symlink to c3p0 in Fedora 21 The c3p0 library is completely useless for us, as the engine doesn't use it, but anyhow we have a module for it, and the symlink to the .jar file is broken in Fedora 21, as it has been moved from "/usr/share/java" to "/usr/share/java/c3p0". This causes a failure during the startup of the application server. This patch fixes the RPM spec so that it creates the correct symlink in Fedora 21. Change-Id: Iebc360999c5b6beaf1c60722f1c3003b95f27ec4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/37477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebc360999c5b6beaf1c60722f1c3003b95f27ec4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, userportal, webadmin: added singular variant for messages.
by lvernia＠redhat.com 03 Feb '15

03 Feb '15

Lior Vernia has submitted this change and it was merged. Change subject: core,userportal,webadmin: added singular variant for messages. ...................................................................... core,userportal,webadmin: added singular variant for messages. changed messages not co contain plurals when dealing with sole item Change-Id: I2410b2c75380a78ffc24d142987e684182bf5dc9 Bug-Url: https://bugzilla.redhat.com/997197 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/RemoveProviderValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 136 insertions(+), 46 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2410b2c75380a78ffc24d142987e684182bf5dc9 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Fix _validName return
by sbonazzo＠redhat.com 03 Feb '15

03 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Fix _validName return ...................................................................... packaging: setup: Fix _validName return Fix regression introduced in http://gerrit.ovirt.org/36307 Change-Id: I20d883c3021f8babbf58ccf45b6306cfd421a0c2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20d883c3021f8babbf58ccf45b6306cfd421a0c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: fix NPE on ReloadConfigurationsCommand
by juan.hernandez＠redhat.com 03 Feb '15

03 Feb '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: fix NPE on ReloadConfigurationsCommand ...................................................................... restapi: fix NPE on ReloadConfigurationsCommand org.ovirt.engine.api.model.API is not registered in org.ovirt.engine.api.utils.LinkHelper#TYPES. This situation produces produces NPE. Added precondition test and return 'null', which is sufficient since API resource does not have related Collection and it's not an entity. Change-Id: I70fd6b084a33bc7770de245c0001d3eefbb58b66 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70fd6b084a33bc7770de245c0001d3eefbb58b66 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0