Change in ovirt-engine[master]: core: VmsMonitoring - remove unmodifiableList
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: VmsMonitoring - remove unmodifiableList
......................................................................
core: VmsMonitoring - remove unmodifiableList
VmsMonitoring -> getVmLunDisksToSave:
remove 'Collections.unmodifiableList' to avoid
UnsupportedOperationException when adding an item
to the list (done on VmAnalyzer -> updateLunDisks).
Change-Id: I48cd27d7ba2f1fe658f5c2cb308e0ba9dbe1c798
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48cd27d7ba2f1fe658f5c2cb308e0ba9dbe1c798
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: db: increase gap of data files
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db: increase gap of data files
......................................................................
db: increase gap of data files
As more data is inserted in each version there might be cases in which
we have to label file between existing XXXX and YYYY to align with
object dependency
The current XXXX 4 digit prefix may not be sufficient for the long term.
This patch replace each XXXX prefix with XXXX0 in order to create more
room for future insertion files
Change-Id: Ibc9a62e1398f7a0fa30125c76d699837c746fbba
Signed-off-by: emesika <emesika(a)redhat.com>
---
R packaging/dbscripts/data/00000_insert_schema_version.sql
R packaging/dbscripts/data/00100_insert_users.sql
R packaging/dbscripts/data/00200_insert_ad_groups.sql
R packaging/dbscripts/data/00300_insert_storage_pool.sql
R packaging/dbscripts/data/00400_insert_vds_groups.sql
R packaging/dbscripts/data/00500_insert_roles.sql
R packaging/dbscripts/data/00600_insert_permissions.sql
R packaging/dbscripts/data/00700_insert_roles_groups.sql
R packaging/dbscripts/data/00800_insert_images.sql
R packaging/dbscripts/data/00900_insert_network.sql
R packaging/dbscripts/data/01000_insert_network_cluster.sql
R packaging/dbscripts/data/01100_insert_vm_static.sql
R packaging/dbscripts/data/01200_insert_vm_device.sql
R packaging/dbscripts/data/01300_insert_vm_ovf_generations.sql
R packaging/dbscripts/data/01400_insert_action_version_map.sql
R packaging/dbscripts/data/01500_insert_event_map.sql
R packaging/dbscripts/data/01600_insert_dwh_history_timekeeping.sql
17 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc9a62e1398f7a0fa30125c76d699837c746fbba
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[master]: core: add query for getting vms from external provider
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: add query for getting vms from external provider
......................................................................
core: add query for getting vms from external provider
Change-Id: I870043d8c392e6cd60d133a8701fa756b6b6a079
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsFromExternalProviderQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmsFromExternalProviderParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsFromExternalProviderVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
14 files changed, 358 insertions(+), 1 deletion(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I870043d8c392e6cd60d133a8701fa756b6b6a079
Gerrit-PatchSet: 50
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-iso-uploader[master]: upload: getting host address for local iso domain on remote ...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: upload: getting host address for local iso domain on remote host
......................................................................
upload: getting host address for local iso domain on remote host
Correclty getting the host address for local iso domain on remote
host to be able to upload via SSH
Change-Id: I9f408f842225709b5b3c89a709354a845ad2003e
Bug-Url: https://bugzilla.redhat.com/1097789
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/__main__.py
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/37400
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f408f842225709b5b3c89a709354a845ad2003e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-iso-uploader[master]: ux: fixing a glich on the progress bar for small files
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: fixing a glich on the progress bar for small files
......................................................................
ux: fixing a glich on the progress bar for small files
Fixing a glich on the progress bar for files that are
smaller than a chunk.
Change-Id: Ib1eccdacba0107327f518b2b561f13f13fde0c2b
Bug-Url: https://bugzilla.redhat.com/1077235
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1eccdacba0107327f518b2b561f13f13fde0c2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Add Unit-Tests for 'Start' VDS flow
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: core: Add Unit-Tests for 'Start' VDS flow
......................................................................
core: Add Unit-Tests for 'Start' VDS flow
Change-Id: I54708add95700294594beb16bbf5c4702f2754ca
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceVdsBaseCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/StartVdsCommandTest.java
3 files changed, 325 insertions(+), 82 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54708add95700294594beb16bbf5c4702f2754ca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Add unit-tests for fence-proxy selection
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: core: Add unit-tests for fence-proxy selection
......................................................................
core: Add unit-tests for fence-proxy selection
Change-Id: I95f00b38c78ef7b6a72ee141d9090bf5e60eb679
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceProxyLocatorTest.java
2 files changed, 333 insertions(+), 1 deletion(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95f00b38c78ef7b6a72ee141d9090bf5e60eb679
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Add Test for FenceValidator
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: core: Add Test for FenceValidator
......................................................................
core: Add Test for FenceValidator
Change-Id: I976322361dbc97b0d4588c302e8403e42d0e0bce
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/FenceValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java
2 files changed, 178 insertions(+), 3 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I976322361dbc97b0d4588c302e8403e42d0e0bce
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: webadmin: Enabling ISO & Export path editing.
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Enabling ISO & Export path editing.
......................................................................
webadmin: Enabling ISO & Export path editing.
The system currently enables to edit ISO and Export domains' path at
backend. This patch adds the posibility to do that also through the
webadmin.
Change-Id: I0a57fa74c4bbd41272f119925fa7fef9a67b267d
Bug-Url: https://bugzilla.redhat.com/1099412
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
2 files changed, 13 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit http://gerrit.ovirt.org/37336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a57fa74c4bbd41272f119925fa7fef9a67b267d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: if next run configuration exists the edit VM may l...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: if next run configuration exists the edit VM may load forever
......................................................................
webadmin: if next run configuration exists the edit VM may load forever
If the nextRunConfiguration exists, the model.stopProgress(); was not called in
updateVirtioScsi() which caused the progress bar to show forever.
Change-Id: Iea63c3557d5b962d56ba2c0e1f97356f41474aef
Bug-Url: https://bugzilla.redhat.com/1180038
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Daniel Erez: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/36786
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea63c3557d5b962d56ba2c0e1f97356f41474aef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months