February 2015 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: packaging: setup: Make reports heap size configurable
by sradco＠redhat.com 05 Feb '15

05 Feb '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Make reports heap size configurable ...................................................................... packaging: setup: Make reports heap size configurable Set heap min/max by default to max(1GB, 25% of RAM). Allow configuring by env. Existing conf - by setup on upgrades or manually by user - is kept as-is. Change-Id: I021dbb42139adb99862d26038d2ab3fba7e7fb94 Bug-Url: https://bugzilla.redhat.com/1188972 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/constants.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/java.py 2 files changed, 144 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I021dbb42139adb99862d26038d2ab3fba7e7fb94 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Correct VDS geo-rep status
by kmayilsa＠redhat.com 05 Feb '15

05 Feb '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Correct VDS geo-rep status ...................................................................... engine: Correct VDS geo-rep status As vdsm patch went through refactoring, fixing the engine code to reflect this - http://gerrit.ovirt.org/18414 Change-Id: I7449d6a786f3bae55752eb25f36f6210448cdd83 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionListVDSCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionStatusVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 16 files changed, 139 insertions(+), 132 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Sahina Bose: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7449d6a786f3bae55752eb25f36f6210448cdd83 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fixed refresh command for geo-rep sessions
by kmayilsa＠redhat.com 05 Feb '15

05 Feb '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Fixed refresh command for geo-rep sessions ...................................................................... engine: Fixed refresh command for geo-rep sessions Fixed refresh command to extend from GlusterVolumeCommandBase so that the cluster id is properly set. Change-Id: I4ec7f2aa03164371b777fbd8631e77be77dd5d72 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGeoRepSessionsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: anmolbabu: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ec7f2aa03164371b777fbd8631e77be77dd5d72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBase, Config values cleanup.
by tnisan＠redhat.com 05 Feb '15

05 Feb '15

Tal Nisan has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBase, Config values cleanup. ...................................................................... core: StorageHandlingCommandBase, Config values cleanup. getSupportedStorageFormats function in StorageHandlingCommandBase is out of date since format matching to storage needs to be done with VersionStorageFormatUtil. Hence the config value SupportedStorageFormats that was used by that function was also removed. Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 6 files changed, 3 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed incorrect value change handler
by tjelinek＠redhat.com 05 Feb '15

05 Feb '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: removed incorrect value change handler ...................................................................... webadmin: removed incorrect value change handler The same handler has been registerd both on the ListModelTypeAheadListBox and on BaseListModelSuggestBox (using the addValueChangeHandler). The deleted one had no meaning - it's logic is handled by the SuggestBoxFocusHandler but in some cases kicked in sooner than the one in BaseListModelSuggestBox hiding the suggestions sooner than the correct handler was able to use them. Change-Id: I203023384e0d29671220d9ebd2ed7c4fd4b67da3 Bug-Url: https://bugzilla.redhat.com/1166022 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I203023384e0d29671220d9ebd2ed7c4fd4b67da3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: fedora 20: enable virt-preview
by sbonazzo＠redhat.com 04 Feb '15

04 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fedora 20: enable virt-preview ...................................................................... fedora 20: enable virt-preview enable virt-preview on fedora 20 for allowing vdsm to support 3.6 cluster compatibility Change-Id: I107682c5f028e750c940b3b7faaa97169ed44b7a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master/configure.ac M ovirt-release-master/ovirt-f20-deps.repo.in M ovirt-release-master/ovirt-release-master.spec.in 3 files changed, 13 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I107682c5f028e750c940b3b7faaa97169ed44b7a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: pythonlib: access to TempDir
by piotr.kliczewski＠gmail.com 04 Feb '15

04 Feb '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: pythonlib: access to TempDir ...................................................................... packaging: pythonlib: access to TempDir Restrict access to TempDir. Change-Id: Ia034f1b5a770a1eedd274d6e0a885d86f1eefde4 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 1046c4b7841c374827f5a86ed8a527d3d30541a5) --- M packaging/pythonlib/ovirt_engine/service.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia034f1b5a770a1eedd274d6e0a885d86f1eefde4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: pythonlib: access to TempDir
by sbonazzo＠redhat.com 04 Feb '15

04 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: pythonlib: access to TempDir ...................................................................... packaging: pythonlib: access to TempDir Restrict access to TempDir. Change-Id: Ia034f1b5a770a1eedd274d6e0a885d86f1eefde4 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/service.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia034f1b5a770a1eedd274d6e0a885d86f1eefde4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: vdsm: use vdscli instead of vdsClient for storage operations
by sbonazzo＠redhat.com 04 Feb '15

04 Feb '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: use vdscli instead of vdsClient for storage operations ...................................................................... vdsm: use vdscli instead of vdsClient for storage operations Dropping vdsClient usage in favor of vdscli API for storage operations. vdsClient includes a non modificable 60 secs timeout with could not be enough on long storage operations. Change-Id: Iec7db5ccf55752266fa668a8b1e8f914cd632521 Bug-Url: https://bugzilla.redhat.com/1173638 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/mixins.py M src/ovirt_hosted_engine_setup/tasks.py M src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py 9 files changed, 76 insertions(+), 78 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec7db5ccf55752266fa668a8b1e8f914cd632521 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: TemplateComparator implements Serializable
by tjelinek＠redhat.com 04 Feb '15

04 Feb '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: TemplateComparator implements Serializable ...................................................................... userportal: TemplateComparator implements Serializable Serializable interface added to TemplateComparator as reaction to coverity.com scan: CID 1264397: Se: Incorrect definition of Serializable class (FB.SE_COMPARATOR_SHOULD_BE_SERIALIZABLE) Change-Id: I92e5fcc276e29505414dc65868a6054254e05924 Bug-Url: https://bugzilla.redhat.com/1169373 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified -- To view, visit http://gerrit.ovirt.org/37279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92e5fcc276e29505414dc65868a6054254e05924 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0