March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add AbstractCinderDiskCommandCallback
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add AbstractCinderDiskCommandCallback ...................................................................... core: add AbstractCinderDiskCommandCallback Adding an abstract class for CinderDisk operations callbacks. Change-Id: I65250cd22fb5471cc3911279b328143460074f87 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AbstractCinderDiskCommandCallback.java 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65250cd22fb5471cc3911279b328143460074f87 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce CinderBroker
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: introduce CinderBroker ...................................................................... core: introduce CinderBroker Introducing CinderBroker class which handles all invocations of Cinder sdk actions (e.g. createVolume/deleteVolume/etc). The CinderBroker adds VdcBllErrors.CINDER_ERROR to executeFailedMessages in case of an OpenStackResponseException. This generic error is part of VdsmErrors as it relates to errors that may occur in the execute phase. The messages are sent in plain string (as opposed to codes), hence, translation is not applicable. Change-Id: If71305412188be95dc88bc0d8646958a3d3e6aef Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 6 files changed, 50 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If71305412188be95dc88bc0d8646958a3d3e6aef Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: handle Cinder in DiskRowMapper
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: handle Cinder in DiskRowMapper ...................................................................... core: handle Cinder in DiskRowMapper For CinderDisks, mapRow using CinderDiskRowMapper in DiskRowMapper. Change-Id: I5944ad8ec32849769b557d113c7ab5ecc21df58c Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5944ad8ec32849769b557d113c7ab5ecc21df58c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding CinderDiskRowMapper
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: adding CinderDiskRowMapper ...................................................................... core: adding CinderDiskRowMapper Adding CinderDiskRowMapper to DiskImageDAODbFacadeImpl. Change-Id: I755f75f32bcada9e6c446c86b1d7109fb94768ad Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java 1 file changed, 40 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I755f75f32bcada9e6c446c86b1d7109fb94768ad Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: CinderDisk business entity
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: CinderDisk business entity ...................................................................... core: CinderDisk business entity Introducing CinderDisk business entity: * Extends DiskImage. * Snapshots currently defined as unsupported. Change-Id: Ibd6966ffb446f9120965237c573cf64594fd1136 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderDisk.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd6966ffb446f9120965237c573cf64594fd1136 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added Cinder key to DiskStorageType enum
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: added Cinder key to DiskStorageType enum ...................................................................... core: added Cinder key to DiskStorageType enum Adding Cinder key to DiskStorageType enum. Change-Id: Ief1e28c4f57776e496666ac1e0bed63b74d28505 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskStorageType.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief1e28c4f57776e496666ac1e0bed63b74d28505 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add cinder_volume_type to base_disks table
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add cinder_volume_type to base_disks table ...................................................................... core: add cinder_volume_type to base_disks table Adding cinder_volume_type column to base_disks table to represent a volume type defined in Cinder (e.g. ceph/lvm/etc). * Updated base_disks_sp: InsertBaseDisk / UptdateBaseDisk * Updated create_views: images_storage_domain_view / vm_images_view / all_disks_including_snapshots * Added 'cinderVolumeType' String to BaseDisk business entity. Change-Id: Ib2be3d75e50ae72062d6222ad917b578176a6590 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M packaging/dbscripts/base_disks_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1140_add_cinder_volume_type_column_to_base_disks.sql 5 files changed, 31 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2be3d75e50ae72062d6222ad917b578176a6590 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add disk_storage_type to base_disks table
by derez＠redhat.com 24 Mar '15

24 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add disk_storage_type to base_disks table ...................................................................... core: add disk_storage_type to base_disks table Adding disk_storage_type column to base_disks table in order to support multiple types (i.e. image/lun/cinder). * Updated base_disks_sp: InsertBaseDisk / UpdateBaseDisk * Updated create_views: images_storage_domain_view / vm_images_view / all_disks_including_snapshots Change-Id: Ib910f991d060a8b8b0372c4b252501562fc5757a Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M packaging/dbscripts/base_disks_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1130_add_disk_storage_type_column_to_base_disks.sql 6 files changed, 43 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib910f991d060a8b8b0372c4b252501562fc5757a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed useless override in ImportVmFromExportDoma...
by awels＠redhat.com 24 Mar '15

24 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: removed useless override in ImportVmFromExportDomainPopupView ...................................................................... webadmin: removed useless override in ImportVmFromExportDomainPopupView Change-Id: Ibb94c3fc585808be4e451c2170b8df8d7f9ea6d6 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb94c3fc585808be4e451c2170b8df8d7f9ea6d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: rename StatusCompositeCellWithElementId
by awels＠redhat.com 24 Mar '15

24 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: rename StatusCompositeCellWithElementId ...................................................................... userportal, webadmin: rename StatusCompositeCellWithElementId Rename StatusCompositeCellWithElementId -> StatusCompositeCell no code changes -- just a rename. Change-Id: I60d953b65fc0d855103c91b527c01cdf264d6678 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60d953b65fc0d855103c91b527c01cdf264d6678 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0