March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Removed unused VdcBllMessages
by amureini＠redhat.com 24 Mar '15

24 Mar '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Removed unused VdcBllMessages ...................................................................... engine: Removed unused VdcBllMessages Change-Id: Ib91241ff4b73d299c35a3616cfdfb93c98012584 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 0 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/37209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib91241ff4b73d299c35a3616cfdfb93c98012584 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Corrected a UI validation while volume snapshot cr...
by kmayilsa＠redhat.com 24 Mar '15

24 Mar '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Corrected a UI validation while volume snapshot creation ...................................................................... webadmin: Corrected a UI validation while volume snapshot creation Change-Id: I8916803b86901e2ecd5b4d8ed208b8822135bf46 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8916803b86901e2ecd5b4d8ed208b8822135bf46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: openstack volume providers root collection
by derez＠redhat.com 23 Mar '15

23 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: openstack volume providers root collection ...................................................................... restapi: openstack volume providers root collection Introducing openstack volume providers resources: /api/openstackvolumeproviders * Support GET/POST/DELETE/UPDATE * Added openstack_volume_provider(s) elements to api.xsd. * Updated rsdl_metadata accordingly. * Updated FeaturesHelper. Feature Page: http://www.ovirt.org/Features/Cinder_Integration Change-Id: I89d2e9d975750d2ec22599079603bd48cff2603e Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeProviderResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeProvidersResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProvidersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProvidersResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackVolumeProviderMapper.java 14 files changed, 748 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/39003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d2e9d975750d2ec22599079603bd48cff2603e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add support for special chars in search
by emesika＠redhat.com 23 Mar '15

23 Mar '15

Eli Mesika has submitted this change and it was merged. Change subject: core: add support for special chars in search ...................................................................... core: add support for special chars in search Enable to search non AD searches using wildcards. Change-Id: Ie609699f7d6246e444f8628c0b5a612ef89aeb9f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1062351 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Liran Zelkha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie609699f7d6246e444f8628c0b5a612ef89aeb9f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: osinfo properties - added 3.6 values
by derez＠redhat.com 23 Mar '15

23 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: osinfo properties - added 3.6 values ...................................................................... core: osinfo properties - added 3.6 values As 3.6 cluster version has been recently introduced, appropriate values should be manually added explicitly (similar to Change-Id: I82acba49f080e9250481b0a62ac66817091a1755). Note: This should be a temporary solution until implementation of cluster versions inheritance in OsInfo infrastructure; covered by: https://bugzilla.redhat.com/show_bug.cgi?id=1056577. Change-Id: Id2df0b1ae56e38d26613956581c084b18f16bb5e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M packaging/conf/osinfo-defaults.properties 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Roy Golan: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2df0b1ae56e38d26613956581c084b18f16bb5e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix VdcOptionDAOTest.testGetWithInvalidId
by masayag＠redhat.com 23 Mar '15

23 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix VdcOptionDAOTest.testGetWithInvalidId ...................................................................... engine: fix VdcOptionDAOTest.testGetWithInvalidId The max configValue id exceeded 717, changed the "INVALID_ID' in the test to -1, it is for sure invalid. Change-Id: I0ec8215ec8128a873b6e76709842d9bacbf3fbf7 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ec8215ec8128a873b6e76709842d9bacbf3fbf7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: REST API login popup
by awels＠redhat.com 23 Mar '15

23 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: REST API login popup ...................................................................... webadmin: REST API login popup - The REST API login popup would appear when one of the following was true: 1 The engine session hard limit was reached (10 hours) and the REST API ping would happen before a refresh that would cause a logout. 2 The REST API ping would not happen due to it detecting that the refresh flag was not set, however the engine would internally set the refresh on a sub query. This causes the REST api http session to expire and on a sub sequent ping would cause the popup to appear. - This patch fixes 1. We take the hard limit into account and if we are close enough to the hard limit the REST API ping is disabled causing the natural logout of the webadmin UI to happen. Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1175313 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/EngineSessionTimeoutData.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 5 files changed, 53 insertions(+), 16 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Append Numa dynamic data to static data
by tnisan＠redhat.com 23 Mar '15

23 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Append Numa dynamic data to static data ...................................................................... engine: Append Numa dynamic data to static data Numa statistics were created into an empty VdsNumaNode and written to the DB. The correction append Numa statistics into existing VdsNumaNode static information. This is relevant only while doing capabilities refresh. Othewise it is OK to store VdsNumaNode with only statistical data. Bug-Url: https://bugzilla.redhat.com/1177154 Change-Id: I71a4b71348127aa479b13cb8ad5e39685252b518 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 26 insertions(+), 6 deletions(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71a4b71348127aa479b13cb8ad5e39685252b518 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: packaging: setup: avoid setting AsyncTaskZombieTaskLifeInMin...
by piotr.kliczewski＠gmail.com 23 Mar '15

23 Mar '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: avoid setting AsyncTaskZombieTaskLifeInMinutes to 0 ...................................................................... packaging: setup: avoid setting AsyncTaskZombieTaskLifeInMinutes to 0 Avoid setting AsyncTaskZombieTaskLifeInMinutes to 0 otherwise every task is always considered a zombie. Changing a method name and a description according to that. Change-Id: I0c4a802f3a40e2192f55caa11d05a7c6865323d5 Bug-Url: https://bugzilla.redhat.com/1161012 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 4 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/38991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c4a802f3a40e2192f55caa11d05a7c6865323d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: dbutils: Enable unlock utility handle all entities
by emesika＠redhat.com 23 Mar '15

23 Mar '15

Eli Mesika has submitted this change and it was merged. Change subject: dbutils: Enable unlock utility handle all entities ...................................................................... dbutils: Enable unlock utility handle all entities This patch enables engine-setup to unlock all entities in one call. This is done in order to prevent upgrade of engine and database while some entities are still locked. Change-Id: I494dece6ba871727750f3fccacd95490294bea6e Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/unlock_entity.sh 2 files changed, 52 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I494dece6ba871727750f3fccacd95490294bea6e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0