March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddProviderCommand - validation for specific types
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: AddProviderCommand - validation for specific types ...................................................................... core: AddProviderCommand - validation for specific types * Verify provider existence and support. * Invoke validateAddProvider method to support specific validate implementations (Cinder/Glance/etc). Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2f7130fcf3904ac771c403f9c81976140659c33 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProviderValidator - validateAddProvider
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ProviderValidator - validateAddProvider ...................................................................... core: ProviderValidator - validateAddProvider Added validateAddProvider which should include specific validations that each sub-class can override and implement. I.e. each proxy type (Image/Volume/etc) could now have its own set of validations. Change-Id: I84c189cd379e1abdc2c0ab2fa621567f40583113 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c189cd379e1abdc2c0ab2fa621567f40583113 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdcBllMessages - adding unsupported provider error key
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: VdcBllMessages - adding unsupported provider error key ...................................................................... core: VdcBllMessages - adding unsupported provider error key Adding error key to VdcBllMessages for unsupported provider: ACTION_TYPE_FAILED_PROVIDER_NOT_SUPPORTED Change-Id: I10b632ab1cd08d936d5b6f2e2d4ac85965765f7e Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 15 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10b632ab1cd08d936d5b6f2e2d4ac85965765f7e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AddProviderCommand - extract to getProviderProxy
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: AddProviderCommand - extract to getProviderProxy ...................................................................... core: AddProviderCommand - extract to getProviderProxy Extract to getProviderProxy method. Change-Id: I08a1a1a4c637e4fd144dcdd36ffeffe0ab008b26 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08a1a1a4c637e4fd144dcdd36ffeffe0ab008b26 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: exclude Cinder domains from monitoring
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: exclude Cinder domains from monitoring ...................................................................... core: exclude Cinder domains from monitoring Exclude Cinder storage domains form domain monitoring (until adding an appropriate support): Altered: * storages_san_sp -> Getstorage_pool_iso_mapsByBystorage_pool_id * storages_sp -> GetStorageDomainIdsByStoragePoolIdAndStatus_rs Change-Id: If63e0156ed0c60e265d04f1dbb53f7c48b0e50cb Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M packaging/dbscripts/storages_san_sp.sql M packaging/dbscripts/storages_sp.sql 3 files changed, 10 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If63e0156ed0c60e265d04f1dbb53f7c48b0e50cb Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProviderProxyFactory - add OPENSTACK_VOLUME
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ProviderProxyFactory - add OPENSTACK_VOLUME ...................................................................... core: ProviderProxyFactory - add OPENSTACK_VOLUME Adding OPENSTACK_VOLUME to ProviderProxyFactory. Change-Id: Idc2b328afb3444f45d14afea771a85e75e43c342 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc2b328afb3444f45d14afea771a85e75e43c342 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: OpenStackVolumeProviderProxy and CINDERStorageHelper
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: OpenStackVolumeProviderProxy and CINDERStorageHelper ...................................................................... core: OpenStackVolumeProviderProxy and CINDERStorageHelper Introducing: * OpenStackVolumeProviderProxy - a proxy for handling Cinder provider actions. * CINDERStorageHelper - an helper for executing commands in Cinder SDK. Change-Id: Ie94f2f8581174cf820d908ba3b51de7564d8a0d4 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 2 files changed, 200 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie94f2f8581174cf820d908ba3b51de7564d8a0d4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AuditLogType - add CINDER_PROVIDER_ERROR
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: AuditLogType - add CINDER_PROVIDER_ERROR ...................................................................... core: AuditLogType - add CINDER_PROVIDER_ERROR Adding CINDER_PROVIDER_ERROR to AuditLogType/AuditLogMessages. This is a general error message which should be used for any exception that is sent from Cinder, hence, we could not support translation (as the messages are displayed as is). Change-Id: I22591102129eeb09d0feee0c67200e66c563d78f Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22591102129eeb09d0feee0c67200e66c563d78f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add Volume to StorageDomainType enum
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add Volume to StorageDomainType enum ...................................................................... core: add Volume to StorageDomainType enum Adding 'Volume' to StorageDomainType enum (Volume is a disk in Cinder terminology). Change-Id: Ia13aad1c0d3abc4001ba24dc2e17ce3c79c4c6ad Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainType.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38909 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia13aad1c0d3abc4001ba24dc2e17ce3c79c4c6ad Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add Cinder to StorageType enum
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add Cinder to StorageType enum ...................................................................... core: add Cinder to StorageType enum Adding 'Cinder' to StorageType enum. Change-Id: I3af65c838546c0fdd1c4f1761a4e9fdbe4df0164 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/StorageType.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3af65c838546c0fdd1c4f1761a4e9fdbe4df0164 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0