March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: adding CinderProviderValidator
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: adding CinderProviderValidator ...................................................................... core: adding CinderProviderValidator Introducing CinderProviderValidator for validations of OpenStack volume provider flows. Change-Id: Ic508913d4640a9767a415f69e567620d4ab23d67 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java 1 file changed, 69 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic508913d4640a9767a415f69e567620d4ab23d67 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding unsupported domain for datacenter error
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: adding unsupported domain for datacenter error ...................................................................... core: adding unsupported domain for datacenter error Adding error key to VdcBllMessages for unsupported cinder storage domain in data center: DATA_CENTER_CINDER_STORAGE_NOT_SUPPORTED_IN_CURRENT_VERSION Change-Id: I9536655f7713dda9dc3bc1bfa014bc76fd444c11 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9536655f7713dda9dc3bc1bfa014bc76fd444c11 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Adding error message for unsupported domain in datacenter
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: Adding error message for unsupported domain in datacenter ...................................................................... core: Adding error message for unsupported domain in datacenter Adding 'cinderProviderSupported' method to FeatureSupported. Change-Id: I65e96449d455bc6b001c8cfba028d43d0c168cc7 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65e96449d455bc6b001c8cfba028d43d0c168cc7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add CinderProviderSupported config value
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add CinderProviderSupported config value ...................................................................... core: add CinderProviderSupported config value Adding CinderProviderSupported configuration value. Change-Id: I03c2b840ca62fac180b1516693dc0ab350a17ef2 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 9 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c2b840ca62fac180b1516693dc0ab350a17ef2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProviderDaoDbFacadeImpl - add OPENSTACK_VOLUME
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ProviderDaoDbFacadeImpl - add OPENSTACK_VOLUME ...................................................................... core: ProviderDaoDbFacadeImpl - add OPENSTACK_VOLUME Handle OPENSTACK_VOLUME in provider dao mappers. Change-Id: I042eb87352ce7e48570327f609f192347dae3fc4 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I042eb87352ce7e48570327f609f192347dae3fc4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ProviderType - adding OPENSTACK_VOLUME
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ProviderType - adding OPENSTACK_VOLUME ...................................................................... core: ProviderType - adding OPENSTACK_VOLUME Adding OPENSTACK_VOLUME to ProviderType enum. Change-Id: If9424947dbb072565b61cbf820dad85f3b17ba93 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9424947dbb072565b61cbf820dad85f3b17ba93 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add OpenStackVolumeProviderProperties
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add OpenStackVolumeProviderProperties ...................................................................... core: add OpenStackVolumeProviderProperties Adding OpenStackVolumeProviderProperties for OpenStackVolumeProviderProxy usage. Change-Id: Ie70433f4c2e7b6157565bd10824d01689f6c62a8 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/OpenStackVolumeProviderProperties.java 1 file changed, 58 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/38902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie70433f4c2e7b6157565bd10824d01689f6c62a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: StoragePoolValidator - checkStoragePoolNotInStatus
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: StoragePoolValidator - checkStoragePoolNotInStatus ...................................................................... core: StoragePoolValidator - checkStoragePoolNotInStatus Validate that the storage pool is in the specified status in checkStoragePoolNotInStatus method. Change-Id: I73034eb6e0e12426a5e4713c5bf8207bdb0ddad1 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StoragePoolValidator.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73034eb6e0e12426a5e4713c5bf8207bdb0ddad1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ProviderProxy interface - getProviderValidator
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: ProviderProxy interface - getProviderValidator ...................................................................... core: ProviderProxy interface - getProviderValidator ProviderProxy interface: adding 'getProviderValidator' signature in order to support a specific provider validator for each provider proxy type (will be used for CinderProviderValidator). Change-Id: Ifc062d7b62d6769afa97d100e239a313f72b3c4b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 5 files changed, 40 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc062d7b62d6769afa97d100e239a313f72b3c4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding AbstractOpenStackStorageProviderProxy
by derez＠redhat.com 22 Mar '15

22 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: adding AbstractOpenStackStorageProviderProxy ...................................................................... core: adding AbstractOpenStackStorageProviderProxy * Introduced AbstractOpenStackStorageProviderProxy as an abstract parent class for storage provider proxies (Glance/Cinder). * OpenStackImageProviderProxy now extends the new abstract class. * OpenStackImageProviderProxy -> onModification: use getProviderStorageDomain method. Change-Id: Ibff05e2a00e252c30f910e5563c7eda0eb285196 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 2 files changed, 143 insertions(+), 89 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibff05e2a00e252c30f910e5563c7eda0eb285196 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0