Change in ovirt-engine[master]: engine: create/update host_nic_vfsConfig according to HostDe...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: create/update host_nic_vfsConfig according to HostDevListByCaps
......................................................................
engine: create/update host_nic_vfsConfig according to HostDevListByCaps
Change-Id: I60ab755a75d93d4bafa5be984b267104f4636197
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java
1 file changed, 95 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37386
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60ab755a75d93d4bafa5be984b267104f4636197
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: engine: Introducing GetAllVfsConfigByHostIdQuery
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Introducing GetAllVfsConfigByHostIdQuery
......................................................................
engine: Introducing GetAllVfsConfigByHostIdQuery
The query returns all the vfsConfigs of the host.
Change-Id: I7a8579a0356e2c2ac8cd77e149f74bc4aead6dfc
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 70 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/36203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a8579a0356e2c2ac8cd77e149f74bc4aead6dfc
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: engine: Add HostNicVfsConfigDao to BllCDIAdapter
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add HostNicVfsConfigDao to BllCDIAdapter
......................................................................
engine: Add HostNicVfsConfigDao to BllCDIAdapter
It is needed by HostNicVfsConfigHelperImpl.
Change-Id: I19d4908732b1ac37845e39fb260d80a5a6d71b90
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39130
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19d4908732b1ac37845e39fb260d80a5a6d71b90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: remove disk as internal command
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove disk as internal command
......................................................................
core: remove disk as internal command
Add a constructor for RemoveDiskCommand that also gets CommandContext so
we will be able to invoke it as internal command.
Change-Id: Id04137c25015e37a08cb17c5eddd7fb523bcc7b0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/38553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id04137c25015e37a08cb17c5eddd7fb523bcc7b0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: engine: Add query for retrieving system provider
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Add query for retrieving system provider
......................................................................
engine: Add query for retrieving system provider
The query retrieves the provider which is associated by
the ovirt-engine server. The Foreman providers within
the system are scanned for having a content host with the
same host name as resolved for the ovirt-engine server.
Dynamic scanning will reduce the complexity of managing
external resource id for the host which represents the
ovirt-engine server and maintaining it.
Change-Id: I22bbb146a94c3f93cf5134f5f2e6d509f303c585
Bug-Url: https://bugzilla.redhat.com/1157377
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetSystemProviderQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22bbb146a94c3f93cf5134f5f2e6d509f303c585
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: engine: Use hasItem matcher to verify nic exists
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use hasItem matcher to verify nic exists
......................................................................
engine: Use hasItem matcher to verify nic exists
Change-Id: I1438626bbac102a55cab9808daa3b5465f7ecebc
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/39124
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1438626bbac102a55cab9808daa3b5465f7ecebc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: restapi: made sure only the supported template entities are ...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: made sure only the supported template entities are copied
......................................................................
restapi: made sure only the supported template entities are copied
The blank template is now editable. It is not connected to any cluster (similar
to instance types) and it supportrs all options from the highest cluster
version.
When a VM is created from this template in the older cluster, it is
important not to copy fields which are not supported on the target cluster.
This is not relevant for the VM pools since the pools can be created only from
non-blan templates.
Feature Page: www.ovirt.org/Features/Blank_to_Defaults
Change-Id: I7430bca85b95ddf97eaa93abbcdf13885e017f9e
Bug-Url: https://bugzilla.redhat.com/1130174
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/VmMapperMockConfigUtils.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
6 files changed, 96 insertions(+), 39 deletions(-)
Approvals:
Tomas Jelinek: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38008
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7430bca85b95ddf97eaa93abbcdf13885e017f9e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: frontend: made the blank template editable
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: made the blank template editable
......................................................................
frontend: made the blank template editable
Behavior:
- in template tab the Blank template can be edited now (can not be deleted)
- the cluster level of Blank template is the highest
- when creating a VM from the Blank template, only the parts which are
supported on the cluster level on which the VM is created are taken from the
Blank template
Notable implementation details:
- a new child of UnitVmModel the BlankTemplateModel has been created
- a new method "supportedForUnitVmModel" has been added to the
AsyncDataProvider
- the code common to ExistingBlankTemplateModelBehavior and
ExistingInstanceTypeModelBehavior has been extracted to
ExistingNonClusterModelBehavior (e.g. the class containing logic common to
entities which are not connected to any cluster)
- code common to NewInstanceTypeModelBehavior and
ExistingNonClusterModelBehavior has been extracted to
NonClusterModelBehaviorBase
Feature Page: www.ovirt.org/Features/Blank_to_Defaults
Bug-Url: https://bugzilla.redhat.com/1130174
Change-Id: I400401b8e110b4cd10404f6df7c8f8ea4cd56093
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateEditPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonVmBaseToUnitBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreUnitToVmBaseBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/SerialNumberPolicyVmBaseToUnitBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/BlankTemplateModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ExistingBlankTemplateModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmFromTemplateModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingNonClusterModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewInstanceTypeModelBehavior.java
R frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmTest.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBaseTest.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehaviorTest.java
24 files changed, 547 insertions(+), 209 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I400401b8e110b4cd10404f6df7c8f8ea4cd56093
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: core: enable editing the watchdog for blank template
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: enable editing the watchdog for blank template
......................................................................
core: enable editing the watchdog for blank template
Since the blank template is editable, also the watchdog has to be editable on it
Feature Page: www.ovirt.org/Features/Blank_to_Defaults
Bug-Url: https://bugzilla.redhat.com/1130174
Change-Id: Icdaa438ff674dab599d04c94e97724e8c51700f9
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java
4 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdaa438ff674dab599d04c94e97724e8c51700f9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: core: enabled the custom properties to be set for blank temp...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: enabled the custom properties to be set for blank template
......................................................................
core: enabled the custom properties to be set for blank template
Since the blank template can be edited, also the custom properties has to be
settable for it.
Feature Page: www.ovirt.org/Features/Blank_to_Defaults
Bug-Url: https://bugzilla.redhat.com/1130174
Change-Id: I4bcd5c92f8b1b6f0055a0d7552a8d8250a417ac7
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bcd5c92f8b1b6f0055a0d7552a8d8250a417ac7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month