Change in ovirt-engine[master]: userportal, webadmin: multiple login messages
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: multiple login messages
......................................................................
userportal,webadmin: multiple login messages
- When the backend would return multiple login failure
messages (for instance with the password expired). All
messages after the first would be discarded. This would
lead to configured messages to not be displayed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157773
Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml
7 files changed, 107 insertions(+), 79 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38214
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: packaging: setup: allow tuning dump/restore
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: allow tuning dump/restore
......................................................................
packaging: setup: allow tuning dump/restore
The default is same as today - custom format, -j 2, no filter.
Currently no interaction. Values used are written to the answer file,
which can be edited manually:
OVESETUP_DB/dumper=str:VALUE
where VALUE is one of:
pg_plain
pg_custom
OVESETUP_DB/filter=VALUE
where VALUE is one of:
str:gzip
str:bzip2
str:xz
none:None
OVESETUP_DB/restoreJobs=str:NUM
where NUM is the number of concurrent restore jobs, used only if
dumper is pg_custom and filter is None.
Currently only backup/restore done during engine-setup are affected.
Note that the bug 1188132 mentioned below talks about engine-backup.
This will be possible while working on bug 1064503, which talks about
rewriting engine-backup using the engine-setup framework.
Change-Id: I99de636d4da15a253f2186084902f0f133603f4d
Related-To: https://bugzilla.redhat.com/1188132
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/database.py
M packaging/setup/ovirt_engine_setup/engine_common/postgres.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py
5 files changed, 341 insertions(+), 125 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
Objections:
oVirt Jenkins CI Server: Fails
--
To view, visit https://gerrit.ovirt.org/39190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99de636d4da15a253f2186084902f0f133603f4d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: spec: use a macro for patternfly1 rpm
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: spec: use a macro for patternfly1 rpm
......................................................................
packaging: spec: use a macro for patternfly1 rpm
On RHEV patternfly1 is named rcue1.
Reducing rebase impact by using a macro instead of
using the package name.
Change-Id: Idd187823d78855db8912033da6ab74875450e57f
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 2556ecceee5910f1201dc8b852bb23fae2b1d9d6)
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Greg Sheremeta: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd187823d78855db8912033da6ab74875450e57f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: packaging: setup: fix manual firewalld instructions
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fix manual firewalld instructions
......................................................................
packaging: setup: fix manual firewalld instructions
Change-Id: I8b4021ae2a874ae0288c05ff94b3cb24156b403e
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_firewalld.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/39390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b4021ae2a874ae0288c05ff94b3cb24156b403e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Added flag GlusterVolumeSnapshotSupported
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Added flag GlusterVolumeSnapshotSupported
......................................................................
gluster: Added flag GlusterVolumeSnapshotSupported
Added a flag GlusterVolumeSnapshotSupported which tells if gluster
volume snapshot feature is enabled for the said cluster compatibility
version.
Change-Id: I235824105467201e10802b7893e9f1e911adc49b
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I235824105467201e10802b7893e9f1e911adc49b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: DAO for volume snapshot maintenance
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: DAO for volume snapshot maintenance
......................................................................
gluster: DAO for volume snapshot maintenance
Introduced DAO for gluster volume snapshot maintenance.
Change-Id: Id60902aad02b852773ad398aaac9bad8ed7793ab
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/gluster_volume_snapshot_sp.sql
7 files changed, 583 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id60902aad02b852773ad398aaac9bad8ed7793ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-hosted-engine-setup[master]: storage: avoid tracebacks mixing storage domains
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: avoid tracebacks mixing storage domains
......................................................................
storage: avoid tracebacks mixing storage domains
Avoid traceback like:
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
line 340, in _getExistingDomain
domain_info['remotePath']
File
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/storage/storage.py",
line 283, in _removeNFSTrailingSlash
if len(nfspath[1]) > 1:
IndexError: list index out of range
when checking NFS storage domains on a VDSM instance running with a
non NFS/Gluster domain already attached.
Change-Id: I4d653a3ab0b6bb324a9380ee351307ca7ebb34bc
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d653a3ab0b6bb324a9380ee351307ca7ebb34bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: packaging: spec: use a macro for patternfly1 rpm
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: use a macro for patternfly1 rpm
......................................................................
packaging: spec: use a macro for patternfly1 rpm
On RHEV patternfly1 is named rcue1.
Reducing rebase impact by using a macro instead of
using the package name.
Change-Id: Idd187823d78855db8912033da6ab74875450e57f
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39394
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd187823d78855db8912033da6ab74875450e57f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Entities for gluster volume snapshot
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Entities for gluster volume snapshot
......................................................................
gluster: Entities for gluster volume snapshot
Entities changes for gluster volume snapshot feature in oVirt.
Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterSnapshotStatus.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfig.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotEntity.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_05_1260_add_gluster_volume_snapshot_tables.sql
5 files changed, 282 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: packaging: setup: raising on invalid application mode values
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: raising on invalid application mode values
......................................................................
packaging: setup: raising on invalid application mode values
It was treating every invalid application mode values as
virtOnly. Checking it for a more consistent behavior.
The default value for ApplicationMode at DB creation is
AllModes = 255; making it more explicit.
Change-Id: Ic47e171ddc76a9881e4a915f62dbae762a72f9f8
Bug-Url: https://bugzilla.redhat.com/1149575
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
1 file changed, 26 insertions(+), 20 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39094
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic47e171ddc76a9881e4a915f62dbae762a72f9f8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months