Change in ovirt-engine[master]: engine: remove produceLogger method (take 2)
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: remove produceLogger method (take 2)
......................................................................
engine: remove produceLogger method (take 2)
Logger is instanciated statically by every class.
Having that as a CDI bean is redundant.
Note: Please do not revert this change without specifying
a good reason for that.
Change-Id: Iab86145adf4e5856287038c44cd7117564291695
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java
1 file changed, 2 insertions(+), 20 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/38387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab86145adf4e5856287038c44cd7117564291695
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: packaging: setup: Inform the user about availability of DWH ...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Inform the user about availability of DWH and Reports
......................................................................
packaging: setup: Inform the user about availability of DWH and Reports
Change-Id: I61fb88a6430eec6b6425075df0e749644654753a
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/877224
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/advertise_dwh.py
4 files changed, 226 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61fb88a6430eec6b6425075df0e749644654753a
Gerrit-PatchSet: 28
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: moved RefreshPanel tooltip to bottom
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: moved RefreshPanel tooltip to bottom
......................................................................
userportal, webadmin: moved RefreshPanel tooltip to bottom
RefreshPanel's tooltip was hard to read with the default top
placement, so moved it to bottom placement.
Change-Id: I8ade8cf367ba1655823b2e3987f5e91fed7203bc
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/39090
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ade8cf367ba1655823b2e3987f5e91fed7203bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal: fix squished icons in basic view
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal: fix squished icons in basic view
......................................................................
userportal: fix squished icons in basic view
Change-Id: Ie5ebf25f90b72e95729a0181e9764820096b06e9
Bug-Url: https://bugzilla.redhat.com/1180112
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38998
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5ebf25f90b72e95729a0181e9764820096b06e9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: implemented ActionButton tooltips
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: implemented ActionButton tooltips
......................................................................
userportal, webadmin: implemented ActionButton tooltips
Implemented PatternFly tooltips for ActionButtons. By default,
ActionButtons have no tooltips. Like other tooltips, they use
the template method pattern to specify tooltips.
* Use getTooltip() to provide a tooltip when the button is
hovered over
* use getMenuItemTooltip() to provide a tooltip for when the
button is configured in a context menu
Change-Id: I856a8f31317269923cb5a519d49e3bdc25addbfc
Bug-Url: https://bugzilla.redhat.com/1140158
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractButtonDefinition.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/ActionButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/ActionButtonDefinition.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiMenuBarButtonDefinition.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipMixin.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemActionButton.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/ReportActionsHelper.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/action/WebAdminButtonDefinition.java
17 files changed, 146 insertions(+), 62 deletions(-)
Approvals:
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39067
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I856a8f31317269923cb5a519d49e3bdc25addbfc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: restapi: Enable specifying management network on cluster update
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: restapi: Enable specifying management network on cluster update
......................................................................
restapi: Enable specifying management network on cluster update
Enable specifying management network on cluster update.
That is needed when updating DC on a detached cluster and being
processed by the backend only in that case.
Change-Id: Id531ee5f21145386de2a32c6e412e808563e0326
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClusterResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/ManagementNetworkFinder.java
5 files changed, 68 insertions(+), 31 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/37749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id531ee5f21145386de2a32c6e412e808563e0326
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: show only the relevant networks in new/edit cluste...
by Gerrit Code Review
Anonymous Coward has submitted this change and it was merged.
Change subject: webadmin: show only the relevant networks in new/edit cluster dialog
......................................................................
webadmin: show only the relevant networks in new/edit cluster dialog
Show potentialy valid management networks in new/edit cluster dialog.
Change-Id: Ifdc7353b5b908a6acdcb3f4b5ae38102d5645bb6
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/IscsiBondModel.java
3 files changed, 18 insertions(+), 11 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/38043
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdc7353b5b908a6acdcb3f4b5ae38102d5645bb6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: add GetManagementNetworkCandidates query
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add GetManagementNetworkCandidates query
......................................................................
engine: add GetManagementNetworkCandidates query
Add GetManagementNetworkCandidates query
Change-Id: Iefca8da3ebfda845af1768aaa3bbc827f698cdcb
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/predicate/ExternalNetworkPredicate.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/predicate/ExternalNetworkPredicateTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
5 files changed, 205 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/38042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefca8da3ebfda845af1768aaa3bbc827f698cdcb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: fix duplicate upgrade script number
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: fix duplicate upgrade script number
......................................................................
engine: fix duplicate upgrade script number
Change-Id: Iac0d7125b6d1c55c90d62b49aceb08de2aef815d
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
R packaging/dbscripts/upgrade/03_06_1120_add_creation_date_to_permissions.sql
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac0d7125b6d1c55c90d62b49aceb08de2aef815d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: cleanup ApplicationResourcesWithLookup
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: cleanup ApplicationResourcesWithLookup
......................................................................
userportal, webadmin: cleanup ApplicationResourcesWithLookup
Changed all access to ApplicationResourcesWithLookup to be via
AssetProvider.
Change-Id: I3139e123f0ee05e1ad89b455fa5cab87988850f3
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/AbstractDynamicImage.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/OsTypeImage.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/VmTypeImage.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/AbstractMaskedVmImageColumn.java
6 files changed, 197 insertions(+), 217 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38997
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3139e123f0ee05e1ad89b455fa5cab87988850f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months