Change in ovirt-hosted-engine-setup[master]: packaging: setup: more descriptive error message for invalid...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: more descriptive error message for invalid storage domain
......................................................................
packaging: setup: more descriptive error message for invalid storage domain
Making the invalid storage domain error message a bit more descriptive
Change-Id: I45012fee44304f9bf4fe20ff2b15c32106fcfdc3
Bug-Url: https://bugzilla.redhat.com/1201196
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Yaniv Dary: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38648
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45012fee44304f9bf4fe20ff2b15c32106fcfdc3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-reports[ovirt-engine-reports-3.5]: reports: updated localization files
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: reports: updated localization files
......................................................................
reports: updated localization files
Change-Id: If93f24c28e72e81cb09a52eb71e68e89adfb1055
Bug-Url: https://bugzilla.redhat.com/1176851
Bug-Url: https://bugzilla.redhat.com/1191857
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_de.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data
4 files changed, 213 insertions(+), 213 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If93f24c28e72e81cb09a52eb71e68e89adfb1055
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-reports[master]: reports: updated localization files
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: updated localization files
......................................................................
reports: updated localization files
Change-Id: If93f24c28e72e81cb09a52eb71e68e89adfb1055
Bug-Url: https://bugzilla.redhat.com/1176851
Bug-Url: https://bugzilla.redhat.com/1191857
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_de.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_es.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data
5 files changed, 221 insertions(+), 221 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39388
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If93f24c28e72e81cb09a52eb71e68e89adfb1055
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: vds georepstatus detail fix coverity issue
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: vds georepstatus detail fix coverity issue
......................................................................
engine: vds georepstatus detail fix coverity issue
Fix issue with possible NPE uncovered by
coverity
Change-Id: Ie479af39252f4e961f04e8f38d11c0e0998f2d98
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java
1 file changed, 17 insertions(+), 15 deletions(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39380
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie479af39252f4e961f04e8f38d11c0e0998f2d98
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: VDS command to stop and delete geo-rep session
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: VDS command to stop and delete geo-rep session
......................................................................
engine: VDS command to stop and delete geo-rep session
VDS command to stop and delete geo-replication session
Change-Id: Ib9f4a32783f2b119a56873b4c1290b10f8b208c8
Bug-Url: https://bugzilla.redhat.com/1125845
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionVDSParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
12 files changed, 136 insertions(+), 1 deletion(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9f4a32783f2b119a56873b4c1290b10f8b208c8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: VDS commands for volume geo-rep status and detail
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: VDS commands for volume geo-rep status and detail
......................................................................
engine: VDS commands for volume geo-rep status and detail
VDS commands to retrieve status of geo-rep sessions
associated with a volume and geo-rep status detail
for a session
Change-Id: Id313742c9f3c036a0017fe37bd818af1bed0e081
Bug-Url: https://bugzilla.redhat.com/1138116
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepSessionVDSParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepStatusDetailVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepStatusVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
15 files changed, 432 insertions(+), 1 deletion(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39377
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id313742c9f3c036a0017fe37bd818af1bed0e081
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: core: on init - clear down vms after vms monitoring
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: on init - clear down vms after vms monitoring
......................................................................
core: on init - clear down vms after vms monitoring
currently the ResourceManager.HandleVdsFinishedInit is called after host
monitoring first cycle has ended, and it is only clearing down vms.
since the state of the vms is obtained only in the vms monitoring,
calling this after vms monitoring instead.
Change-Id: I109dcbe221526c2503f26307cef93aac8a94d689
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
3 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Roy Golan: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit https://gerrit.ovirt.org/38850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I109dcbe221526c2503f26307cef93aac8a94d689
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[master]: frontend: Phase 2: Make console clients use ConsoleOptions
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: frontend: Phase 2: Make console clients use ConsoleOptions
......................................................................
frontend: Phase 2: Make console clients use ConsoleOptions
VNC and SPICE clients now use ConsoleOptions directly. Attributes /
getters / setters in AbstractSpice / Vnc and ISpice / IVnc were cleaned.
Moreover:
- reduntant events from AbstractSpice were removed
- defective version checking mechanism was removed from AbstractSpice
and SpicePluginImpl. Now the plugin version is used only in SPICE
Active-X plugin where it makes sense.
- Spice Base URL attribute (for retrieving ActiveX Plugin CAB) is moved
closer to engine's plugin implementation (ISpicePlugin).
- cleaned unused 'guestID' attribute in Plugin.
- cleaned unused attributes 'menu','spiceCabURL' and
'spiceCabObjClassId' for XPI (Firefox) implementation.
Added ConsoleClient interface which are implemented by SPICE and VNC
clients.
Adjustments in ConsoleOptionsFrontendPersisterImpl (todo cleanup would
be nice).
Change-Id: I5a5b5b323f788bd2882984a2dce183791f72949d
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1128763
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java
R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/console/ConsoleOptionsTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/WebClientConsoleInvoker.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleClient.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
25 files changed, 262 insertions(+), 862 deletions(-)
Approvals:
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37973
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a5b5b323f788bd2882984a2dce183791f72949d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[master]: engine: Phase 1: Move console options to backend
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Phase 1: Move console options to backend
......................................................................
engine: Phase 1: Move console options to backend
This is the 1st step for generating .vv files on backend. The patch
extracts the ConsoleOptions class to backend.
Changes:
- Add ConsoleOptions class. It contains settings for both SPICE and VNC
protocols (Instead of storing/duplicating them in AbstractSpice /
AbstractVnc).
- Delegating console settings in AbstractSpice and AbstractVnc to
ConsoleOptions class (in the next follow up, console clients will use
ConsoleOptions directly).
- Extracted ticket validity timeout to constant as this parameter is not
changing. This eliminates some spaghetti code. When we need variable
timeout, this can be easily changed.
- Same goes for secure attention mapping hotkey (aka "remap
ctrl-alt-del" to "ctrl-alt-end"). It's not configurable so far so
there is no need to maintain the code which does nothing.
- unified common options between VNC and SPICE (like host, port, title
etc.).
Change-Id: Ib06110fd2b36f96f1baa55b6176240cd27a2cbf9
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1128763
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WANDisableEffects.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WanColorDepth.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
17 files changed, 553 insertions(+), 245 deletions(-)
Approvals:
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib06110fd2b36f96f1baa55b6176240cd27a2cbf9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[master]: services: add package information to configuration
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: services: add package information to configuration
......................................................................
services: add package information to configuration
as long as we use mead there is no way to pre-generate files for java
before maven process.
adding this to configuration provides trivial remedy, so that we can
inject configuration values into environment and/or read it directly
from java.
especially useful for --version and --help cmdline.
Change-Id: I595ebfa4c83d5b18cb9db3abc18a8fb61b7b74d2
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.conf.in
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.conf.in
4 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39375
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I595ebfa4c83d5b18cb9db3abc18a8fb61b7b74d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years