March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: moved ApplicationResourcesWithLookup
by awels＠redhat.com 24 Mar '15

24 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: moved ApplicationResourcesWithLookup ...................................................................... userportal, webadmin: moved ApplicationResourcesWithLookup moved ApplicationResourcesWithLookup from ClientGinjectorProvider to AssetProvider. Change-Id: I5ff5a0cef1fef2af5a4e6745639518c9e1eda32d Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/AssetProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientGinjectorProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmImageColumn.java 3 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ff5a0cef1fef2af5a4e6745639518c9e1eda32d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Version check for gluster network role feature
by sabose＠redhat.com 24 Mar '15

24 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Version check for gluster network role feature ...................................................................... engine: Version check for gluster network role feature Added a compat version check to see if the gluster network role feature is supported. This requires feature support from gluster to identify a host with multiple names Change-Id: I2cf926a5446b2489e65d844be692761e02e42639 Bug-Url: https://bugzilla.redhat.com/1049994 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 9 files changed, 40 insertions(+), 0 deletions(-) Approvals: Sahina Bose: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cf926a5446b2489e65d844be692761e02e42639 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Validate change to gluster network
by sabose＠redhat.com 24 Mar '15

24 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Validate change to gluster network ...................................................................... engine: Validate change to gluster network Added validations for Manage networks to prevent gluster network role from being detached/unset when used by bricks in cluster Change-Id: I57398b39783dbdc5ae9f79e7d32794f416c23116 Bug-Url: https://bugzilla.redhat.com/1049994 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/create_views.sql M packaging/dbscripts/gluster_volumes_sp.sql 18 files changed, 162 insertions(+), 30 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57398b39783dbdc5ae9f79e7d32794f416c23116 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adding getAllVfsConfigByHostId to vfsConfig dao
by alkaplan＠redhat.com 24 Mar '15

24 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adding getAllVfsConfigByHostId to vfsConfig dao ...................................................................... engine: Adding getAllVfsConfigByHostId to vfsConfig dao Change-Id: I9cf46155cd86f02c6a77f11f6a46f03fd5171838 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDaoTest.java M packaging/dbscripts/network_sp.sql 4 files changed, 48 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cf46155cd86f02c6a77f11f6a46f03fd5171838 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Show networks tab in gluster only mode
by kmayilsa＠redhat.com 24 Mar '15

24 Mar '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Show networks tab in gluster only mode ...................................................................... webadmin: Show networks tab in gluster only mode The networks tab was earlier disabled in gluster only mode. But with the gluster network role feature, this is enabled again. Change-Id: I3864f8ebd41100124cb996463178f185f866118d Bug-Url: https://bugzilla.redhat.com/1049994 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/39085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3864f8ebd41100124cb996463178f185f866118d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: solve CDI beans detection. don't use beans.xml on exte...
by masayag＠redhat.com 24 Mar '15

24 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: core: solve CDI beans detection. don't use beans.xml on external jars ...................................................................... core: solve CDI beans detection. don't use beans.xml on external jars external jars (non ejb or dependent) are being scanned using an extension and ignored using regular weld scanning. in EAP version it is then detected twice which fails the server to load Change-Id: I5cb4412d91aa1b1ba429abeef190b4069cbf8196 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- D backend/manager/modules/dal/src/main/resources/META-INF/beans.xml 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cb4412d91aa1b1ba429abeef190b4069cbf8196 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Default de-activate volume snapshot after creation
by sabose＠redhat.com 24 Mar '15

24 Mar '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Default de-activate volume snapshot after creation ...................................................................... gluster: Default de-activate volume snapshot after creation The gluster volume snapshots should be in deactivated state after creation. Modified to mark the newly created volume snapshots as deactivated. Change-Id: I5c3efe787a979839456232331c673684c0184178 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c3efe787a979839456232331c673684c0184178 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: extract methods in permissionsListModel
by rgolan＠redhat.com 24 Mar '15

24 Mar '15

Roy Golan has submitted this change and it was merged. Change subject: webadmin: extract methods in permissionsListModel ...................................................................... webadmin: extract methods in permissionsListModel bring order and readability to the PermissionsListModel Change-Id: If910d6d2675f28e3d6c9c6df8e67f6801e2d42a5 Bug-Url: https://bugzilla.redhat.com/1080029 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java 1 file changed, 34 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/38411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If910d6d2675f28e3d6c9c6df8e67f6801e2d42a5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: expose permissions creation date
by rgolan＠redhat.com 24 Mar '15

24 Mar '15

Roy Golan has submitted this change and it was merged. Change subject: webadmin: expose permissions creation date ...................................................................... webadmin: expose permissions creation date Change-Id: I7c226ed01761ae3836940b5be6f2f2bd82a6f092 Bug-Url: https://bugzilla.redhat.com/1080029 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/38400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c226ed01761ae3836940b5be6f2f2bd82a6f092 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add creation_date to permissions entity
by rgolan＠redhat.com 24 Mar '15

24 Mar '15

Roy Golan has submitted this change and it was merged. Change subject: core: add creation_date to permissions entity ...................................................................... core: add creation_date to permissions entity Change-Id: Iedaf56522fc2af4c4cc8da9f5c1c2572fe4de706 Bug-Url: https://bugzilla.redhat.com/1080029 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permission.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1100_add_creation_date_to_permissions.sql 6 files changed, 67 insertions(+), 15 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedaf56522fc2af4c4cc8da9f5c1c2572fe4de706 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0