March 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: maintain camelCase

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: engine: maintain camelCase ...................................................................... engine: maintain camelCase Change-Id: Ie90f2b66ca6e3af71ffcec1a8b83a4af99fe8617 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 3 files changed, 24 insertions(+), 24 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90f2b66ca6e3af71ffcec1a8b83a4af99fe8617 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: frontend: Fix NPE in VmCountColumn

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix NPE in VmCountColumn ...................................................................... frontend: Fix NPE in VmCountColumn Integer VDS#getVmMigrating() was assigned to int Change-Id: I7114cc3b9ab92883b86229c7d59addd9a8dff3f2 Bug-Url: https://bugzilla.redhat.com/1204493 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmCountColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/38981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7114cc3b9ab92883b86229c7d59addd9a8dff3f2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix reporting user name in console events

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix reporting user name in console events ...................................................................... core: Fix reporting user name in console events When connecting/disconnecting to/from a console user name is not reported correctly in connect/disconnect event as it uses username from VDSM. But console user name is not reported by VDSM, it is set by the engine. This patch makes the console user name to be fetched from the DB. Change-Id: I3055973330a4be8caef7ea253f0f94af95d5f527 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 3 files changed, 5 insertions(+), 6 deletions(-) Approvals: Shmuel Leib Melamud: Looks good to me, but someone else must approve Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3055973330a4be8caef7ea253f0f94af95d5f527 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: fix typo in audit messages

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: fix typo in audit messages ...................................................................... engine: fix typo in audit messages Description of problem: There is a typographic error in the messages which prints/logs 'Clsuter' instead of 'Cluster'. multiple paragraphs if necessary. Diagnotics and cause: Gui team renamed 'Cluster Policy' to 'Scheduling Policy'. Due to typo error in log messages, skipped the rename in log reports. Solution: Rename 'Clsuter Policy' with 'Scheduling Policy' in backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties Change-Id: Ic86c208167456f837c259e6bd612ef1302d803c3 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic86c208167456f837c259e6bd612ef1302d803c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Add managemenet network field to new/edit cluster ...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add managemenet network field to new/edit cluster dialog ...................................................................... webadmin: Add managemenet network field to new/edit cluster dialog Add managemenet network field to new/edit cluster dialog. Change-Id: I055babd6037f127235c349499f1545396e38333f Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 8 files changed, 151 insertions(+), 34 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/37141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055babd6037f127235c349499f1545396e38333f Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: fix typos in HelpTag file

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: fix typos in HelpTag file ...................................................................... engine: fix typos in HelpTag file Change-Id: Iafffebff69ac448da52b222066ad34464dc855c0 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafffebff69ac448da52b222066ad34464dc855c0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: make UpdateVdsGroupCommand be able to get mgmt netwo...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: engine: make UpdateVdsGroupCommand be able to get mgmt network param ...................................................................... engine: make UpdateVdsGroupCommand be able to get mgmt network param Make UpdateVdsGroupCommand client be able to specify management network id when attaching a detached cluster to its new DC. Change-Id: I393fedd9e104acc84eb78ea239b4eb33f77ba802 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterResourceTest.java 5 files changed, 89 insertions(+), 39 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/37732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I393fedd9e104acc84eb78ea239b4eb33f77ba802 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Rename AsyncCommandCallBack to maintain camelCase

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Rename AsyncCommandCallBack to maintain camelCase ...................................................................... engine: Rename AsyncCommandCallBack to maintain camelCase Change-Id: I00d34428f0a397f38ca214a67d35e9ac17e7b67b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00d34428f0a397f38ca214a67d35e9ac17e7b67b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Standardize AsyncTaskStatus

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: Standardize AsyncTaskStatus ...................................................................... core: Standardize AsyncTaskStatus Change-Id: I9e9e7c2ee47386c6bae78c89247180aa7f32a524 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTaskStatus.java 1 file changed, 19 insertions(+), 21 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e9e7c2ee47386c6bae78c89247180aa7f32a524 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Activate vm pinning at request time

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: engine: Activate vm pinning at request time ...................................................................... engine: Activate vm pinning at request time When making a change to 'migrationSupport' field the value should be effective since the time of the save command. Not from time of next vm restart. Change-Id: If38d3dbc3ef3e35ff24f414abb6588eaaff679c3 Bug-Url: https://bugzilla.redhat.com/1058384 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Gilad Chaplik: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If38d3dbc3ef3e35ff24f414abb6588eaaff679c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2015